From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D1BA34CD3 for ; Fri, 15 Dec 2023 20:36:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bFLKVLtd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702672593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LqhsEugKtVuOP/CErLGwgtJcZIJDT+/OEzsNO/Pyaec=; b=bFLKVLtdwVthuoDJeRvxNahzdKf3+TEDBq+pgByr4XHfeF41NH8h/Q2HfjZ8X+ixBQ9fue 5T5xA8a7ibVzI9ljBO1jrUJbMfMmDubFXyu0mxxCfRU8sJrzelFtqOeW8AM7kFkwu2PFii KAYJgV4guDcbFPd9ugwAwJf7vCkjQMo= Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-kZ1uW9OiOL676gIf_oxgGA-1; Fri, 15 Dec 2023 15:36:32 -0500 X-MC-Unique: kZ1uW9OiOL676gIf_oxgGA-1 Received: by mail-oo1-f71.google.com with SMTP id 006d021491bc7-590f402d0c1so1338356eaf.0 for ; Fri, 15 Dec 2023 12:36:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702672591; x=1703277391; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LqhsEugKtVuOP/CErLGwgtJcZIJDT+/OEzsNO/Pyaec=; b=QS+cqGUED8DNar8zfOle6R05XYIJR32KcVEt7gLQoU07CuKlxl/X4TInbRJxtWP/wl w44eOEmx7UgMN4GafAllpPfymb8yVU31pr1M6RZfP72rzJJA1s2JTzRBtusN7fyNNj9u dTVR0lHUZT4/9tXfUqWw6Hn4//3sVrMbQMpSg13/nDSUo+K4/jrLXq8M0Hn9ZsDb2Oea Sod3J7EqWaUmLgQO94smgxi9gN90XDAXJUc/FVxOP1ujdmJ5573TqN6vmCmBusxKsHan 3NP0VWf8J5KQ18hqVmo56X4zUuYs2MouFa/TWUaxZPzHi4emVrpY743huAdL993E3NHU wMBA== X-Gm-Message-State: AOJu0YwZxhw8g2hGmoMQYuMPshYqZiaIcY1f6v5N0EnBc/rQ2sf59Mnr rjUg6UPhj28960V02GzV6NRaGZMHt16jQzLSeQJdn9g+ZzkcBtP+wZwWM2iMwcPrupuEOJ8G9e2 R9u+jP8wq13bnWpcJjKo0 X-Received: by 2002:a05:6359:6b82:b0:16e:579a:4d6b with SMTP id ta2-20020a0563596b8200b0016e579a4d6bmr8756632rwb.18.1702672591026; Fri, 15 Dec 2023 12:36:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IGwpyGuMx2YomS1YYURUwzmQgXKlPAVYfeFz7G58bPgH6jpGQedpReEFTAX5oswnIusdcpIrA== X-Received: by 2002:a05:6359:6b82:b0:16e:579a:4d6b with SMTP id ta2-20020a0563596b8200b0016e579a4d6bmr8756610rwb.18.1702672590685; Fri, 15 Dec 2023 12:36:30 -0800 (PST) Received: from [192.168.1.14] (pool-68-160-135-240.bstnma.fios.verizon.net. [68.160.135.240]) by smtp.gmail.com with ESMTPSA id w14-20020a0cef8e000000b0067f172531cbsm891936qvr.114.2023.12.15.12.36.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Dec 2023 12:36:30 -0800 (PST) Message-ID: <8a433f12-b930-6095-9a49-db5f1d2836b5@redhat.com> Date: Fri, 15 Dec 2023 15:36:28 -0500 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall Content-Language: en-US To: Shuah Khan Cc: mpdesouza@suse.com, Marcos Paulo de Souza , Shuah Khan , Jonathan Corbet , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Josh Poimboeuf , Jiri Kosina , Petr Mladek , linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, live-patching@vger.kernel.org, Miroslav Benes References: <20231031-send-lp-kselftests-v3-0-2b1655c2605f@suse.com> <20231031-send-lp-kselftests-v3-3-2b1655c2605f@suse.com> <8b95b96c-6aeb-4bf0-8ee9-2ba62330c672@linuxfoundation.org> <12a9ec1bc84dc6d4b461e5c780ba7d3c3aa91740.camel@suse.com> <76c4b967-1cb6-4f77-9402-f835b15adb10@linuxfoundation.org> <2498bf91-8057-43e8-98f2-4ed93c53ce9f@linuxfoundation.org> From: Joe Lawrence In-Reply-To: <2498bf91-8057-43e8-98f2-4ed93c53ce9f@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 12/11/23 16:53, Shuah Khan wrote: > On 12/6/23 07:39, Miroslav Benes wrote: >> Hi, >> >> On Tue, 5 Dec 2023, Shuah Khan wrote: >> >>> On 12/5/23 05:52, mpdesouza@suse.com wrote: >>>> On Fri, 2023-12-01 at 16:38 +0000, Shuah Khan wrote: >>> >>>> 0003-selftests-livepatch-Test-livepatching-a-heavily-call.patch has >>>> style problems, please review. >>>> >>>> NOTE: If any of the errors are false positives, please report >>>>         them to the maintainer, see CHECKPATCH in MAINTAINERS. >>>> >>>> I couldn't find any mention about "missing module name". Is your script >>>> showing more warnings than these ones? Can you please share your >>>> output? >>>> >>>> I'll fix MAINTAINERS file but I'll wait until I understand what's >>>> missing in your checkpatch script to resend the patchset. >>>> >>> >>> Looks like it is coming a script - still my question stands on >>> whether or not you would need a module name for this module? >> >> I admit I am also clueless here. The module name is given in Makefile. In >> this case in test_modules/Makefile. I do not know of anything else. There >> is no MODULE_NAME macro. Could you elaborate, please? >> > > I see that now. > Hi Shuah, In the other replies to this thread, Marcos noted that he would add some text to the commit / documentation on running and building the selftests directly in the kernel tree (that would get my Ack) ... is there anything else to be updated for a hopefully final v4 (for your Ack)? Thanks, -- Joe