From: Marek Vasut <marek.vasut@mailbox.org>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: linux-pci@vger.kernel.org,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Marc Zyngier" <maz@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3 1/5] PCI: dwc: Determine whether iMSI is used before calling .init
Date: Mon, 6 Jul 2026 19:48:24 +0200 [thread overview]
Message-ID: <8a921ce9-e339-445a-af05-d20f9f2df01e@mailbox.org> (raw)
In-Reply-To: <4qyn4fljtb3cbzcmfpkdomkm7vqnwn2rfbtqng4iwmtvfd4bpj@t6kkw53erl7f>
On 7/6/26 6:43 PM, Manivannan Sadhasivam wrote:
> On Wed, Jul 01, 2026 at 10:37:44PM +0200, Marek Vasut wrote:
>> The R-Car Gen4 PCIe controller integration configures MSI registers
>> in the controller driver .init callback, because those registers
>> have to be configured while PERST signal is asserted, and the PERST
>> signal is asserted across the controller driver .init callback.
>>
>> The registers have to be configured differently in case the iMSI is
>> or is not used. Assign pp->use_imsi_rx before the controller driver
>> .init callback is called, so the controller driver .init callback
>> implementation can use the pp->use_imsi_rx value.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>
> LGTM!
Thank you. Can I get AB/RB before sending V4 ?
next prev parent reply other threads:[~2026-07-06 17:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 20:37 [PATCH v3 0/5] PCI: rcar-gen4: irqchip/gic-v3: Handle GIC ITS Marek Vasut
2026-07-01 20:37 ` [PATCH v3 1/5] PCI: dwc: Determine whether iMSI is used before calling .init Marek Vasut
2026-07-06 16:43 ` Manivannan Sadhasivam
2026-07-06 17:48 ` Marek Vasut [this message]
2026-07-01 20:37 ` [PATCH v3 2/5] PCI: rcar-gen4: Configure AXIINTC if iMSI-RX not used Marek Vasut
2026-07-05 13:35 ` Marek Vasut
2026-07-01 20:37 ` [PATCH v3 4/5] irqchip/gic-v3: Add Renesas R-Car Gen4 erratum workaround Marek Vasut
2026-07-02 22:18 ` Thomas Gleixner
2026-07-01 20:37 ` [PATCH v3 5/5] arm64: dts: renesas: r8a779g0: Add GICv3 ITS and update PCIe nodes Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a921ce9-e339-445a-af05-d20f9f2df01e@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=maz@kernel.org \
--cc=robh@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox