From: Jacob Keller <jacob.e.keller@intel.com>
To: Abdelrahman Fekry <abdelrahmanfekry375@gmail.com>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <horms@kernel.org>, <corbet@lwn.net>
Cc: <netdev@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <skhan@linuxfoundation.com>,
<linux-kernel-mentees@lists.linux.dev>
Subject: Re: [PATCH 2/2] docs: net: clarify sysctl value constraints
Date: Thu, 12 Jun 2025 10:19:57 -0700 [thread overview]
Message-ID: <8b53b5be-82eb-458c-8269-d296bffcef33@intel.com> (raw)
In-Reply-To: <20250612162954.55843-3-abdelrahmanfekry375@gmail.com>
On 6/12/2025 9:29 AM, Abdelrahman Fekry wrote:
> So, i also noticed that some of the parameters represented
> as boolean have no value constrain checks and accept integer
> values due to u8 implementation, so i wrote a note for every
> boolean parameter that have no constrain checks in code. and
> fixed a typo in fmwark instead of fwmark.
>
> Added notes for 19 confirmed parameters,
> Verified by code inspection and runtime testing.
>
> Signed-off-by: Abdelrahman Fekry <abdelrahmanfekry375@gmail.com>
> ---
> Documentation/networking/ip-sysctl.rst | 50 +++++++++++++++++++++++---
> 1 file changed, 45 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst
> index f7ff8c53f412..99e786915204 100644
> --- a/Documentation/networking/ip-sysctl.rst
> +++ b/Documentation/networking/ip-sysctl.rst
> @@ -68,6 +68,8 @@ ip_forward_use_pmtu - BOOLEAN
>
> - 0 - disabled
> - 1 - enabled
> +
> + note: Accepts integer values (0-255) but only 0/1 have defined behaviour.
>
Hm. In many cases any non-zero value might be interpreted as "enabled" I
suppose that is simply "undefined behavior"?
prev parent reply other threads:[~2025-06-12 17:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 16:29 [PATCH 0/2] docs: net: sysctl documentation improvements Abdelrahman Fekry
2025-06-12 16:29 ` [PATCH 1/2] docs: net: sysctl documentation cleanup Abdelrahman Fekry
2025-06-12 17:18 ` Jacob Keller
2025-06-13 6:07 ` ALOK TIWARI
2025-06-14 9:25 ` [PATCH v2 " Abdelrahman Fekry
2025-06-14 17:46 ` Jakub Kicinski
2025-06-12 16:29 ` [PATCH 2/2] docs: net: clarify sysctl value constraints Abdelrahman Fekry
2025-06-12 17:19 ` Jacob Keller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b53b5be-82eb-458c-8269-d296bffcef33@intel.com \
--to=jacob.e.keller@intel.com \
--cc=abdelrahmanfekry375@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=skhan@linuxfoundation.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).