Linux Documentation
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Petar Stepanovic <pstepanovic@axiado.com>
Cc: Akhila Kavi <akavi@axiado.com>,
	Prasad Bolisetty <pbolisetty@axiado.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Tzu-Hao Wei <twei@axiado.com>,
	Karthikeyan Mitran <kmitran@axiado.com>,
	linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] hwmon: axiado-pwm-fan: Add missing documentation and MAINTAINERS entries
Date: Wed, 23 Sep 2026 07:46:36 -0700	[thread overview]
Message-ID: <8b761904-27e7-4e03-bc37-9fb048368b2b@roeck-us.net> (raw)
In-Reply-To: <20260923-axiado-pwm-fan-doc-fix-new-v1-1-8c8c2ce58a21@axiado.com>

On Wed, Sep 23, 2026 at 02:58:41AM -0700, Petar Stepanovic wrote:
> The axiado-pwm-fan entry was added to the hwmon documentation index, but
> the corresponding Documentation/hwmon/axiado-pwm-fan.rst file is missing.
> 
> The MAINTAINERS entry also only lists the devicetree binding and is missing
> entries for the hwmon documentation and driver.
> 
> Add the missing documentation file and MAINTAINERS entries.
> 
> Fixes: 2d52742f408f ("hwmon: add Axiado AX3000 and AX3005 PWM fan controller driver")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202609230904.aIWyLsSt-lkp@intel.com/
> Signed-off-by: Petar Stepanovic <pstepanovic@axiado.com>

Sorry for that. The patch did not apply due to conflicts, and I had to
apply manually using patch. Doing so I forgot to include the missing
entries.

I'll fold this patch into the original patch introducing the driver.

Thanks,
Guenter

> ---
> This patch adds the missing Axiado PWM fan documentation file and updates
> the MAINTAINERS entry to include the documentation and driver source
> files.
> ---
>  Documentation/hwmon/axiado-pwm-fan.rst | 38 ++++++++++++++++++++++++++++++++++
>  MAINTAINERS                            |  2 ++
>  2 files changed, 40 insertions(+)
> 
> 
> ---
> base-commit: bf92ea2a46120fd0809f24d39ad3482d0f20876b
> change-id: 20260923-axiado-pwm-fan-doc-fix-new-d0e42bbb0cbc
> 
> Best regards,
> --  
> Petar Stepanovic <pstepanovic@axiado.com>
> 
> diff --git a/Documentation/hwmon/axiado-pwm-fan.rst b/Documentation/hwmon/axiado-pwm-fan.rst
> new file mode 100644
> index 000000000000..d110e170b0df
> --- /dev/null
> +++ b/Documentation/hwmon/axiado-pwm-fan.rst
> @@ -0,0 +1,38 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
> +Kernel driver axiado-pwm-fan
> +============================
> +
> +Supported chips:
> +
> +  * Axiado AX3000
> +  * Axiado AX3005
> +
> +    Datasheet: Not publicly available
> +
> +Author:
> +
> +  * Petar Stepanovic <pstepanovic@axiado.com>
> +
> +Description
> +-----------
> +
> +The Axiado AX3000 and AX3005 PWM fan controllers measure the rotational
> +speed of one fan using a hardware tachometer block. Fan speed is controlled
> +through a PWM signal supplied by an external PWM controller.
> +
> +The number of tachometer pulses generated per fan revolution is configured
> +through the ``pulses-per-revolution`` devicetree property. If the property
> +is not specified, the driver uses two pulses per revolution.
> +
> +Sysfs attributes
> +----------------
> +
> +The driver provides the following standard hwmon attributes:
> +
> +=============== ====== =====================================================
> +fan1_input      RO     Fan speed in revolutions per minute (RPM).
> +
> +pwm1            RW     Relative PWM control value from 0 to 255. A value of
> +                       255 selects the maximum PWM duty cycle.
> +=============== ====== =====================================================
> diff --git a/MAINTAINERS b/MAINTAINERS
> index eb3cc6c81bcf..5ad12c57ca5f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4504,6 +4504,8 @@ M:	Prasad Bolisetty <pbolisetty@axiado.com>
>  L:	linux-hwmon@vger.kernel.org
>  S:	Supported
>  F:	Documentation/devicetree/bindings/hwmon/axiado,ax3000-pwm-fan.yaml
> +F:	Documentation/hwmon/axiado-pwm-fan.rst
> +F:	drivers/hwmon/axiado-pwm-fan.c
>  
>  AXIADO SPI DB DRIVER
>  M:	Vladimir Moravcevic <vmoravcevic@axiado.com>

  reply	other threads:[~2026-09-23 14:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23  9:58 [PATCH] hwmon: axiado-pwm-fan: Add missing documentation and MAINTAINERS entries Petar Stepanovic
2026-09-23 14:46 ` Guenter Roeck [this message]
2026-09-24  8:16   ` Petar Stepanovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b761904-27e7-4e03-bc37-9fb048368b2b@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=akavi@axiado.com \
    --cc=corbet@lwn.net \
    --cc=kmitran@axiado.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=pbolisetty@axiado.com \
    --cc=pstepanovic@axiado.com \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    --cc=twei@axiado.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox