From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8549633F3; Wed, 11 Jun 2025 02:31:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749609093; cv=none; b=ClHAoIO3RBjqRebKoPvt5pXJWaSPWeUe+uOODoOIpVqviS9rlLRseplKXneu/SMM3IzhMZqcUCVA1tDdl4DrP28aUxAcYZFAQYAgRnjEpprlwfG9qxM+0KzDR0YRl8nMEM7DVekzX3UnYzov4TX9VfNM0NGAGOweIt/RR2SjEgM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749609093; c=relaxed/simple; bh=xKLApFAUmBBV2gNprmC/rRPD/egFzWvaI4Tko/JzgfY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oXQEwk15Y0e7bOdBJN6CrsCELeOqKELe3g5ctkP4/DWNkzU/2kflQeDEUjOA3iQDL8nngybnpmitUULaCRyopFhtDjHwp6ZQv6K9SHStiFHCpjH0ObqsGr98hVOO8Z8fV7ECt6JbVGdJH870gfnNQw4wWj0/7p0qoYOWmnxzR08= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=gkOjWuSP; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="gkOjWuSP" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=uvt9EeGWy3wqr+k+UjVs97XuH58Op+Tg12f52xG4chE=; b=gkOjWuSP0yTsD/8ydglyIlHDP3 ZwmImnWA85s/I5MTDyxlweenVksfg+Duh1eVUar0eEgl2jKzqiUQEGJmD/+OsbgOyNlfq85kMzlSK 9uxZ3d86l34pcv9eGo8SzrBX4yq7nXiNiLb6xAabD5EgLNRcwOP7CWhG6J2tG9pLonFDuEdXBtsXM d/0FF9ljqLk3WH5R6rXaTAqtBnmsR0/1PJbRz21lvr1P+KT+FwtxS7apEvIpxVTprAKn8RB3ps//W vtJHoyaHNn9pmiecRZ2gDtd3QdWoLT3boc+msPJ9zyheR+k9gqJ7wrQ3QE8JuA3AxmwmAvlncPguL QF3Whctw==; Received: from [50.53.25.54] (helo=[192.168.254.17]) by desiato.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1uPBFO-000000024qV-1ClW; Wed, 11 Jun 2025 02:31:26 +0000 Message-ID: <8c8d82db-b8a1-481e-81c2-eeaa1ea0830d@infradead.org> Date: Tue, 10 Jun 2025 19:31:21 -0700 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] Documentation: nouveau: Update GSP message queue kernel-doc reference To: Bagas Sanjaya , Linux Kernel Mailing List , Linux Documentation , Linux DRI Development , Linux Nouveau Cc: David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jonathan Corbet , Dave Airlie , Ben Skeggs , Timur Tabi References: <20250611020805.22418-2-bagasdotme@gmail.com> Content-Language: en-US From: Randy Dunlap In-Reply-To: <20250611020805.22418-2-bagasdotme@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/10/25 7:08 PM, Bagas Sanjaya wrote: > GSP message queue docs has been moved following RPC handling split in > 8a8b1ec5261f20 ("drm/nouveau/gsp: split rpc handling out on its own"), > before GSP-RM implementation is versioned in c472d828348caf > ("drm/nouveau/gsp: move subdev/engine impls to subdev/gsp/rm/r535/"). > However, the kernel-doc reference in nouveau docs is left behind, which > triggers htmldocs warnings: > > ERROR: Cannot find file ./drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c > WARNING: No kernel-doc for file ./drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c > > Update the reference. > > Fixes: c472d828348c ("drm/nouveau/gsp: move subdev/engine impls to subdev/gsp/rm/r535/") > Fixes: 8a8b1ec5261f ("drm/nouveau/gsp: split rpc handling out on its own") > Signed-off-by: Bagas Sanjaya Acked-by: Randy Dunlap Tested-by: Randy Dunlap Thanks. > --- > Changes since v1 [1]: > > - Correct GSP kernel-doc reference file (Randy) > > [1]: https://lore.kernel.org/linux-doc/20250610065258.41467-1-bagasdotme@gmail.com/ > > Documentation/gpu/nouveau.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/gpu/nouveau.rst b/Documentation/gpu/nouveau.rst > index b8c801e0068cb0..cab2e81013bc5f 100644 > --- a/Documentation/gpu/nouveau.rst > +++ b/Documentation/gpu/nouveau.rst > @@ -25,7 +25,7 @@ providing a consistent API to upper layers of the driver stack. > GSP Support > ------------------------ > > -.. kernel-doc:: drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c > +.. kernel-doc:: drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/rpc.c > :doc: GSP message queue element > > .. kernel-doc:: drivers/gpu/drm/nouveau/include/nvkm/subdev/gsp.h > > base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494 -- ~Randy