From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CA87C433FE for ; Tue, 15 Nov 2022 00:33:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231602AbiKOAd5 (ORCPT ); Mon, 14 Nov 2022 19:33:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231557AbiKOAd4 (ORCPT ); Mon, 14 Nov 2022 19:33:56 -0500 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CB78E8B; Mon, 14 Nov 2022 16:33:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668472435; x=1700008435; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=+daAp9yRKxqxVx9ONETlA94YpPq9DtiM593w7JnMP9c=; b=PAaNe4pe90IngdGUGMxIhlzddRSMi+AW6mEOp77pZE9ll+Be33X5OtPk Vkt3JAFBaQ2k+9aelnAKVbdaMKNLdqhzYXJ2TOHyFJAnfNqQ5MG13s5Cf J8nUqybrZPjr3onoDDc6XrVEYjY/Twgi1zhEmgOLTzxcfXQPJMfxivxiX zvBhkEiAm76HiLX1chyzTrrK4Rg3BWSbyDFfrUMQNDncguoRKd5Fh5bsO nU+DrBxG0OFGrt/sB9W6TJA057HyRAiXQcIkQOav8cIVG9CAI5OyoBVjd iS39Jf1rr5W1myf2IUanKs99R9v+XEdWQSKye/jGcijV1pXpnZ3jpjrFG g==; X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="310829560" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="310829560" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2022 16:33:54 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="616534852" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="616534852" Received: from mmullick-mobl.amr.corp.intel.com (HELO [10.251.23.100]) ([10.251.23.100]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2022 16:33:53 -0800 Message-ID: <8d5f8a74-f864-3cd9-dac2-7650d83a8b90@linux.intel.com> Date: Mon, 14 Nov 2022 16:33:52 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.2.2 Subject: Re: [PATCH v17 1/3] x86/tdx: Add a wrapper to get TDREPORT from the TDX Module Content-Language: en-US To: Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Shuah Khan , Jonathan Corbet Cc: "H . Peter Anvin" , Greg Kroah-Hartman , "Kirill A . Shutemov" , Tony Luck , Kai Huang , Wander Lairson Costa , Isaku Yamahata , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org References: <20221104032355.227814-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20221104032355.227814-2-sathyanarayanan.kuppuswamy@linux.intel.com> <115a87d7-144a-2828-8e4f-9c1f156b73ae@intel.com> From: Sathyanarayanan Kuppuswamy In-Reply-To: <115a87d7-144a-2828-8e4f-9c1f156b73ae@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Hi Dave, On 11/11/22 10:35 AM, Dave Hansen wrote: > This is *NOT* "a wrapper to get TDREPORT from the TDX Module", this is > at best "a wrapper to get TDREPORT sub type 0 from the TDX Module". In both the commit log and the comments, I can highlight the "subtype 0" information. Will that work for you, or do you prefer that this wrapper take the "subtype" option as argument and we pass 0 for the subtype value from the TDX guest driver? > > It also occurs to me that "sub type 0" could use an actual name. Could > we give it one, please? Although the subtype option is mentioned in the TDX Module spec, it is not currently used (it expects this value to be zero), and the spec also does not explain why this option is required. According to TDX architects, this option was primarily added to handle any future requirements that may arise that require additional information to be added to the TDREPORT. However, they do not currently have any valid use cases for it. So the current version can only be described as "Type-0." Once a new use case for Subtype 1 is defined, we may be able to come up with a suitable name. Are you okay with calling it "Type-0" for the time being? -- Sathyanarayanan Kuppuswamy Linux Kernel Developer