From: Chao Yu <yuchao0@huawei.com>
To: Daniel Rosenberg <drosen@google.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
<linux-f2fs-devel@lists.sourceforge.net>
Cc: <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>, <kernel-team@android.com>
Subject: Re: [PATCH v2 2/2] f2fs: Support case-insensitive file name lookups
Date: Fri, 19 Jul 2019 10:01:25 +0800 [thread overview]
Message-ID: <8f1c8f28-9afa-94b0-05b2-12df71db201c@huawei.com> (raw)
In-Reply-To: <4ef17922-d1e9-1b83-9e89-d332ea6fb7ae@google.com>
On 2019/7/19 5:31, Daniel Rosenberg wrote:
>
> On 7/17/19 3:11 AM, Chao Yu wrote:
>> We need to add one more entry f2fs_fsflags_map[] to map F2FS_CASEFOLD_FL to
>> FS_CASEFOLD_FL correctly and adapt F2FS_GETTABLE_FS_FL/F2FS_SETTABLE_FS_FL as well.
>
> I don't see FS_CASEFOLD_FL. It would make sense for it to exist, but unless it's in some recent patch I don't think that's currently in the kernel. Or are you suggesting adding it in this patch?
Yeah, I think we can use a separated patch to propose uplifting the flag to a
common one in fs.h, and then adjust
f2fs_fsflags_map/F2FS_GETTABLE_FS_FL/F2FS_SETTABLE_FS_FL mapping. Otherwise we
will fail to set CASEFOLD flag to inode.
Thanks,
>
> .
>
prev parent reply other threads:[~2019-07-19 2:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 3:14 [PATCH v2 0/2] Casefolding in F2FS Daniel Rosenberg
2019-07-17 3:14 ` [PATCH v2 1/2] f2fs: include charset encoding information in the superblock Daniel Rosenberg
2019-07-17 9:39 ` Chao Yu
2019-07-17 3:14 ` [PATCH v2 2/2] f2fs: Support case-insensitive file name lookups Daniel Rosenberg
2019-07-17 10:11 ` Chao Yu
2019-07-18 21:31 ` Daniel Rosenberg
2019-07-19 2:01 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f1c8f28-9afa-94b0-05b2-12df71db201c@huawei.com \
--to=yuchao0@huawei.com \
--cc=corbet@lwn.net \
--cc=drosen@google.com \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox