From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F0792AEED for ; Tue, 18 Mar 2025 08:39:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742287170; cv=none; b=KvaV9vW42b3jWw7NLd8SXdYWXuR/locK3R1Jh7ntiifpgqlMvQHC5NQ2zITIgcFzLW9pZoTkFqC4JnUCdvVGSWMIEmML0AwtoU4Z2RdIaNiW+dDlTfET2miZj2BOHMOVU/9vfQ+YTKw2s2u+vHedK8M+3SRM/tJnJgLCWDYAxtE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742287170; c=relaxed/simple; bh=FQ4xSX7c3WjFB6LdpO8VQQHptKeGaZvZ79lk7PEmeu4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eIuoa8w03uPG8uzTXTclI1hMKS4vFOhit36eBB40ESzvur7UYJFmoSiavIXByScDRoHIZ0aKYsNpqv/1xuozAAj3YNQy+Pct+aALViWEXUKToacZLuBVvXg/SJ9dlgyR6EEa7R09oYSiCkCLI7QVStib7IGP9Nuztmo16Sbv1nA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Fj/Y5uSO; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Fj/Y5uSO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742287163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QJ0VMEseaolIU+CS+bme3Nsh7S58tb1KlcpXTP+Vo3o=; b=Fj/Y5uSOPZI52WMg0mfjr313t0wVd8o2mAvwCXVjiAY+ItZi1/Ho4oXivUGIR+2yGjwx/V pR2viuhJcWZnfi2hkP/8T9JA5vhx6/4+Z1i5+jBrhX9Zo+zA5nV+SsY+w+RnYdpdWJ6kjv YZ5Hxcy7SaM695bQxmJr+zXQYNfkXtY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-136-C7jnfXSgO5miENfl7Qnndw-1; Tue, 18 Mar 2025 04:39:22 -0400 X-MC-Unique: C7jnfXSgO5miENfl7Qnndw-1 X-Mimecast-MFC-AGG-ID: C7jnfXSgO5miENfl7Qnndw_1742287161 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43947979ce8so14914455e9.0 for ; Tue, 18 Mar 2025 01:39:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742287161; x=1742891961; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QJ0VMEseaolIU+CS+bme3Nsh7S58tb1KlcpXTP+Vo3o=; b=qoURQ4+8kIPuDQTwrBKxj5/FWGXCS7FbU4AMJulRW5GONFfILSLlsyV18coEzdJMOw Ir+M879/bI1kA2wc5tmf835VYRB7xFwFSR3o7mtA6gcQhJOkcipDV/RQtk1264HpzHma dADt0vCmu4+Xb25zX7kPfIWbwUTEnWIdfSzyK9xOI0RptbeptV21JQ1/OHjKBneaauCw HfRvlsolEwQHatzrNkKvrMYqeDmYwEtbbLHzFexVuB+mHC/TtVqI5RuMKhXi4Oc5KBys VO2BdVwg5aoBkFM5XgIguiO7+Dr//h00iJLSQ20J9CsXhLy0B7Vg5HTCziG1fbH4yz/C 6H5A== X-Forwarded-Encrypted: i=1; AJvYcCWAm0ReCMYQph3uBI2MjPskqDOIPw9TxBasfakcfEIq2Yfozo7sKM3NND/yQCTFWp8IV124b9cmtRM=@vger.kernel.org X-Gm-Message-State: AOJu0YwkjhsvyZYfZ/sXgOzj7klkWc8n5rmh5xeXE2Cy1PqHrGSixjgl lz05PeX8HCsYzDwOKkmyTCxzoCYTQjNwDOaklMK/EacblKSOkfnmwwvT/tz82TwzeIukFjOw6hj 9Pg1VauizkTccfsKokByVLab5731eKtS86RrpwEZh5fmedtoBnpgueEGZeA== X-Gm-Gg: ASbGnctzk2yO2DOVQud/zy5C0GZt8biKAy9CMYP0G6uKwM01GMoBcytSNBbFmluszaF v5xBPOKvqbqfMYHOx3Pg1rB6bQ1Az8tXsNsNgZS4n9eXBiGv1mvnmL2IUUdpW6cGMr+yV9+jwPv yEoTJy7//AERa3aRhFoW3kh69eh9ZZXwoCmXSYaVqrMNXbgAVIgqdklDceFpcTunAtVuFqQqqEJ gLOlM9xiIKdeLeeWedArXwNu2p+dpRsI2ECoLAMDZv61JUkftCL25QcHc6Sj5eFgOuoRUMF+BM2 aLNJVDy0T1H4UVSYEpzy2dt3XmqsNgC9kn5hk9EDF5SJ6Q== X-Received: by 2002:a5d:6484:0:b0:390:df02:47f0 with SMTP id ffacd0b85a97d-3971ee444e2mr15972237f8f.42.1742287160747; Tue, 18 Mar 2025 01:39:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH7stufewyuFI6UX+sGIqRr7QTxoyguINXWTrLlPA7lpLF9hM8oFkQrmLLjxUlPq2VCHq/n8Q== X-Received: by 2002:a5d:6484:0:b0:390:df02:47f0 with SMTP id ffacd0b85a97d-3971ee444e2mr15972216f8f.42.1742287160309; Tue, 18 Mar 2025 01:39:20 -0700 (PDT) Received: from [192.168.88.253] (146-241-10-172.dyn.eolo.it. [146.241.10.172]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c83b748bsm17684458f8f.39.2025.03.18.01.39.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Mar 2025 01:39:19 -0700 (PDT) Message-ID: <8fb48d36-f5ce-40ce-bb05-b4c342da8b4f@redhat.com> Date: Tue, 18 Mar 2025 09:39:17 +0100 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v7 3/9] net: devmem: TCP tx netlink api To: Mina Almasry , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-kselftest@vger.kernel.org Cc: Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Simon Horman , Jonathan Corbet , Andrew Lunn , Jeroen de Borst , Harshitha Ramamurthy , Kuniyuki Iwashima , Willem de Bruijn , David Ahern , Neal Cardwell , Stefan Hajnoczi , Stefano Garzarella , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Shuah Khan , sdf@fomichev.me, asml.silence@gmail.com, dw@davidwei.uk, Jamal Hadi Salim , Victor Nogueira , Pedro Tammela , Samiullah Khawaja References: <20250308214045.1160445-1-almasrymina@google.com> <20250308214045.1160445-4-almasrymina@google.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250308214045.1160445-4-almasrymina@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/8/25 10:40 PM, Mina Almasry wrote: > From: Stanislav Fomichev > > Add bind-tx netlink call to attach dmabuf for TX; queue is not > required, only ifindex and dmabuf fd for attachment. > > Signed-off-by: Stanislav Fomichev > Signed-off-by: Mina Almasry > > --- > > v3: > - Fix ynl-regen.sh error (Simon). > > --- > Documentation/netlink/specs/netdev.yaml | 12 ++++++++++++ > include/uapi/linux/netdev.h | 1 + > net/core/netdev-genl-gen.c | 13 +++++++++++++ > net/core/netdev-genl-gen.h | 1 + > net/core/netdev-genl.c | 6 ++++++ > tools/include/uapi/linux/netdev.h | 1 + > 6 files changed, 34 insertions(+) > > diff --git a/Documentation/netlink/specs/netdev.yaml b/Documentation/netlink/specs/netdev.yaml > index 36f1152bfac3..e560b05eb528 100644 > --- a/Documentation/netlink/specs/netdev.yaml > +++ b/Documentation/netlink/specs/netdev.yaml > @@ -743,6 +743,18 @@ operations: > - defer-hard-irqs > - gro-flush-timeout > - irq-suspend-timeout > + - > + name: bind-tx > + doc: Bind dmabuf to netdev for TX > + attribute-set: dmabuf > + do: > + request: > + attributes: > + - ifindex > + - fd > + reply: > + attributes: > + - id > > kernel-family: > headers: [ "linux/list.h"] > diff --git a/include/uapi/linux/netdev.h b/include/uapi/linux/netdev.h > index 7600bf62dbdf..7eb9571786b8 100644 > --- a/include/uapi/linux/netdev.h > +++ b/include/uapi/linux/netdev.h > @@ -219,6 +219,7 @@ enum { > NETDEV_CMD_QSTATS_GET, > NETDEV_CMD_BIND_RX, > NETDEV_CMD_NAPI_SET, > + NETDEV_CMD_BIND_TX, > > __NETDEV_CMD_MAX, > NETDEV_CMD_MAX = (__NETDEV_CMD_MAX - 1) > diff --git a/net/core/netdev-genl-gen.c b/net/core/netdev-genl-gen.c > index 996ac6a449eb..f27608d6301c 100644 > --- a/net/core/netdev-genl-gen.c > +++ b/net/core/netdev-genl-gen.c > @@ -99,6 +99,12 @@ static const struct nla_policy netdev_napi_set_nl_policy[NETDEV_A_NAPI_IRQ_SUSPE > [NETDEV_A_NAPI_IRQ_SUSPEND_TIMEOUT] = { .type = NLA_UINT, }, > }; > > +/* NETDEV_CMD_BIND_TX - do */ > +static const struct nla_policy netdev_bind_tx_nl_policy[NETDEV_A_DMABUF_FD + 1] = { > + [NETDEV_A_DMABUF_IFINDEX] = NLA_POLICY_MIN(NLA_U32, 1), > + [NETDEV_A_DMABUF_FD] = { .type = NLA_U32, }, > +}; > + > /* Ops table for netdev */ > static const struct genl_split_ops netdev_nl_ops[] = { > { > @@ -190,6 +196,13 @@ static const struct genl_split_ops netdev_nl_ops[] = { > .maxattr = NETDEV_A_NAPI_IRQ_SUSPEND_TIMEOUT, > .flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO, > }, > + { > + .cmd = NETDEV_CMD_BIND_TX, > + .doit = netdev_nl_bind_tx_doit, > + .policy = netdev_bind_tx_nl_policy, > + .maxattr = NETDEV_A_DMABUF_FD, > + .flags = GENL_CMD_CAP_DO, > + }, > }; > > static const struct genl_multicast_group netdev_nl_mcgrps[] = { > diff --git a/net/core/netdev-genl-gen.h b/net/core/netdev-genl-gen.h > index e09dd7539ff2..c1fed66e92b9 100644 > --- a/net/core/netdev-genl-gen.h > +++ b/net/core/netdev-genl-gen.h > @@ -34,6 +34,7 @@ int netdev_nl_qstats_get_dumpit(struct sk_buff *skb, > struct netlink_callback *cb); > int netdev_nl_bind_rx_doit(struct sk_buff *skb, struct genl_info *info); > int netdev_nl_napi_set_doit(struct sk_buff *skb, struct genl_info *info); > +int netdev_nl_bind_tx_doit(struct sk_buff *skb, struct genl_info *info); > > enum { > NETDEV_NLGRP_MGMT, > diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c > index 2b774183d31c..6e5f2de4d947 100644 > --- a/net/core/netdev-genl.c > +++ b/net/core/netdev-genl.c > @@ -931,6 +931,12 @@ int netdev_nl_bind_rx_doit(struct sk_buff *skb, struct genl_info *info) > return err; > } > > +/* stub */ > +int netdev_nl_bind_tx_doit(struct sk_buff *skb, struct genl_info *info) > +{ > + return 0; > +} > + > void netdev_nl_sock_priv_init(struct list_head *priv) > { > INIT_LIST_HEAD(priv); I'm sorry, but this chunck does not apply cleanly anymore. Please rebase. Disclaimer: unfortunately I must note that due to the long backlog pending and the upcoming merge window, I'm unsure I'll be able to process the next revision before the net-next closing. Thanks. Paolo