From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2D597E10D for ; Thu, 29 Feb 2024 14:29:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709216982; cv=none; b=lIbcxFQy0j3e6An57wh0cOxerkDaWwJ30WkS/2GKr7hs62U6Q5wGXfgUQABt50K4ehU5bizkrDVDv2HDnbgcuZLPSY0SRlUYPNXQRjtEs6TIv4OsplsCndqyX7krf1LdQHHtynA+WfaC8Bajin2QMFhEZ94OS58gO8V/dcP8mSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709216982; c=relaxed/simple; bh=K4+fbJQvKKYfXr6QSBPwM7KmLB+wWWg+oWBZ19i7qns=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sYbLgwSa1F03HSyK3yBFU5ZvGC/kx7NsboLWiWOK0VbjsVzR4RlOb9wc77nwIPDhJHVTUfen1cCX8nf5ZOp0Ik3oFtsoolAy+kJUC47rkTT+r6qgGlpdZRi27N/KteYvW1oXl4zfguF4EJhnQYXAyKDfkL1WMrn2hbakd6dsY44= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gTOj0MtF; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gTOj0MtF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709216979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iiT3XNyZUH95vAKW5douxdlTZiY7Es2dmDaVN90xKxw=; b=gTOj0MtF+mw8TEZ1KmYlCRZo619VJcX0tIKIyJ2LOnyvHZwcBwIe5SDJ8KegjYbpJZJzAi fQk+7CPEWwoy5ep6ZMuwc4aywhXImS3JlvukKjOxvzzF1/oQT6o8zDa6E8DLNopaLOTtOy XDIGTMaU0KtdGS33kU3qF7u4PGScOkA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-214-MR_t1szwNcy432pLgrTpJA-1; Thu, 29 Feb 2024 09:29:35 -0500 X-MC-Unique: MR_t1szwNcy432pLgrTpJA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6338F85A599; Thu, 29 Feb 2024 14:29:31 +0000 (UTC) Received: from [10.22.8.117] (unknown [10.22.8.117]) by smtp.corp.redhat.com (Postfix) with ESMTP id 36B2D492BE2; Thu, 29 Feb 2024 14:29:30 +0000 (UTC) Message-ID: <90394965-e2a4-4915-a717-eef75f660dfb@redhat.com> Date: Thu, 29 Feb 2024 09:29:29 -0500 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] cgroup/cpuset: Remove cpuset_do_slab_mem_spread() Content-Language: en-US To: Xiongwei Song , lizefan.x@bytedance.com, tj@kernel.org, hannes@cmpxchg.org, corbet@lwn.net Cc: vbabka@suse.cz, yosryahmed@google.com, rostedt@goodmis.org, cl@linux.com, chengming.zhou@linux.dev, zhengyejian1@huawei.com, cgroups@vger.kernel.org, linux-mmc@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240229142007.1278610-1-xiongwei.song@windriver.com> From: Waiman Long In-Reply-To: <20240229142007.1278610-1-xiongwei.song@windriver.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 On 2/29/24 09:20, Xiongwei Song wrote: > The SLAB allocator has been removed sine 6.8-rc1 [1], so there is no user > with SLAB_MEM_SPREAD and cpuset_do_slab_mem_spread(). Then SLAB_MEM_SPREAD > is marked as unused by [2]. Here we can remove > cpuset_do_slab_mem_spread(). For more details, please check [3]. > > [1] https://lore.kernel.org/linux-mm/20231120-slab-remove-slab-v2-0-9c9c70177183@suse.cz/ > [2] https://lore.kernel.org/linux-kernel/20240223-slab-cleanup-flags-v2-0-02f1753e8303@suse.cz/T/ > [3] https://lore.kernel.org/lkml/32bc1403-49da-445a-8c00-9686a3b0d6a3@redhat.com/T/#mf14b838c5e0e77f4756d436bac3d8c0447ea4350 > > Signed-off-by: Xiongwei Song > --- > include/linux/cpuset.h | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h > index 875d12598bd2..0ce6ff0d9c9a 100644 > --- a/include/linux/cpuset.h > +++ b/include/linux/cpuset.h > @@ -121,11 +121,6 @@ static inline int cpuset_do_page_mem_spread(void) > return task_spread_page(current); > } > > -static inline int cpuset_do_slab_mem_spread(void) > -{ > - return task_spread_slab(current); > -} > - > extern bool current_cpuset_is_being_rebound(void); > > extern void rebuild_sched_domains(void); > @@ -264,11 +259,6 @@ static inline int cpuset_do_page_mem_spread(void) > return 0; > } > > -static inline int cpuset_do_slab_mem_spread(void) > -{ > - return 0; > -} > - > static inline bool current_cpuset_is_being_rebound(void) > { > return false; Reviewed-by: Waiman Long