[PATCH] kernel-doc: support DECLARE_PHY_INTERFACE_MASK()

[PATCH] kernel-doc: support DECLARE_PHY_INTERFACE_MASK()

[Randy Dunlap]

Support the DECLARE_PHY_INTERFACE_MASK() macro that is used to declare
a bitmap by converting the macro to DECLARE_BITMAP(), as has been done
for the __ETHTOOL_DECLARE_LINK_MODE_MASK() macro.

This fixes a 'make htmldocs' warning:

include/linux/phylink.h:82: warning: Function parameter or member 'DECLARE_PHY_INTERFACE_MASK(supported_interfaces' not described in 'phylink_config'

that was introduced by commit
  38c310eb46f5 ("net: phylink: add MAC phy_interface_t bitmap")

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Russell King (Oracle) <linux@armlinux.org.uk>
Cc: linux-doc@vger.kernel.org
To: Jonathan Corbet <corbet@lwn.net>
---
 scripts/kernel-doc |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20211029.orig/scripts/kernel-doc
+++ linux-next-20211029/scripts/kernel-doc
@@ -1256,6 +1256,7 @@ sub dump_struct($$) {
 	my $args = qr{([^,)]+)};
 	# replace DECLARE_BITMAP
 	$members =~ s/__ETHTOOL_DECLARE_LINK_MODE_MASK\s*\(([^\)]+)\)/DECLARE_BITMAP($1, __ETHTOOL_LINK_MODE_MASK_NBITS)/gos;
+	$members =~ s/DECLARE_PHY_INTERFACE_MASK\s*\(([^\)]+)\)/DECLARE_BITMAP($1, PHY_INTERFACE_MODE_MAX)/gos;
 	$members =~ s/DECLARE_BITMAP\s*\($args,\s*$args\)/unsigned long $1\[BITS_TO_LONGS($2)\]/gos;
 	# replace DECLARE_HASHTABLE
 	$members =~ s/DECLARE_HASHTABLE\s*\($args,\s*$args\)/unsigned long $1\[1 << (($2) - 1)\]/gos;

Re: [PATCH] kernel-doc: support DECLARE_PHY_INTERFACE_MASK()

[Russell King (Oracle)]

On Fri, Oct 29, 2021 at 07:08:13PM -0700, Randy Dunlap wrote:
> Support the DECLARE_PHY_INTERFACE_MASK() macro that is used to declare
> a bitmap by converting the macro to DECLARE_BITMAP(), as has been done
> for the __ETHTOOL_DECLARE_LINK_MODE_MASK() macro.
> 
> This fixes a 'make htmldocs' warning:
> 
> include/linux/phylink.h:82: warning: Function parameter or member 'DECLARE_PHY_INTERFACE_MASK(supported_interfaces' not described in 'phylink_config'
> 
> that was introduced by commit
>   38c310eb46f5 ("net: phylink: add MAC phy_interface_t bitmap")
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Russell King (Oracle) <linux@armlinux.org.uk>

Thanks Randy, sorry I missed this patch.

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

What is the intention for merging this patch? Will Jon merge it?
Your tags said To: Jon but you don't seem to have included him in
the email.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

Re: [PATCH] kernel-doc: support DECLARE_PHY_INTERFACE_MASK()

[Randy Dunlap]

On 4/13/22 04:09, Russell King (Oracle) wrote:
> On Fri, Oct 29, 2021 at 07:08:13PM -0700, Randy Dunlap wrote:
>> Support the DECLARE_PHY_INTERFACE_MASK() macro that is used to declare
>> a bitmap by converting the macro to DECLARE_BITMAP(), as has been done
>> for the __ETHTOOL_DECLARE_LINK_MODE_MASK() macro.
>>
>> This fixes a 'make htmldocs' warning:
>>
>> include/linux/phylink.h:82: warning: Function parameter or member 'DECLARE_PHY_INTERFACE_MASK(supported_interfaces' not described in 'phylink_config'
>>
>> that was introduced by commit
>>   38c310eb46f5 ("net: phylink: add MAC phy_interface_t bitmap")
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> Cc: Russell King (Oracle) <linux@armlinux.org.uk>
> 
> Thanks Randy, sorry I missed this patch.
> 
> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> 
> What is the intention for merging this patch? Will Jon merge it?
> Your tags said To: Jon but you don't seem to have included him in
> the email.

Hm, I didn't notice that.
Guess I'll resend it with your R-b.

thanks.

-- 
~Randy

Re: [PATCH] kernel-doc: support DECLARE_PHY_INTERFACE_MASK()

[Randy Dunlap]

On 4/13/22 08:19, Randy Dunlap wrote:
> 
> 
> On 4/13/22 04:09, Russell King (Oracle) wrote:
>> On Fri, Oct 29, 2021 at 07:08:13PM -0700, Randy Dunlap wrote:
>>> Support the DECLARE_PHY_INTERFACE_MASK() macro that is used to declare
>>> a bitmap by converting the macro to DECLARE_BITMAP(), as has been done
>>> for the __ETHTOOL_DECLARE_LINK_MODE_MASK() macro.
>>>
>>> This fixes a 'make htmldocs' warning:
>>>
>>> include/linux/phylink.h:82: warning: Function parameter or member 'DECLARE_PHY_INTERFACE_MASK(supported_interfaces' not described in 'phylink_config'
>>>
>>> that was introduced by commit
>>>   38c310eb46f5 ("net: phylink: add MAC phy_interface_t bitmap")
>>>
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>>> Cc: Russell King (Oracle) <linux@armlinux.org.uk>
>>
>> Thanks Randy, sorry I missed this patch.
>>
>> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
>>
>> What is the intention for merging this patch? Will Jon merge it?
>> Your tags said To: Jon but you don't seem to have included him in
>> the email.
> 
> Hm, I didn't notice that.
> Guess I'll resend it with your R-b.

No need to resend it. It's already merged into mainline.

-- 
~Randy