From: Guenter Roeck <linux@roeck-us.net>
To: Akshay Gupta <Akshay.Gupta@amd.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org
Cc: corbet@lwn.net, skhan@linuxfoundation.org, arnd@arndb.de,
gregkh@linuxfoundation.org, NaveenKrishna.Chatradhi@amd.com,
Anand.Umarji@amd.com, Prathima.Lk@amd.com
Subject: Re: [PATCH v4 1/8] hwmon/misc: amd-sbi: Move core sbtsi support from hwmon to misc
Date: Fri, 10 Jul 2026 07:26:12 -0700 [thread overview]
Message-ID: <91905ecd-b7fa-46ea-8936-90c37b85e794@roeck-us.net> (raw)
In-Reply-To: <20260710111642.850022-2-Akshay.Gupta@amd.com>
On 7/10/26 04:16, Akshay Gupta wrote:
> From: Prathima <Prathima.Lk@amd.com>
>
> Move SBTSI(Side-Band Temperature Sensor Interface) core functionality out
> of the hwmon-only path and into drivers/misc/amd-sbi so it can be reused
> by non-hwmon consumers.
>
> I2C probe parsing is moved from drivers/hwmon/sbtsi_temp.c
> into drivers/misc/amd-sbi/tsi.c under CONFIG_AMD_SBTSI. The core driver
> stores struct sbtsi_data on the bus device and registers an auxiliary
> device amd-sbtsi.temp-sensor.<addr> per target.
> The current hwmon temp sensor will now require the CONFIG_AMD_SBTSI
> configuration as a new dependency.
>
> This split prepares the driver for additional interfaces while keeping
> hwmon support in hwmon subsystem on top of common SBTSI core logic.
>
> Add platform dependencies to clarify this driver is intended to run on
> the BMC and not on the managed node.
>
> Reviewed-by: Akshay Gupta <Akshay.Gupta@amd.com>
> Signed-off-by: Prathima <Prathima.Lk@amd.com>
Regarding Sashiko's comments, I asume there can only be one of these
in a given system.
Given that,
Acked-by: Guenter Roeck <linux@roeck-us.net>
[ Assuming that the series will be picked up together through some
other maintainer ]
Thanks,
Guenter
next prev parent reply other threads:[~2026-07-10 14:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 11:16 [PATCH v4 0/8] misc: amd-sbi: Refactor SBTSI driver with I3C support and ioctl interface Akshay Gupta
2026-07-10 11:16 ` [PATCH v4 1/8] hwmon/misc: amd-sbi: Move core sbtsi support from hwmon to misc Akshay Gupta
2026-07-10 14:26 ` Guenter Roeck [this message]
2026-07-10 11:16 ` [PATCH v4 2/8] hwmon: sbtsi_temp: Refactor temperature register access into helpers Akshay Gupta
2026-07-10 14:27 ` Guenter Roeck
2026-07-10 11:16 ` [PATCH v4 3/8] hwmon/misc: amd-sbi: Move sbtsi register transfer to core abstraction Akshay Gupta
2026-07-10 14:28 ` Guenter Roeck
2026-07-10 11:16 ` [PATCH v4 4/8] misc: amd-sbi: Consolidate Common SBTSI Probe Path Akshay Gupta
2026-07-10 11:16 ` [PATCH v4 5/8] misc: amd-sbi: Add support for SB-TSI over I3C Akshay Gupta
2026-07-10 11:16 ` [PATCH v4 6/8] misc: amd-sbi: Add SBTSI ioctl register transfer interface Akshay Gupta
2026-07-10 11:16 ` [PATCH v4 7/8] hwmon: Add mutex protecting for sbtsi read/write through hwmon Akshay Gupta
2026-07-10 14:28 ` Guenter Roeck
2026-07-10 11:16 ` [PATCH v4 8/8] docs: misc: amd-sbi: Document SBTSI userspace interface Akshay Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91905ecd-b7fa-46ea-8936-90c37b85e794@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Akshay.Gupta@amd.com \
--cc=Anand.Umarji@amd.com \
--cc=NaveenKrishna.Chatradhi@amd.com \
--cc=Prathima.Lk@amd.com \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox