From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
netdev <netdev@vger.kernel.org>,
Linux Docs <linux-doc@vger.kernel.org>
Subject: Re: Checkpatch False positive
Date: Mon, 20 Aug 2018 13:32:33 -0700 [thread overview]
Message-ID: <933f909db5ae9bc96c5be2bb503081eb5714adbc.camel@intel.com> (raw)
In-Reply-To: <20180820202250.GA6345@bombadil.infradead.org>
[-- Attachment #1: Type: text/plain, Size: 735 bytes --]
On Mon, 2018-08-20 at 13:22 -0700, Matthew Wilcox wrote:
> On Mon, Aug 20, 2018 at 01:21:30PM -0700, Jeff Kirsher wrote:
> > Checkpatch.pl should probably exclude *.rst files from the SPDX
> > License
> > Identifier check, since they are documentational files, like
> > *.txt.
>
> They're still copyrighted work, so they should still have SPDX tags
> to identify their license.
>
> checkpatch has:
>
> } elsif ($realfile =~ /\.rst$/) {
> $comment = '..';
>
> so we're explicitly including rst files in the checking for now.
Ah, sorry. I did not catch that they started to include SPDX-License-
Identifiers for RST files, thanks Matthew.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-08-20 20:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 20:21 Checkpatch False positive Jeff Kirsher
2018-08-20 20:22 ` Matthew Wilcox
2018-08-20 20:32 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=933f909db5ae9bc96c5be2bb503081eb5714adbc.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox