From: Krzysztof Kozlowski <krzk@kernel.org>
To: Victor.Duicu@microchip.com, linux@roeck-us.net
Cc: corbet@lwn.net, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org, robh@kernel.org,
linux-kernel@vger.kernel.org, krzk+dt@kernel.org,
linux-doc@vger.kernel.org, Marius.Cristea@microchip.com,
conor+dt@kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: add support for MCP998X
Date: Fri, 6 Feb 2026 17:49:08 +0100 [thread overview]
Message-ID: <942d6dc7-26ad-405a-bb6a-270e2261a329@kernel.org> (raw)
In-Reply-To: <595e616ad403e805ee50fa7bc57d25584949924d.camel@microchip.com>
On 06/02/2026 15:17, Victor.Duicu@microchip.com wrote:
>>> +
>>> + interrupts:
>>> + items:
>>> + - description: Signal coming from ALERT/THERM pin.
>>> + - description: Signal coming from THERM/ADDR pin.
>>> + - description: Signal coming from SYS_SHDN pin.
>>> +
>>> + interrupt-names:
>>> + items:
>>> + - const: alert-therm
>>> + - const: therm-addr
>>> + - const: sys-shutdown
>>
>> The top-level definition of interrupt-names specifies exactly 3
>> items.
>> How does this interact with variants that only have 2 interrupts?
>>
>
> The chips with "D" in the family have the sys-shutdown and alert-therm
> interrupt pins. The rest have alert-therm and therm-addr interrupt
> pins. The conditional assigns the interrupt names depending on the
> chip.
No, the top level says you have three interrupts. Do not create bindings
which contradict themselves.
More important I am 100% sure this fails tests if you wrote proper, so a
complete example. It passes only because you made a limited example,
without properties.
No, drop review, fix and request re-review.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-06 16:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 15:18 [PATCH v3 0/2] add support in hwmon for MCP998X victor.duicu
2026-01-27 15:18 ` [PATCH v3 1/2] dt-bindings: hwmon: add support " victor.duicu
2026-02-03 19:15 ` Guenter Roeck
2026-02-06 14:17 ` Victor.Duicu
2026-02-06 16:49 ` Krzysztof Kozlowski [this message]
2026-02-06 16:51 ` Krzysztof Kozlowski
2026-02-06 16:47 ` Krzysztof Kozlowski
2026-02-09 14:46 ` Victor.Duicu
2026-01-27 15:18 ` [PATCH v3 2/2] " victor.duicu
2026-01-27 18:51 ` Guenter Roeck
2026-02-02 8:15 ` Victor.Duicu
2026-02-02 15:18 ` Guenter Roeck
2026-02-03 13:31 ` Victor.Duicu
2026-01-27 22:23 ` kernel test robot
2026-02-03 19:45 ` Guenter Roeck
2026-02-03 20:09 ` Guenter Roeck
2026-02-03 20:45 ` Guenter Roeck
2026-02-06 16:55 ` [PATCH v3 0/2] add support in hwmon " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=942d6dc7-26ad-405a-bb6a-270e2261a329@kernel.org \
--to=krzk@kernel.org \
--cc=Marius.Cristea@microchip.com \
--cc=Victor.Duicu@microchip.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox