From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 220877D2F0 for ; Thu, 12 Sep 2019 20:47:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727918AbfILUra (ORCPT ); Thu, 12 Sep 2019 16:47:30 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:45290 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727850AbfILUra (ORCPT ); Thu, 12 Sep 2019 16:47:30 -0400 Received: by mail-pf1-f194.google.com with SMTP id y72so16674689pfb.12 for ; Thu, 12 Sep 2019 13:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=a4mjeQQKYYsAEHRe62Tn5jyyKp7ZY1L4vu+tMU7d9HU=; b=d80TQgqfK4cHfg9+gVMc7hV9UgbZIljwpl6Xv9Evfnq7YEA3JaYN6JYXwqP11HpMkS UrPZMQE3yiBee7WRhJLwS9TIYhGTlhzjl1+IRp+2mRg9EYu54M27GQkvppXrC3TsM4xR X2NPuiB0sSAeN/GrYkZJEck/7TxK5X/J+byXrOhQ2Fu/T4Abdt4GC0EbUpzPDuZDh0R+ MSRxVIIrVJn/uYy1NdL2WGm+iO2RpDFKMI0SCa9nba3EbNu5jhg0S8oPL38trmL+JyG2 ma6o6aaCNjp+tUHiZilDkzy6qZ8si03a9OrXFnjplwofEJYd7nIREZLI4bqBTHgxYFDP qYkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=a4mjeQQKYYsAEHRe62Tn5jyyKp7ZY1L4vu+tMU7d9HU=; b=sI2WnvQmGCRuY8gEP0jfqxa2M9EsYWXTS7W/0iuwTclQ8HcfefCA44VG5wgyo2codG LSvgr27atH5LigDurhVEEJ5ZJVPoVOBoP1omjymTfeez8Db5Ko29fZUNr70j75UOXSPo nhs31kWuJ2EOgaeltULAgIovHO8bus+3sBIEh98v2n/W2NRT3cqykbUVfyY9Dvhr+4/b 2A74G+Erln0D8FUlzKiqfBoeDzfERmZtUSzLZXVyeAxbypcO3puPDIVPZ+Huxg4acERH EfcCuGncIQYCCiD8ZnXZhLluC+ZrwxHWimP34rVwWGA4ritTI46ozzUaqgIWzCMc12DF 1mVg== X-Gm-Message-State: APjAAAXmdDxRUDXXseSCEUMLUVU2niRVq4VGYlmWoWJGVcKx2kpQEa3O jq5KHuf4OtU5QxglldnbjdYUgLXyhAqNhw== X-Google-Smtp-Source: APXvYqyw2NWXS1KhomCFyvlNvxvHaCSLRQk2bDfzgHtr0kgczhu2/HCHbp23IYljQWA1NztJee7/rQ== X-Received: by 2002:a17:90a:d351:: with SMTP id i17mr663100pjx.13.1568321248398; Thu, 12 Sep 2019 13:47:28 -0700 (PDT) Received: from ?IPv6:2600:380:4b35:ccb0:f0cb:c243:15f:c2c0? ([2600:380:4b35:ccb0:f0cb:c243:15f:c2c0]) by smtp.gmail.com with ESMTPSA id j128sm35430292pfg.51.2019.09.12.13.47.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Sep 2019 13:47:26 -0700 (PDT) Subject: Re: [PATCH 2/3] null_blk: fix module name at log message To: Ezequiel Garcia , =?UTF-8?Q?Andr=c3=a9_Almeida?= , linux-block@vger.kernel.org, linux-doc@vger.kernel.org Cc: corbet@lwn.net, m@bjorling.me, kernel@collabora.com, krisman@collabora.com References: <20190911144636.226945-1-andrealmeid@collabora.com> <20190911144636.226945-2-andrealmeid@collabora.com> From: Jens Axboe Message-ID: <943a2fc3-4812-cc41-bdff-be13ec319257@kernel.dk> Date: Thu, 12 Sep 2019 14:47:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 9/12/19 9:47 AM, Ezequiel Garcia wrote: > Hi André, Jens, > > On Wed, 2019-09-11 at 11:46 -0300, André Almeida wrote: >> The name of the module is "null_blk", not "null". Make `pr_info()` follow >> the pattern of `pr_err()` log messages. >> > > Instead of doing these fixes manually, it's more consistent and smarter > to use pr_fmt. There are many examples of drivers doing that. > > I don't know if this patch can be dropped, and replaced with one used pr_fmt > or if doesn't worth the trouble. > > It would be even better to also patch Documentation/process/coding-style.rst, > in particular the printing section, making a mention to pr_fmt. André, please address the comments in this email and from Willy. Note that the previous patch is queued up, so you'll need to make it relative to that. -- Jens Axboe