Re: [PATCH] Documentation: RAS: Use the real EDAC PCI parity control names

[Randy Dunlap <rdunlap@infradead.org>]

On 9/5/26 2:24 AM, Karl Mehltretter wrote:
> The document names the sysfs control
> /sys/devices/system/edac/pci/check_pci_parity and the module parameter
> edac_panic_on_pci_pe. Neither exists.
> 
> check_pci_parity was renamed to check_pci_errors by commit 91b99041c1d5
> ("drivers/edac: updated PCI monitoring"), after the document had been
> written.
> 
> The module parameter has been edac_pci_panic_on_pe
> (drivers/edac/edac_pci_sysfs.c) since it was introduced, and the
> document described it as edac_panic_on_pci_pe from the start.
> 
> Use the real names.
> 
> Fixes: 91b99041c1d5 ("drivers/edac: updated PCI monitoring")
> Fixes: 327dafb1c61c ("edac: core fix redundant sysfs controls to parameters")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.

> ---
>  Documentation/admin-guide/RAS/main.rst | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/admin-guide/RAS/main.rst b/Documentation/admin-guide/RAS/main.rst
> index 5a45db32c49b..c1040e5a5b35 100644
> --- a/Documentation/admin-guide/RAS/main.rst
> +++ b/Documentation/admin-guide/RAS/main.rst
> @@ -623,7 +623,7 @@ Under ``/sys/devices/system/edac/pci`` are control and attribute files as
>  follows:
>  
>  
> -- ``check_pci_parity`` - Enable/Disable PCI Parity checking control file
> +- ``check_pci_errors`` - Enable/Disable PCI Parity checking control file
>  
>  	This control file enables or disables the PCI Bus Parity scanning
>  	operation. Writing a 1 to this file enables the scanning. Writing
> @@ -631,11 +631,11 @@ follows:
>  
>  	Enable::
>  
> -		echo "1" >/sys/devices/system/edac/pci/check_pci_parity
> +		echo "1" >/sys/devices/system/edac/pci/check_pci_errors
>  
>  	Disable::
>  
> -		echo "0" >/sys/devices/system/edac/pci/check_pci_parity
> +		echo "0" >/sys/devices/system/edac/pci/check_pci_errors
>  
>  
>  - ``pci_parity_count`` - Parity Count
> @@ -725,15 +725,15 @@ Module parameters
>  
>  	module/kernel parameter::
>  
> -			edac_panic_on_pci_pe=[0|1]
> +			edac_pci_panic_on_pe=[0|1]
>  
>  	Enable::
>  
> -		echo "1" > /sys/module/edac_core/parameters/edac_panic_on_pci_pe
> +		echo "1" > /sys/module/edac_core/parameters/edac_pci_panic_on_pe
>  
>  	Disable::
>  
> -		echo "0" > /sys/module/edac_core/parameters/edac_panic_on_pci_pe
> +		echo "0" > /sys/module/edac_core/parameters/edac_pci_panic_on_pe
>  
>  
>  

-- 
~Randy