From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.zytor.com (terminus.zytor.com [198.137.202.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B5C11E7C23; Sat, 7 Mar 2026 03:21:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.136 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772853715; cv=none; b=MT4Qd7Lf2BmBdwx52pPimkZhGkUOpZMB5svvCPHp7L3E7LAAQ74DtKK7gZNxlDIi2l/LNnhuWKZ9x0JX4g+HaPUiwg9kNfMSV7IgJmgN5MIOFnX1Wg31ftPw3Sy3QLQ/4xGPaCMe+M7s3OrWce/fmUIv/mzJ69IDZX+yj4kZO8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772853715; c=relaxed/simple; bh=UuKtYQLEpbZzXF4D203RAUfvz14kMMGl6TPKP4QK4eA=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=lFfTZbbFkSjNKX0m1aOA0m5VDK/GP61/ZYzKsmP1n0oZ5mH4K5vzSRNDmq2tBWpDcRuznBoIVKXFNl7Kv/Q+G9qCmG1TNq/QBlv+CwC0CY3DiCZGCJYjJUVnMwj/24aixBT4gfDlVrdKtKANqZvYwbjWrxabBpjM9U6UJKXIaQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zytor.com; spf=pass smtp.mailfrom=zytor.com; dkim=pass (2048-bit key) header.d=zytor.com header.i=@zytor.com header.b=WwmfJOVX; arc=none smtp.client-ip=198.137.202.136 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zytor.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zytor.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=zytor.com header.i=@zytor.com header.b="WwmfJOVX" Received: from smtpclient.apple (c-24-130-165-117.hsd1.ca.comcast.net [24.130.165.117]) (authenticated bits=0) by mail.zytor.com (8.18.1/8.17.1) with ESMTPSA id 62735SVf2594941 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 6 Mar 2026 19:05:28 -0800 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.zytor.com 62735SVf2594941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2026022301; t=1772852729; bh=Lg/cqXkxdh6j/9Vx7MayeK1i/ddSevoVsnuXd/tRki0=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=WwmfJOVXBs7PcVo13W3mUkrnrMY3knNv49gmfvuKuu3h+4GTZrIqjTjySTUWjhqBk 3Ux2WInQ2riniuOpqEOnI5L/79IqMJd9rqhjSryUDIrn6HuWRLQhqm4+z/dgdpxZiV 5FxvzK8Mezwc2y7vg2I19qDEBgluB0RDMj9NPdQqh9oYSPSZnsUXrC6S2FnGCR27Q3 71bIdKHir94r9zRq1qPEPFJgp4epnt1OpS/qT/Ah33wRQSRarsA7uXwqJ9fonIiDI1 VJp8gQxYHpW5wqX5vmrzeD8+Q2MDCCC18ylRgTPXhj+NC6vYUVC9LIodm89X+FFjuJ 86OWLdG6OQRmg== Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\)) Subject: Re: [PATCH v9 13/22] KVM: VMX: Virtualize FRED nested exception tracking From: Xin Li In-Reply-To: Date: Fri, 6 Mar 2026 19:05:18 -0800 Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, pbonzini@redhat.com, corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, luto@kernel.org, peterz@infradead.org, andrew.cooper3@citrix.com, chao.gao@intel.com, hch@infradead.org, sohil.mehta@intel.com Content-Transfer-Encoding: quoted-printable Message-Id: References: <20251026201911.505204-1-xin@zytor.com> <20251026201911.505204-14-xin@zytor.com> To: Sean Christopherson X-Mailer: Apple Mail (2.3864.400.21) > On Mar 6, 2026, at 6:07=E2=80=AFPM, Sean Christopherson = wrote: >=20 >> @@ -2231,7 +2232,8 @@ void kvm_queue_exception(struct kvm_vcpu *vcpu, = unsigned nr); >> void kvm_queue_exception_e(struct kvm_vcpu *vcpu, unsigned nr, u32 = error_code); >> void kvm_queue_exception_p(struct kvm_vcpu *vcpu, unsigned nr, = unsigned long payload); >> void kvm_requeue_exception(struct kvm_vcpu *vcpu, unsigned int nr, >> - bool has_error_code, u32 error_code, u64 event_data); >> + bool has_error_code, u32 error_code, bool nested, >=20 > I think we should pick a different name, as both VMX and SVM declare = "nested" as > a global boolean. I.e. this creates some nasty variable shadowing. >=20 > Maybe is_nested? is_nested looks good to me. I thought about is_nested_exp, however the function names already = contain =E2=80=9Cexception=E2=80=9D, no point to duplicate it.=