From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32C8B2C11EB for ; Sun, 26 Oct 2025 19:10:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761505807; cv=none; b=em7MZg9RuJwyTeCrsNmzxrHAtv67nsLJZlewuXlLvl65BBI/XZaBtWRZny8/8UIFbaImjivefJYIZPU3ccaXQ0Qg8tXBKkwx0Xq7dU793odGtV2JxLhiXPjqV5CijyLQ5dk5FkD35Yvku7+JrA0FGMHErk/qrQLI/xJ3184A8Ro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761505807; c=relaxed/simple; bh=0lq7zVwPZaQ1Z0QmxvXwvIFsXJKsKrMtftkVUtORhEE=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=L3+L5GkfQxMl1coqbF7RBmh3yBcqohFrHj3EecP3Xzj87/o92JEJoBdArrdZlM3IzyLaRSQvojL60nzCe2tsCwJWT7b6eUvrl5YeXa8+mwVELcsLfSZEfbWklT9tz96rgeoi4/PqIjQPIRbV2KbnMixOInNFbr506KJ66AEGnfQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ULU3LZ5Q; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ULU3LZ5Q" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-3304dd2f119so3041387a91.2 for ; Sun, 26 Oct 2025 12:10:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761505805; x=1762110605; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=fnFYZ9YUqokdNrVhAzveB7Lx/h8vJ0ZLZBrXLG7FIwU=; b=ULU3LZ5QDucJoRHtdN4r5T2qvlQG/ptN219iohNQDg9o3S+ZEmuCqEOwU7absOBLYh q3IE8Zle/mINy94lD2fCyJvHl7Sqa8q7k9mxFQibFX6Bqv751DVk2lczqAZ7N0qhF8Xw K5q22x+K/FLPFD/5oQFHNVYgI264hMqb5BVxncTbrJXjvLJPt7Q98gPnc4GVxuabEFsl g2xjlYH+tSEC4Pc2toEXQRfwZ9cDe+iKVQLzrqtJX7XJGaJ78JHinAZhz09O/Q5VPI7v 5FLXRauY85GvtYjwGijcr8p8G/cTQEGs0mg/qmvFbbn6WE01SDCuF0NeFKrJTS3NlmBR vpTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761505805; x=1762110605; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fnFYZ9YUqokdNrVhAzveB7Lx/h8vJ0ZLZBrXLG7FIwU=; b=Y1TCsIZP9ICmsjA62Bd4XuNI9kDT/236fK3QsKVPHCipo+3hSG/nO8gLfJ1cHLN89F PdyYwHnOt77KwGG5w09Wd52PNQQH3+xhvGJFeL/rtIC1sCihlXbrOkBnm7EDGHOgJE6W JMdJAn2bZUWbfNaueL6mP4HyDonLBtEQKfPVgEWOJf7GlhLTXNkLjzaXQie0hKtTq/V2 53iiJMjFJ4ADMk7P2MTbwB1OeM99yra/4eExgpfBbfdF799F/2b/EXdVq4tjVdxhwAPv 6d81fcEBLJ5GNI1P6VND2reXVRa/5DI/fVQqKzxUNshGevl88gCpfAweJxW9Uo5B4ZKV jj1w== X-Forwarded-Encrypted: i=1; AJvYcCXhR5kRobNIgtN3fOE0YT8PUaswnnPDsePsoMFqfA9KIjfHS4ayNDNe6/vqDquQX9YiOrQWvmcknzc=@vger.kernel.org X-Gm-Message-State: AOJu0YxxZHr8mwJyGxa1B5FQD2c/01PmRjZuf1D3vnfoxe6c22ph8NEe cyAfKCXoyovq/XQS5NDBHTG41b3GU41VG83jtsR7lc5dfVg3OG0tyOJ5 X-Gm-Gg: ASbGncu1ov9+Ne/40WAwWdiW9+7Shke0nWMoh9lrQ19SMQQ/iwso9+dyBftGHwx3QhY HFYUSsUlti8A5AfV+GY2PGJpFwXjkCty1CIY41fyqaHpJPEfBRfjQWwPPhoZsnh17tuzMWDLeNi KGqrY3D77Nizm5mMxJpCoh2twaZliC1swzCw32BBWSBQt+rB+m+4RMZT4VqLYzTYdNnSVm9tNTi Hr8rUpF+lyWfxaJmYCd+ldH88PAr9tA6CphjaA6GDULvdggDeDXJ1vCrcTSRbpDlHkhKxHXw/FZ vXOETSOxpeiPq1Tu4sBV+EoKEG2TrwS4ruAV139WAQ85qqju3GqoYsEGGjWqOtE05V5ZEeb/pRT wFmBbKlVzHyhwG50+ImZyILQs9a8XAKKuhBZZvOVcvjWS55Wf6A/T0W7KYSR9V6I7JmFV4D5BMT jNxRgyvlHVyMIGJLVS3p34/boRRf9kZXoIE4YbMhZZlPWwnuLDb+W1j6s8DdGOngjv/El9prPyR oQtmj8sKeszNlXjf1pd X-Google-Smtp-Source: AGHT+IHIMcsGGm24Rt7x4qUBaUlLuW2TkTj9Vx3KclPFhSEmsfRY9ycNQeSpu5npNrhMtA0Tz3+PdA== X-Received: by 2002:a17:90a:ec8b:b0:32e:d011:ea0f with SMTP id 98e67ed59e1d1-33bcf8f7280mr40460828a91.25.1761505805426; Sun, 26 Oct 2025 12:10:05 -0700 (PDT) Received: from ehlo.thunderbird.net (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-33fed7f3aeesm5818053a91.14.2025.10.26.12.10.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Oct 2025 12:10:05 -0700 (PDT) Date: Sun, 26 Oct 2025 12:10:03 -0700 From: "Derek J. Clark" To: Mario Limonciello , Hans de Goede , =?ISO-8859-1?Q?Ilpo_J=E4rvinen?= , Armin Wolf , Len Brown , "Rafael J . Wysocki" , Jonathan Corbet CC: Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , Kurt Borja , platform-driver-x86@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_2/3=5D_platform/x86=3A_lenovo-wmi-ga?= =?US-ASCII?Q?mezone_Use_Extreme_vice_balanced-performance?= User-Agent: Thunderbird for Android In-Reply-To: References: <20251026081240.997038-1-derekjohn.clark@gmail.com> <20251026081240.997038-3-derekjohn.clark@gmail.com> Message-ID: Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On October 26, 2025 10:52:29 AM PDT, Mario Limonciello wrote: >Is 'vice' the right word for the subject? > Used as in rather than or as an alternative to, it has more brevity=2E >On 10/26/25 3:12 AM, Derek J=2E Clark wrote: >> When upstreaming the gamezone WMI drivers the "extreme" mode was matche= d >> to performance and performance was matched to balanced-performance, but >> only when extreme mode was fully enabled=2E Otherwise performance was >> matched to performance=2E This has led to quite a bit of confusion with >> users not understanding why the LED color indicating the platform >> profile doesn't match their expectations=2E To solve this, replace the >> confusing convention with the new "extreme" profile=2E > >Are the colors common to all devices? Maybe it would be worth adding to = the documentation the expected colors for each mode=2E > I think so, based on every case I've run into=2E I'll need to expound a li= ttle and reword more in this section but that should be doable=2E Thanks, Derek >>=20 >> Signed-off-by: Derek J=2E Clark >> --- >> =2E=2E=2E/wmi/devices/lenovo-wmi-gamezone=2Erst | 10 +++------= - >> drivers/platform/x86/lenovo/wmi-gamezone=2Ec | 18 +++++----------= --- >> 2 files changed, 8 insertions(+), 20 deletions(-) >>=20 >> diff --git a/Documentation/wmi/devices/lenovo-wmi-gamezone=2Erst b/Docu= mentation/wmi/devices/lenovo-wmi-gamezone=2Erst >> index 997263e51a7d=2E=2E6c908f44a08e 100644 >> --- a/Documentation/wmi/devices/lenovo-wmi-gamezone=2Erst >> +++ b/Documentation/wmi/devices/lenovo-wmi-gamezone=2Erst >> @@ -24,18 +24,14 @@ current platform profile when it changes=2E >> The following platform profiles are supported: >> - low-power >> - balanced >> - - balanced-performance >> - performance >> + - extreme >> - custom >> -Balanced-Performance >> +Extreme >> ~~~~~~~~~~~~~~~~~~~~ >> Some newer Lenovo "Gaming Series" laptops have an "Extreme Mode" prof= ile >> -enabled in their BIOS=2E For these devices, the performance platform p= rofile >> -corresponds to the BIOS Extreme Mode, while the balanced-performance >> -platform profile corresponds to the BIOS Performance mode=2E For legac= y >> -devices, the performance platform profile will correspond with the BIO= S >> -Performance mode=2E >> +enabled in their BIOS=2E >> For some newer devices the "Extreme Mode" profile is incomplete in = the BIOS >> and setting it will cause undefined behavior=2E A BIOS bug quirk tabl= e is >> diff --git a/drivers/platform/x86/lenovo/wmi-gamezone=2Ec b/drivers/pla= tform/x86/lenovo/wmi-gamezone=2Ec >> index 0eb7fe8222f4=2E=2Efaabbd4657bd 100644 >> --- a/drivers/platform/x86/lenovo/wmi-gamezone=2Ec >> +++ b/drivers/platform/x86/lenovo/wmi-gamezone=2Ec >> @@ -171,14 +171,10 @@ static int lwmi_gz_profile_get(struct device *dev= , >> *profile =3D PLATFORM_PROFILE_BALANCED; >> break; >> case LWMI_GZ_THERMAL_MODE_PERFORMANCE: >> - if (priv->extreme_supported) { >> - *profile =3D PLATFORM_PROFILE_BALANCED_PERFORMANCE; >> - break; >> - } >> *profile =3D PLATFORM_PROFILE_PERFORMANCE; >> break; >> case LWMI_GZ_THERMAL_MODE_EXTREME: >> - *profile =3D PLATFORM_PROFILE_PERFORMANCE; >> + *profile =3D PLATFORM_PROFILE_EXTREME; >> break; >> case LWMI_GZ_THERMAL_MODE_CUSTOM: >> *profile =3D PLATFORM_PROFILE_CUSTOM; >> @@ -218,16 +214,12 @@ static int lwmi_gz_profile_set(struct device *dev= , >> case PLATFORM_PROFILE_BALANCED: >> mode =3D LWMI_GZ_THERMAL_MODE_BALANCED; >> break; >> - case PLATFORM_PROFILE_BALANCED_PERFORMANCE: >> - mode =3D LWMI_GZ_THERMAL_MODE_PERFORMANCE; >> - break; >> case PLATFORM_PROFILE_PERFORMANCE: >> - if (priv->extreme_supported) { >> - mode =3D LWMI_GZ_THERMAL_MODE_EXTREME; >> - break; >> - } >> mode =3D LWMI_GZ_THERMAL_MODE_PERFORMANCE; >> break; >> + case PLATFORM_PROFILE_EXTREME: >> + mode =3D LWMI_GZ_THERMAL_MODE_EXTREME; >> + break; >> case PLATFORM_PROFILE_CUSTOM: >> mode =3D LWMI_GZ_THERMAL_MODE_CUSTOM; >> break; >> @@ -338,7 +330,7 @@ static int lwmi_gz_platform_profile_probe(void *drv= data, unsigned long *choices) >> priv->extreme_supported =3D lwmi_gz_extreme_supported(profile_supp= ort_ver); >> if (priv->extreme_supported) >> - set_bit(PLATFORM_PROFILE_BALANCED_PERFORMANCE, choices); >> + set_bit(PLATFORM_PROFILE_EXTREME, choices); >> return 0; >> } >