From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 549E0C4361B for ; Fri, 11 Dec 2020 02:33:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07F5723E55 for ; Fri, 11 Dec 2020 02:33:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391300AbgLKCce (ORCPT ); Thu, 10 Dec 2020 21:32:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391165AbgLKCcY (ORCPT ); Thu, 10 Dec 2020 21:32:24 -0500 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0E1DC0613CF; Thu, 10 Dec 2020 18:31:43 -0800 (PST) Received: by mail-qk1-x743.google.com with SMTP id z11so7162807qkj.7; Thu, 10 Dec 2020 18:31:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=EeBE0q+ErDzzvoGT97HzZPFWnthYhh5V7M5ilZcCsbk=; b=Du/BFUZWIiV9QL9SLfwiNk/AcgiLYD23ezmHJCJ2GK/qX553KoC+/Uf6EzhR1Yqw0G wvR0KUDHEqgi1rekJ53m3hKY7xXF+lw9BVwPMc+4XMhWAwQ8vkrpEv5HVbXaMD2Qesd2 G6CHOSmyP19f2EuKLase/8kzypAqf8cS6i9akAMQXHkVXk8HkfEkk6vd+31133nYPgG9 B7PHwPENAnkxJBUfH2v/xnOsZ1Ya+EfZTgPGtlEydZSe+xamKxhX8aZ4PSrvIhT6No/t 74lkI/yVPEd+SocUw3GUgomgNBL69lZyvmIPV+/RwGfYE2Bl4yTg4Bz8xNVEmgyJwwQB brew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=EeBE0q+ErDzzvoGT97HzZPFWnthYhh5V7M5ilZcCsbk=; b=RPwyW8PR991ggeakceYmaiesfsI1XzOOcTcqiVSPAYcTQsVtsGEdYcQfIjmXRJIy8v GQSi8LrIT/Cj02QirUd6QQkldsAdpP3Bg6ezcWm/I/v4m85ESLUVYkJVslZjgGDMKzRN Hx8CL3+/PAyCBIMg2zPOjSjDb0qbSTqko5Au4NqDqBsey51qKS+uECQaOrqk9W5nKxd/ 3vc899491PJVKkijJyWOBt9qmIXfuXbczC8T5ZKOrALp0aPBGsz7H+R+dmiNd6C3OIML dLVe3R5v0OdNLE3Wo1/KRYRkILTpSrNOXo4Uv+px3swNjZWB9B7iqRmrAtRh81qx8TWf si+Q== X-Gm-Message-State: AOAM5323jnt87HzQpDj8miycYD/qs+dU46YDpHU680tI4pzDN2K+jpoj ya4Yl4aZunhgEDm3fbkLMTvcPvx22etdV+BVvVVNW5bUKCtwng== X-Google-Smtp-Source: ABdhPJxM9PzPaAMuDWF/f7hOuuVq3yPBdtl+Y6lFsJ2A+LYREf34G/MGnb3UMg/S0vlPucFwIc5OTk+Reg4tW708LYw= X-Received: by 2002:a37:a7d1:: with SMTP id q200mr12770176qke.283.1607653903024; Thu, 10 Dec 2020 18:31:43 -0800 (PST) MIME-Version: 1.0 References: <20201210160357.27779-1-georgi.djakov@linaro.org> In-Reply-To: <20201210160357.27779-1-georgi.djakov@linaro.org> From: Joonsoo Kim Date: Fri, 11 Dec 2020 11:31:32 +0900 Message-ID: Subject: Re: [PATCH v3] mm/page_owner: Record timestamp and pid To: Georgi Djakov Cc: Andrew Morton , Linux Memory Management List , Vlastimil Babka , corbet@lwn.net, linux-doc@vger.kernel.org, LKML , lmark@codeaurora.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org 2020=EB=85=84 12=EC=9B=94 11=EC=9D=BC (=EA=B8=88) =EC=98=A4=EC=A0=84 1:04, = Georgi Djakov =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84= =B1: > > From: Liam Mark > > Collect the time for each allocation recorded in page owner so that > allocation "surges" can be measured. > > Record the pid for each allocation recorded in page owner so that the > source of allocation "surges" can be better identified. > > The above is very useful when doing memory analysis. On a crash for > example, we can get this information from kdump (or ramdump) and parse it > to figure out memory allocation problems. > > Please note that on x86_64 this increases the size of struct page_owner > from 16 bytes to 32. > > Vlastimil: it's not a functionality intended for production, so unless > somebody says they need to enable page_owner for debugging and this > increase prevents them from fitting into available memory, let's not > complicate things with making this optional. > > Signed-off-by: Liam Mark > Signed-off-by: Georgi Djakov > Acked-by: Vlastimil Babka > Cc: Jonathan Corbet Acked-by: Joonsoo Kim This is useful. Our company already has an in-house patch to store pid since a few years ago. Thanks.