* [PATCH] Documentation: kunit: Correct MODULE_IMPORT_NS() syntax
@ 2025-06-16 21:16 Brian Norris
2025-06-17 7:03 ` David Gow
0 siblings, 1 reply; 2+ messages in thread
From: Brian Norris @ 2025-06-16 21:16 UTC (permalink / raw)
To: Brendan Higgins, David Gow
Cc: linux-doc, kunit-dev, linux-kernel, Rae Moar, linux-kselftest,
Brian Norris
The argument should be the string "EXPORTED_FOR_KUNIT_TESTING", not a
bare identifier.
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
Documentation/dev-tools/kunit/usage.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/dev-tools/kunit/usage.rst b/Documentation/dev-tools/kunit/usage.rst
index 038f480074fd..066ecda1dd98 100644
--- a/Documentation/dev-tools/kunit/usage.rst
+++ b/Documentation/dev-tools/kunit/usage.rst
@@ -699,7 +699,7 @@ the template below.
#include <kunit/visibility.h>
#include <my_file.h>
...
- MODULE_IMPORT_NS(EXPORTED_FOR_KUNIT_TESTING);
+ MODULE_IMPORT_NS("EXPORTED_FOR_KUNIT_TESTING");
...
// Use do_interesting_thing() in tests
--
2.50.0.rc2.692.g299adb8693-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Documentation: kunit: Correct MODULE_IMPORT_NS() syntax
2025-06-16 21:16 [PATCH] Documentation: kunit: Correct MODULE_IMPORT_NS() syntax Brian Norris
@ 2025-06-17 7:03 ` David Gow
0 siblings, 0 replies; 2+ messages in thread
From: David Gow @ 2025-06-17 7:03 UTC (permalink / raw)
To: Brian Norris
Cc: Brendan Higgins, linux-doc, kunit-dev, linux-kernel, Rae Moar,
linux-kselftest
[-- Attachment #1: Type: text/plain, Size: 320 bytes --]
On Tue, 17 Jun 2025 at 05:16, Brian Norris <briannorris@chromium.org> wrote:
>
> The argument should be the string "EXPORTED_FOR_KUNIT_TESTING", not a
> bare identifier.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
Nice catch, thanks!
Reviewed-by: David Gow <davidgow@google.com>
Cheers,
-- David
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5281 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-17 7:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-16 21:16 [PATCH] Documentation: kunit: Correct MODULE_IMPORT_NS() syntax Brian Norris
2025-06-17 7:03 ` David Gow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).