From: Takeru Hayasaka <hayatake396@gmail.com>
To: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@intel.com>
Cc: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"vladimir.oltean@nxp.com" <vladimir.oltean@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"laforge@gnumonks.org" <laforge@gnumonks.org>,
Marcin Szycik <marcin.szycik@linux.intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"mailhol.vincent@wanadoo.fr" <mailhol.vincent@wanadoo.fr>
Subject: Re: [Intel-wired-lan] [PATCH net-next v8 1/2] ethtool: Add GTP RSS hash options to ethtool.h
Date: Tue, 5 Mar 2024 16:47:35 +0900 [thread overview]
Message-ID: <CADFiAcJtJWMqeiVRLyZQivYw2J5EBeMVjP+qeJfS9YeWokdX+Q@mail.gmail.com> (raw)
In-Reply-To: <CYYPR11MB84290126F884C2AB4F9AA5FBBD222@CYYPR11MB8429.namprd11.prod.outlook.com>
Hi Himasekhar Reddy-san
> After added the above v4 patch able to to see tab completion for flow-type but not rx-flow-hash. Please find below logs.
Sorry. I submitted a code with the conditions reversed. I have
resubmitted it, so could you please check it again?
https://lore.kernel.org/all/20240305074350.533622-1-hayatake396@gmail.com/
Takeru
2024年3月5日(火) 13:28 Pucha, HimasekharX Reddy <himasekharx.reddy.pucha@intel.com>:
>
> >-----Original Message-----
> > From: Takeru Hayasaka <hayatake396@gmail.com>
> > Sent: Tuesday, March 5, 2024 9:12 AM
> > To: Pucha, HimasekharX Reddy <himasekharx.reddy.pucha@intel.com>
> > Cc: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Jonathan Corbet <corbet@lwn.net>; linux-doc@vger.kernel.org; vladimir.oltean@nxp.com; linux-kernel@vger.kernel.org; laforge@gnumonks.org; Marcin Szycik <marcin.szycik@linux.intel.com>; intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; mailhol.vincent@wanadoo.fr
> > Subject: Re: [Intel-wired-lan] [PATCH net-next v8 1/2] ethtool: Add GTP RSS hash options to ethtool.h
> >
> > Hi Himasekhar Reddy-san
> >
> > > Functionality wise its working fine. But the ethtool part (tab complete doesn't show GTP)
> >
> > I forgot to add the tab completion feature! Thank you for the good
> > points. I've added it again in this version's patch.
> > https://lore.kernel.org/all/20240305033555.524741-1-hayatake396@gmail.com/
> >
> > Takeru
> >
>
> After added the above v4 patch able to to see tab completion for flow-type but not rx-flow-hash. Please find below logs.
>
> # ethtool -N eth4 rx-flow-hash
> ah4 ah6 esp4 esp6 ether sctp4 sctp6 tcp4 tcp6 udp4 udp6
> # ethtool -N eth4 rx-flow-hash
> ah4 ah6 esp4 esp6 ether sctp4 sctp6 tcp4 tcp6 udp4 udp6
> # ethtool -N eth4 flow-type
> ah4 esp4 ether gtpc4t gtpc6t gtpu4d gtpu4u gtpu6d gtpu6u ip6 sctp6 tcp6 udp6
> ah6 esp6 gtpc4 gtpc6 gtpu4 gtpu4e gtpu6 gtpu6e ip4 sctp4 tcp4 udp4
>
next prev parent reply other threads:[~2024-03-05 7:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 2:04 [PATCH net-next v8 1/2] ethtool: Add GTP RSS hash options to ethtool.h Takeru Hayasaka
2024-02-12 2:04 ` [PATCH net-next v8 2/2] ice: Implement RSS settings for GTP using ethtool Takeru Hayasaka
2024-03-01 7:40 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-02-15 8:44 ` [PATCH net-next v8 1/2] ethtool: Add GTP RSS hash options to ethtool.h Takeru Hayasaka
2024-02-15 10:26 ` Paolo Abeni
2024-02-15 15:56 ` anthony.l.nguyen
2024-02-16 14:14 ` Takeru Hayasaka
2024-02-16 21:14 ` Tony Nguyen
2024-02-17 6:18 ` Takeru Hayasaka
2024-03-01 18:01 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-03-05 3:42 ` Takeru Hayasaka
2024-03-05 4:28 ` Pucha, HimasekharX Reddy
2024-03-05 7:47 ` Takeru Hayasaka [this message]
2024-03-05 9:31 ` Pucha, HimasekharX Reddy
2024-03-05 14:49 ` Pucha, HimasekharX Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADFiAcJtJWMqeiVRLyZQivYw2J5EBeMVjP+qeJfS9YeWokdX+Q@mail.gmail.com \
--to=hayatake396@gmail.com \
--cc=anthony.l.nguyen@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=himasekharx.reddy.pucha@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=laforge@gnumonks.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=marcin.szycik@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).