From: Mike Leach <mike.leach@linaro.org>
To: James Clark <james.clark@linaro.org>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jonathan Corbet <corbet@lwn.net>, Leo Yan <leo.yan@arm.com>,
coresight@lists.linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 3/6] coresight: Repack struct etmv4_drvdata
Date: Thu, 14 Aug 2025 13:38:14 +0100 [thread overview]
Message-ID: <CAJ9a7VhXAhDHkpyA6gHWPfr+HAEFLEPa01vx0n=b+82TrEMUTQ@mail.gmail.com> (raw)
In-Reply-To: <20250811-james-cs-syncfreq-v1-3-b001cd6e3404@linaro.org>
On Mon, 11 Aug 2025 at 10:32, James Clark <james.clark@linaro.org> wrote:
>
> Fix holes and convert the long list of bools to single bits to save
> some space because there's one of these for each ETM.
>
> Signed-off-by: James Clark <james.clark@linaro.org>
> ---
> drivers/hwtracing/coresight/coresight-etm4x.h | 39 ++++++++++++++-------------
> 1 file changed, 20 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.h b/drivers/hwtracing/coresight/coresight-etm4x.h
> index a355a1e9606d..1c67b263b01b 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x.h
> +++ b/drivers/hwtracing/coresight/coresight-etm4x.h
> @@ -1020,29 +1020,30 @@ struct etmv4_drvdata {
> u8 ns_ex_level;
> u8 q_support;
> u8 os_lock_model;
> - bool sticky_enable;
> - bool boot_enable;
> - bool os_unlock;
> - bool instrp0;
> - bool q_filt;
> - bool trcbb;
> - bool trccond;
> - bool retstack;
> - bool trccci;
> - bool trc_error;
> - bool syncpr;
> - bool stallctl;
> - bool sysstall;
> - bool nooverflow;
> - bool atbtrig;
> - bool lpoverride;
> + bool sticky_enable : 1;
> + bool boot_enable : 1;
> + bool os_unlock : 1;
> + bool instrp0 : 1;
> + bool q_filt : 1;
> + bool trcbb : 1;
> + bool trccond : 1;
> + bool retstack : 1;
> + bool trccci : 1;
> + bool trc_error : 1;
> + bool syncpr : 1;
> + bool stallctl : 1;
> + bool sysstall : 1;
> + bool nooverflow : 1;
> + bool atbtrig : 1;
> + bool lpoverride : 1;
> + bool state_needs_restore : 1;
> + bool skip_power_up : 1;
> + bool paused : 1;
> u64 trfcr;
> struct etmv4_config config;
> u64 save_trfcr;
> struct etmv4_save_state *save_state;
> - bool state_needs_restore;
> - bool skip_power_up;
> - bool paused;
> +
> DECLARE_BITMAP(arch_features, ETM4_IMPDEF_FEATURE_MAX);
> };
>
>
> --
> 2.34.1
>
Reviewed-by: Mike Leach <mike.leach@linaro.org>
--
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK
next prev parent reply other threads:[~2025-08-14 12:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 9:32 [PATCH 0/6] coresight: Add format attribute for setting the timestamp interval James Clark
2025-08-11 9:32 ` [PATCH 1/6] coresight: Change syncfreq to be a u8 James Clark
2025-08-11 9:32 ` [PATCH 2/6] coresight: Fix holes in struct etmv4_config James Clark
2025-08-14 12:37 ` Mike Leach
2025-08-11 9:32 ` [PATCH 3/6] coresight: Repack struct etmv4_drvdata James Clark
2025-08-14 12:38 ` Mike Leach [this message]
2025-08-11 9:32 ` [PATCH 4/6] coresight: Refactor etm4_config_timestamp_event() James Clark
2025-08-11 9:32 ` [PATCH 5/6] coresight: Add format attribute for setting the timestamp interval James Clark
2025-08-12 2:27 ` kernel test robot
2025-08-11 9:32 ` [PATCH 6/6] coresight: docs: Document etm4x ts_interval James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ9a7VhXAhDHkpyA6gHWPfr+HAEFLEPa01vx0n=b+82TrEMUTQ@mail.gmail.com' \
--to=mike.leach@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=corbet@lwn.net \
--cc=coresight@lists.linaro.org \
--cc=james.clark@linaro.org \
--cc=leo.yan@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).