From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="HLsQjd6i" Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12D35D5B for ; Wed, 6 Dec 2023 13:14:13 -0800 (PST) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-a1a496a73ceso23481566b.2 for ; Wed, 06 Dec 2023 13:14:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701897251; x=1702502051; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PmJEDBzKxyQU9MCwcJin0j3ArzElELYr7Bhn9rZHDMc=; b=HLsQjd6is8o1mLTgKgynRGGnavRhRCjDYmyDeS5fOmPhbbkV9ieLR5oyJDZ4JH1Bhy /tdnLN41SfG+6hv1kSIQtl2/t8Lt0/lGUjlFdZCO0K8CH5gAMqEkYpDn4doFV7eGr3/w 5Iq9imXpSmWj5cVoPhnxliChrNdI3fySwk5P/ql2pEWIfhDapvUiIG/N9Ru0uCocL2rh 31v7cCkSPZkmolPrPZcJBnxCPe5IhGJsWg8UhTwTW3L1VeKPUV9y0/U8e14fufjLFYc2 WuoCQ+yldbFB+Y+CLSR4rnLG55r+4sOrbcDDimqxZk+WW34JOZ9lcWmPw5/W6AtZrz54 v8Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701897251; x=1702502051; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PmJEDBzKxyQU9MCwcJin0j3ArzElELYr7Bhn9rZHDMc=; b=TZJo+4dink8VObbQabG7Ve99Sq9jJOn4wZ50A8IC9wqKdvqa3caCj5CoDM1N57VaiG QpxhBArdqukUSsbxAtOYSSmQo81zjCykpHQdwn1XvXi6mAXfi13sU9n2q08i78Cipj0T EW7dAetsH74FB/BsV6GRADsqCy1VOSk/zaj6F0TypURnSWJvzvHxMuF6UFiYHoYu/PZs 72EKTF7sr+/epeAYF3aNeET7i/csk/huNZmUhrGgvf6mHjFigzgDZDZx4M7qn4gabFFC JAM/5XVaFI3V8iPk46aZfeThlbH7iWvqx2dwym/CFh7NZuxIo5n+zpRQFqFAy86xDFEJ s5Bg== X-Gm-Message-State: AOJu0YypYGFu7Bi6csdgEHh+7QiAjE5vWaVSN7Ku5LQK29Q1mWkWLH3D Bjm/tZ/IZ+5wxecKQ6Q9eBKGD9+e51PZdqV0edfEVg== X-Google-Smtp-Source: AGHT+IGdUJ0U7LGEKJjGqt5itynfcSrlXa/hzW69+tBQz3ZKJeFsQ9wcSARFzKG7Hzt4JesxN71jS11/3dhzFfPH9sA= X-Received: by 2002:a17:906:3518:b0:a19:a19b:78b1 with SMTP id r24-20020a170906351800b00a19a19b78b1mr730768eja.116.1701897251403; Wed, 06 Dec 2023 13:14:11 -0800 (PST) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231130194023.4102148-1-nphamcs@gmail.com> <20231130194023.4102148-7-nphamcs@gmail.com> In-Reply-To: From: Yosry Ahmed Date: Wed, 6 Dec 2023 13:13:35 -0800 Message-ID: Subject: Re: [PATCH v8 6/6] zswap: shrinks zswap pool based on memory pressure To: Nhat Pham Cc: Chengming Zhou , akpm@linux-foundation.org, hannes@cmpxchg.org, cerasuolodomenico@gmail.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, chrisl@kernel.org, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Dec 6, 2023 at 11:47=E2=80=AFAM Nhat Pham wrote= : > > [...] > > > > Hmm so how should we proceed from here? How about this: > > > > a) I can send a fixlet to move the enablement check above the stats > > flushing + use mem_cgroup_flush_stats > > b) Then maybe, you can send a fixlet to update this new callsite? > > > > Does that sound reasonable? > > I just sent out the fixlet. Yosry and Chengming, let me know if that > looks good. Thank you both for detecting this issue and proposing the > fix! The fixlet looks good, and Andrew already took care of (b) before I could send a followup fixlet out :)