From: Mingwei Zhang <mizhang@google.com>
To: Zhi Wang <zhi.wang.linux@gmail.com>
Cc: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Jim Mattson <jmattson@google.com>,
David Matlack <dmatlack@google.com>,
Ben Gardon <bgardon@google.com>
Subject: Re: [PATCH 0/6] KVM: Documentation: Update document description for kvm_mmu_page and kvm_mmu_page_role
Date: Wed, 21 Jun 2023 11:33:25 -0700 [thread overview]
Message-ID: <CAL715WKF8Ws1E0UNvRNQ7ZqisrFD6srC3o24g8FU=f=f0YwUKw@mail.gmail.com> (raw)
In-Reply-To: <20230619120051.00001f0f.zhi.wang.linux@gmail.com>
On Mon, Jun 19, 2023 at 2:00 AM Zhi Wang <zhi.wang.linux@gmail.com> wrote:
>
> On Sun, 18 Jun 2023 00:08:50 +0000
> Mingwei Zhang <mizhang@google.com> wrote:
>
> > When reading the KVM MMU documentation for nested virtualization, I feel
> > that the description of kvm_mmu_page (and kvm_mmu_page_role) has been
> > lagging for around 1-2 years. The descriptions for several fields in struct
> > kvm_mmu_page and struct kvm_mmu_page_role are missing. So I think it might
> > be good to add them to make it consistent with the current code.
> >
>
> This is so nice. A trivial comment, maybe refining the tittle of PATCH 1-6 a
> bit: "Add the missing comment of xxxx into xxxx". It is a little bit confusing
> by just looking at the titles at the first glance, more like some members are
> missing, not the comments. :)
>
Sure. Yeah, the shortlog looks slightly confusing as if I am changing
the actual data structures. I will update those in the next version.
Thanks for your comments.
-Mingwei
prev parent reply other threads:[~2023-06-21 18:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-18 0:08 [PATCH 0/6] KVM: Documentation: Update document description for kvm_mmu_page and kvm_mmu_page_role Mingwei Zhang
2023-06-18 0:08 ` [PATCH 1/6] KVM: Documentation: Add the missing guest_mode in kvm_mmu_page_role Mingwei Zhang
2023-06-22 8:22 ` Huang, Kai
2023-06-18 0:08 ` [PATCH 2/6] KVM: Documentation: Update the field name gfns in kvm_mmu_page Mingwei Zhang
2023-06-22 8:22 ` Huang, Kai
2023-06-23 0:30 ` Xu Yilun
2023-06-23 0:55 ` Xu Yilun
2023-06-26 17:06 ` Mingwei Zhang
2023-06-18 0:08 ` [PATCH 3/6] KVM: Documentation: Add the missing ptep " Mingwei Zhang
2023-06-22 8:32 ` Huang, Kai
2023-06-26 17:29 ` Mingwei Zhang
2023-06-18 0:08 ` [PATCH 4/6] KVM: Documentation: Add the missing tdp_mmu_root_count into kvm_mmu_page Mingwei Zhang
2023-06-22 8:37 ` Huang, Kai
2023-06-26 17:55 ` Mingwei Zhang
2023-06-18 0:08 ` [PATCH 5/6] KVM: Documentation: Add the missing mmu_valid_gen " Mingwei Zhang
2023-06-22 8:42 ` Huang, Kai
2023-06-18 0:08 ` [PATCH 6/6] KVM: Documentation: Add the missing tdp_mmu_page " Mingwei Zhang
2023-06-22 8:40 ` Huang, Kai
2023-06-26 17:59 ` Mingwei Zhang
2023-06-19 9:00 ` [PATCH 0/6] KVM: Documentation: Update document description for kvm_mmu_page and kvm_mmu_page_role Zhi Wang
2023-06-21 18:33 ` Mingwei Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL715WKF8Ws1E0UNvRNQ7ZqisrFD6srC3o24g8FU=f=f0YwUKw@mail.gmail.com' \
--to=mizhang@google.com \
--cc=bgardon@google.com \
--cc=dmatlack@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=zhi.wang.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).