From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6E001F37D3 for ; Wed, 28 May 2025 04:58:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748408304; cv=none; b=EkbjgmE5H5N2bcOuTf/jdNaS5Ol4pmrL17s9j9suFNVsTqR1kU1x3lhGKN+JSbeDl2lLkY588XEQWbIA1Bq4AWsmDpgjryP/hTJjRd8rljnhhWpLd6HT5F7m2a5bBeb0RgdEiAM3j9bveYIK8g8PL1jySS/80v/SUKByFGuJ3Pk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748408304; c=relaxed/simple; bh=2LX650AeAHn3TzSjSL4/06vnyAtRrEY3yfwhoaLvd6s=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=g2JVc2Ao7QR/W1os0utl/ePQ+/RiK3Fbrg2wILJBaR4vgol6nS+1Ty5VNvHmyHLzRf3/PmzN4eDknof2kXQT5gUcKyvRP+zHO+LyjdzWkNTLwUgaooFhaW/TvKaPRwyrKzpXHRbe5xzRdFNQ1c5Qbm4z4IvHPPwf6pyzoqs80zE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LZ65FbHh; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LZ65FbHh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748408301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lvIb7tWWsEupK9BWjz39c0yzeNm9G9imVR6VZCBLXa4=; b=LZ65FbHhSY1AbsNa+qH/W0trd+X8nhpyYf/KX9GKe1PTnt4Yw8kZW947MvfIKV+SBvWHRh E9qRUKiYdBfRSfsL/xdYrn9pQMngjhzFwiegFLFQ6cimDQZbGx+CAolJsNnTg21YT/9MEW 08dXXKHi6i46Ew/bEIykc+UQfenrf/s= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-135-DtMJW2xsOZWzEgzwqUPqCA-1; Wed, 28 May 2025 00:58:19 -0400 X-MC-Unique: DtMJW2xsOZWzEgzwqUPqCA-1 X-Mimecast-MFC-AGG-ID: DtMJW2xsOZWzEgzwqUPqCA_1748408298 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-32805c6330aso20076931fa.0 for ; Tue, 27 May 2025 21:58:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748408298; x=1749013098; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lvIb7tWWsEupK9BWjz39c0yzeNm9G9imVR6VZCBLXa4=; b=gXaCMzp5hyixelwnQZdhHweMf5yOv0IPgsqTxxptBfOfG/nBwlOu6ooFXa3YaXUtBq bW0/Qae6K2pRz0ibpDQNerFiDRNC4veP19GZH3vLqEUWaS3QwXwfsrfysOb3jXNCS4l7 CeOu42KTgrHZHU4855wmB7dryMA0Kt3GqZx6hIDM/+p+zzW8dIIByhlqCb/gLOU72QVF ZWtwpzg6HiYR7uhzKFf8/DYOYm3aH7poztcYM1pEj0K4TT8D2QpxcrFCw/9ED1PgOexd c/qOBdK9dE/JWSprs3lgiDZ+B+LJQLnMMsQuLvzOZt1pqklR3cUQtO4XGnrdMXuBs4uU 1dCQ== X-Forwarded-Encrypted: i=1; AJvYcCXnr7ooHhohJldLhVo8ctxkLZYlZd0HX+1FpofVSqr63SbKbfg+grBia8kcBGCwAz37xkStMj56Zco=@vger.kernel.org X-Gm-Message-State: AOJu0YyYRjeHo3BprE77mdGv4G9j9kaI1l99mmtyF24NtAzO28QTtTS0 pTD+8LLaYujllfER7On8zQcircvhPAcITksWtlk2s+FfV8Fj0bk6GKqFJznvoA5P6zObxo0cQH8 zbcdB4/LH/0o5DiSP3paHY1UDJQU5cHbmdNJtGiqlNxH0An2mJJLfMPNHW/Ehr7hwou9RImwo0q NIoic1DxLY6uwE/RjmNQKmZlsL8AVYuVlfJxhr X-Gm-Gg: ASbGnctlTqiMwvS7rrqs/xuauZ85o6Ch0KsWcn2/D0GJrlwgplyb74kTAVTgxK77xpv JToGfXtRgsGrt9YnDvNFRfOCTds9d/goxl9PrDrT6f+jJtai0KkWPKpI8HAvJJyUBAxslcQ== X-Received: by 2002:a05:651c:4208:b0:30b:c980:c589 with SMTP id 38308e7fff4ca-32a79aaf867mr1376031fa.14.1748408298249; Tue, 27 May 2025 21:58:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGLuLgqlBSKVn3XuzZ5O4WHptTWpAn5Hj8UQwNjGJRq+mdS4yUEkruE7gijVJvks3bFhtJOEMBJBaD1evghUbY= X-Received: by 2002:a05:651c:4208:b0:30b:c980:c589 with SMTP id 38308e7fff4ca-32a79aaf867mr1375941fa.14.1748408297836; Tue, 27 May 2025 21:58:17 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250524061320.370630-1-yukuai1@huaweicloud.com> <20250524061320.370630-15-yukuai1@huaweicloud.com> In-Reply-To: <20250524061320.370630-15-yukuai1@huaweicloud.com> From: Xiao Ni Date: Wed, 28 May 2025 12:58:05 +0800 X-Gm-Features: AX0GCFukkho086GfzsFTanUNNcI5WTEbYMx59B1Hh2FftMmayZ2nfabg-QIjzlg Message-ID: Subject: Re: [PATCH 14/23] md/dm-raid: remove max_write_behind setting limit To: Yu Kuai Cc: hch@lst.de, colyli@kernel.org, song@kernel.org, yukuai3@huawei.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, yi.zhang@huawei.com, yangerkun@huawei.com, johnny.chenyi@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, May 24, 2025 at 2:18=E2=80=AFPM Yu Kuai w= rote: > > From: Yu Kuai > > The comments said 'vaule in kB', while the value actually means the > number of write_behind IOs. And since md-bitmap will automatically > adjust the value to max COUNTER_MAX / 2, there is no need to fail > early. > > Also move some macros that is only used md-bitmap.c. > > Signed-off-by: Yu Kuai > --- > drivers/md/dm-raid.c | 6 +----- > drivers/md/md-bitmap.c | 10 ++++++++++ > drivers/md/md-bitmap.h | 9 --------- > 3 files changed, 11 insertions(+), 14 deletions(-) > > diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c > index 088cfe6e0f98..9757c32ea1f5 100644 > --- a/drivers/md/dm-raid.c > +++ b/drivers/md/dm-raid.c > @@ -1356,11 +1356,7 @@ static int parse_raid_params(struct raid_set *rs, = struct dm_arg_set *as, > return -EINVAL; > } > > - /* > - * In device-mapper, we specify things in sectors= , but > - * MD records this value in kB > - */ > - if (value < 0 || value / 2 > COUNTER_MAX) { > + if (value < 0) { > rs->ti->error =3D "Max write-behind limit= out of range"; > return -EINVAL; > } > diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c > index 535bc1888e8c..098e7b6cd187 100644 > --- a/drivers/md/md-bitmap.c > +++ b/drivers/md/md-bitmap.c > @@ -98,9 +98,19 @@ > * > */ > > +typedef __u16 bitmap_counter_t; > + > #define PAGE_BITS (PAGE_SIZE << 3) > #define PAGE_BIT_SHIFT (PAGE_SHIFT + 3) > > +#define COUNTER_BITS 16 > +#define COUNTER_BIT_SHIFT 4 > +#define COUNTER_BYTE_SHIFT (COUNTER_BIT_SHIFT - 3) > + > +#define NEEDED_MASK ((bitmap_counter_t) (1 << (COUNTER_BITS - 1))) > +#define RESYNC_MASK ((bitmap_counter_t) (1 << (COUNTER_BITS - 2))) > +#define COUNTER_MAX ((bitmap_counter_t) RESYNC_MASK - 1) > + > #define NEEDED(x) (((bitmap_counter_t) x) & NEEDED_MASK) > #define RESYNC(x) (((bitmap_counter_t) x) & RESYNC_MASK) > #define COUNTER(x) (((bitmap_counter_t) x) & COUNTER_MAX) > diff --git a/drivers/md/md-bitmap.h b/drivers/md/md-bitmap.h > index d2cdf831ef1a..a9a0f6a8d96d 100644 > --- a/drivers/md/md-bitmap.h > +++ b/drivers/md/md-bitmap.h > @@ -9,15 +9,6 @@ > > #define BITMAP_MAGIC 0x6d746962 > > -typedef __u16 bitmap_counter_t; > -#define COUNTER_BITS 16 > -#define COUNTER_BIT_SHIFT 4 > -#define COUNTER_BYTE_SHIFT (COUNTER_BIT_SHIFT - 3) > - > -#define NEEDED_MASK ((bitmap_counter_t) (1 << (COUNTER_BITS - 1))) > -#define RESYNC_MASK ((bitmap_counter_t) (1 << (COUNTER_BITS - 2))) > -#define COUNTER_MAX ((bitmap_counter_t) RESYNC_MASK - 1) > - > /* > * version 3 is host-endian order, this is deprecated and not used for n= ew > * array > -- > 2.39.2 > Reviewed-by: Xiao Ni