From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 155FD7E27E for ; Tue, 17 Apr 2018 13:17:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753074AbeDQNRQ (ORCPT ); Tue, 17 Apr 2018 09:17:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:56400 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752641AbeDQNRO (ORCPT ); Tue, 17 Apr 2018 09:17:14 -0400 Received: from mail-qt0-f176.google.com (mail-qt0-f176.google.com [209.85.216.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C9D8F21842; Tue, 17 Apr 2018 13:17:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9D8F21842 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh@kernel.org Received: by mail-qt0-f176.google.com with SMTP id p9so16585070qtn.0; Tue, 17 Apr 2018 06:17:13 -0700 (PDT) X-Gm-Message-State: ALQs6tDstDb6i3tF4c9VLWUvIRmIV2gbxV/jz8FJZ0R3Jdt7ZMnoJ00b Vn8d2YVq7auKdFwQ9/dwNXE54sMJeuNfu9vqog== X-Google-Smtp-Source: AIpwx4802ncWWEWk0pJFFsJpjoTSZiUW0j3gsDUlj2tpHMj0vxmkfyQVbhsjL9XI5daoDWXmFS0uHePb+CjLbsHbOoI= X-Received: by 10.200.67.210 with SMTP id w18mr2402978qtn.327.1523971032932; Tue, 17 Apr 2018 06:17:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.163.228 with HTTP; Tue, 17 Apr 2018 06:16:52 -0700 (PDT) In-Reply-To: <53ff5b2b-eba8-8311-64a9-abd4bc72226d@linux.intel.com> References: <20180410183212.16787-1-jae.hyun.yoo@linux.intel.com> <20180410183212.16787-5-jae.hyun.yoo@linux.intel.com> <20180416181035.rcjvt4rlrwaj5yxf@rob-hp-laptop> <53ff5b2b-eba8-8311-64a9-abd4bc72226d@linux.intel.com> From: Rob Herring Date: Tue, 17 Apr 2018 08:16:52 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 04/10] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs To: Jae Hyun Yoo Cc: Alan Cox , Andrew Jeffery , Andrew Lunn , Andy Shevchenko , Arnd Bergmann , Benjamin Herrenschmidt , Fengguang Wu , Greg KH , Guenter Roeck , Haiyue Wang , James Feist , Jason M Biils , Jean Delvare , Joel Stanley , Julia Cartwright , Miguel Ojeda , Milton Miller II , Pavel Machek , Randy Dunlap , Stef van Os , Sumeet R Pawnikar , Vernon Mauery , "linux-kernel@vger.kernel.org" , linux-doc@vger.kernel.org, devicetree@vger.kernel.org, Linux HWMON List , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , OpenBMC Maillist Content-Type: text/plain; charset="UTF-8" Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, Apr 16, 2018 at 6:12 PM, Jae Hyun Yoo wrote: > On 4/16/2018 11:10 AM, Rob Herring wrote: >> >> On Tue, Apr 10, 2018 at 11:32:06AM -0700, Jae Hyun Yoo wrote: >>> >>> This commit adds a dt-bindings document of PECI adapter driver for Aspeed >>> AST24xx/25xx SoCs. [...] >>> +- clocks : Should contain clock source for PECI controller. >>> + Should reference clkin. >>> +- clock_frequency : Should contain the operation frequency of PECI >>> controller >>> + in units of Hz. >>> + 187500 ~ 24000000 >> >> >> This is the frequency of the bus or used to derive it? It would be >> better to specify the bus frequency instead and have the driver >> calculate its internal freq. And then use "bus-frequency" instead. >> > > I agree with you. Actually, it is being used for operation frequency setting > of PECI controller module in SoC so it's different from the meaning of > "bus-frequency". I'll change it to "operation-frequency". No, now you've gone from a standard property name to something custom. Why do you need to set the frequency in DT if it is not related to the interface frequency? Rob -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html