From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2BD62F290E for ; Tue, 26 Aug 2025 17:54:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756230896; cv=none; b=MvHx82UXckTD2dLEz/msSkAf6OAKCu6EAteLjxY6H1e63tsHTVGHCz/ter89uovkCD8pD9/+np7CSS47stB2saAQ9ofcg8v2Wr8k9Dv9zBWMQADxlIzqs23TWNpPw0U+Yl7S30eVzkE9VTLfmLIHAzUFItwRw4+Fz7LaDSU5IQ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756230896; c=relaxed/simple; bh=ADBEEqt/I8SsdIPdL0Z1b4ITRIPJaLgfFIXwhculx/M=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=bMKWhGFeHDrBOqGh0E0zei5+H+17y6L+RaS7F9imEQGmgsiC4V5baFdLBHOl1HIFiYH+J5cnYVIO0KEc2aOhf8A0hha086xdQLUa3KlB6nOLDC2WY+VFgu7JZI+OMNabjAuQV8UvW465WLdTk+jugxKfFvqj57FYIGBrx3tetuw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=PDsMyEH9; arc=none smtp.client-ip=209.85.160.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="PDsMyEH9" Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-4b109bcceb9so68591281cf.2 for ; Tue, 26 Aug 2025 10:54:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1756230894; x=1756835694; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pSb2xeuH5g+6pcK1HzZBzpHptHzZggPfdPMJITj9iKs=; b=PDsMyEH95Pio7xl9aCdxsQIaxwBeDXVMDz7AaGxUgFRbT/crn/+1cX9NoTaSTPOcEF GS0pq1tKRJOy0nNiYufvVcyYhDxNrIWmmd+65Ob7nl6dLdr5dAFc3xOo3xqYu5Ezt+dM nrO7alMnmnP/p5Yx1S02nZABXXcNjcnkhHT0GhvPuvlxQyDWFIi7vX3E2dqBisBTZ2IL RhcW4YR2CLog4B+TRlNT4L77P9TW0jvfCUZ4QCIaL0Foe0BUY9bOA1nBU45o3dX19bS+ LJsgrvCU/ojxNJSpad7XNmBidJVVVGQzOA6X0gDahbD1EYcnssYKZc6SXDADjgj6Svoq kmrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756230894; x=1756835694; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pSb2xeuH5g+6pcK1HzZBzpHptHzZggPfdPMJITj9iKs=; b=ij1buaB3UOj7cgCjen1CTYoyiR0Z4fQA6WBSE3BDjpxBGn07AKfZdZHusWdXrD+VM3 FCeU+MwZB1cwX8P3dmgYQnl219jZAHRm5bttPVBGn6jkJ3615n2A0mZ4YmW71tFkgR7Y OuBWOvNofP6pI77SaQ41lvvGdV3NMjtyJ5rotSnhl1kOxXAMCI7IE2WHxH4RcW5OEePC a2Q6yr5x7OYziiCBGYYDnFNkeSSd1CLQliBhD3hvLRxTshHOhOH2vZnp5XYfelCja2aW Ed89d+wC5UeX0t71BRpbJ34e/WgK0PDdKlrGtPgx+XEWbw2O7njGQWmajozo5DVJA3S4 rB6A== X-Forwarded-Encrypted: i=1; AJvYcCVasv2koy3BCaixDmKFKsxt9J3NMuDDYhQy3Pl0usAAjvrCv/Y91+1L/Hv+dVilRCeq421To+6gEHk=@vger.kernel.org X-Gm-Message-State: AOJu0YzlLXbvEOHKEJ+ZKlYPUpT8KMqYsTUhY1sWNZIf2K0uEh60oAru 5j0BPvIHTyCvwLagpQakjPuFRPeVhAVzaoGYJzJU5NxS9XWbfs4Q/JrJkEvgrl5F9f812ZeYfpk ogcbHrDfb/Ljz9bz7dJZ4bE3utrvj1jPdnjmjjs3L X-Gm-Gg: ASbGncuqvLhOVf0MwWoWUYaP5flZPo45cw0i9SkG+7xqkNzxAEeBFYHLckUnpnbjbJG 0gSr35DK3aJVvHgNqRs7QYZjf8MUCgaB1s7W9MTtj+FJ1omBHfaphPpv8964nMNeM7b/HVR0HTx siEaqpPlAwhkKUieaTCrSjVu+xlqfSABP39YGY3AyrKBWws7louWVcA9bFCrDCuxciDTlSBB21d P4tEgBTJLx4 X-Google-Smtp-Source: AGHT+IGGV2iyiFmOetInhyxJac4maVVv9fhX96wCprAYO268RITg9RwggZY0uPKZ1PsqeLTeF9F0EJGRkzJfaLhZnes= X-Received: by 2002:a05:622a:282:b0:4b2:8ac4:ef6d with SMTP id d75a77b69052e-4b2aab2be72mr180073441cf.80.1756230892932; Tue, 26 Aug 2025 10:54:52 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <13ffd1d836eb7aa6563ad93bf5fa5196afdf0053.1756195078.git.zhuyikai1@h-partners.com> In-Reply-To: <13ffd1d836eb7aa6563ad93bf5fa5196afdf0053.1756195078.git.zhuyikai1@h-partners.com> From: Eric Dumazet Date: Tue, 26 Aug 2025 10:54:41 -0700 X-Gm-Features: Ac12FXzidWiTzgg1SRAg60WMCjO05ky3XuED9kyRpFIj1-4hIpt4sOx0xIE9MUY Message-ID: Subject: Re: [PATCH net-next v01 10/12] hinic3: Add Rss function To: Fan Gong Cc: Zhu Yikai , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Lunn , linux-doc@vger.kernel.org, Jonathan Corbet , Bjorn Helgaas , luosifu , Xin Guo , Shen Chenyang , Zhou Shuai , Wu Like , Shi Jing , Meny Yossefi , Gur Stavi , Lee Trager , Michael Ellerman , Vadim Fedorenko , Suman Ghosh , Przemek Kitszel , Joe Damato , Christophe JAILLET Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Aug 26, 2025 at 2:06=E2=80=AFAM Fan Gong wrot= e: > > Initialize rss functions. Configure rss hash data and HW resources. > > Co-developed-by: Xin Guo > Signed-off-by: Xin Guo > Co-developed-by: Zhu Yikai > Signed-off-by: Zhu Yikai > Signed-off-by: Fan Gong > --- ... > +static int alloc_rss_resource(struct net_device *netdev) > +{ > + struct hinic3_nic_dev *nic_dev =3D netdev_priv(netdev); > + static const u8 default_rss_key[L2NIC_RSS_KEY_SIZE] =3D { > + 0x6d, 0x5a, 0x56, 0xda, 0x25, 0x5b, 0x0e, 0xc2, > + 0x41, 0x67, 0x25, 0x3d, 0x43, 0xa3, 0x8f, 0xb0, > + 0xd0, 0xca, 0x2b, 0xcb, 0xae, 0x7b, 0x30, 0xb4, > + 0x77, 0xcb, 0x2d, 0xa3, 0x80, 0x30, 0xf2, 0x0c, > + 0x6a, 0x42, 0xb7, 0x3b, 0xbe, 0xac, 0x01, 0xfa}; > + > + nic_dev->rss_hkey =3D kzalloc(L2NIC_RSS_KEY_SIZE, GFP_KERNEL); > + if (!nic_dev->rss_hkey) > + return -ENOMEM; > + > + memcpy(nic_dev->rss_hkey, default_rss_key, L2NIC_RSS_KEY_SIZE); I think you need to explain why you are not using netdev_rss_key_fill()