From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60BA0C433EF for ; Thu, 14 Apr 2022 08:59:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233750AbiDNJCA (ORCPT ); Thu, 14 Apr 2022 05:02:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241391AbiDNJBw (ORCPT ); Thu, 14 Apr 2022 05:01:52 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9CB36E545 for ; Thu, 14 Apr 2022 01:59:14 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id j8so4102669pll.11 for ; Thu, 14 Apr 2022 01:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0LUCoLOqsjdmuMA9Sv/GTYrqnMUY1MiY7Yfiq4vegQE=; b=HomuRkNsmV7IKhzIJt76YdeNNTkW/NrcqeA7SzFmKUtPaY3/VHAjsS6yZ7zHOBKR8r zCbX6k8iFJINPRJt9zuZu8/CXDMqLnhSxOGqYIJpYeDl+0FvJm/iSC9G3LsO52+Oz2dg rsYn2iXkkOEIHk3i3p7NtE9HPSbQsp1vtXzXF2xhtp8OUDuCvSp+B5vvOv5814PjX+ok 4LMXXWwLCY54XIJCI9Ibtxe+l/9oNMHcSY+At3un98WY7TMznKD02N7Wk8UNO8TB52aB 47NserAFqEUbjQx9vcfA+BEoQm5QtpTY7JEe5FLzJ5a8cfqTN4598JvJjiu2XQgMRIRQ rsog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0LUCoLOqsjdmuMA9Sv/GTYrqnMUY1MiY7Yfiq4vegQE=; b=It9UMEPUuu8k3lPwEhcSF3GHMC4Cq927VSwCLOlgG3Y8rclVR7CM+UMm5NCI3Wdm6F pvoZoldZDINPHLG+9I3VnDFg3wfT7Oz6BtAhrjEbHfGiXBcFOSV12XHt7tvkvqPXBVDn jNQxyC41E9sLxTuzDrzKulnnTnAw1pmeqSlI+Fk8rZL9MBjqy/kJs3gP1yqOgUSUMcKj e3PyvOwAOtsPdZOnEEXJWdfAnMycsbkWZwMHOyQOSyLf0rE4KmMpmrxM0+zcXiHLjYTm eniWlZDWSy3nIS6Gs3aPPK3/S48FmaCFgrwMjJ3EFjItqmb0+i7wWMix+1hHuGHhLe+B XRbw== X-Gm-Message-State: AOAM533ucAbG5wXfYgdjoGqyG8UJvP2jHZBZiNSyecZlm6M5AVLmgu5f 9YkPrG4wsgBygZLkMdoxnZcMFI/zEUR8vkGyHBNB1Q== X-Google-Smtp-Source: ABdhPJxlr3HwneXRMQWmwp1QPVtDvPbaeJ6+jvqdb1zomhx1OdLrBeAIymtji6CSi0zshAF41yPRZfFxQZO+hbVuwLs= X-Received: by 2002:a17:902:7205:b0:156:1a0a:2c39 with SMTP id ba5-20020a170902720500b001561a0a2c39mr46589099plb.88.1649926754208; Thu, 14 Apr 2022 01:59:14 -0700 (PDT) MIME-Version: 1.0 References: <20220414025609.578-1-aajith@arista.com> <0bf37720-870a-9dde-d825-92e12633ce38@gmail.com> In-Reply-To: <0bf37720-870a-9dde-d825-92e12633ce38@gmail.com> From: Arun Ajith S Date: Thu, 14 Apr 2022 14:29:01 +0530 Message-ID: Subject: Re: [PATCH net-next v4] net/ipv6: Introduce accept_unsolicited_na knob to implement router-side changes for RFC9131 To: Bagas Sanjaya Cc: netdev@vger.kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, dsahern@kernel.org, yoshfuji@linux-ipv6.org, kuba@kernel.org, pabeni@redhat.com, corbet@lwn.net, prestwoj@gmail.com, gilligan@arista.com, noureddine@arista.com, gk@arista.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Thank you. Do I have to post a v5 with the fixup ? -Arun -Arun On Thu, Apr 14, 2022 at 11:42 AM Bagas Sanjaya wrote: > > On 4/14/22 09:56, Arun Ajith S wrote: > > Add a new neighbour cache entry in STALE state for routers on receiving > > an unsolicited (gratuitous) neighbour advertisement with > > target link-layer-address option specified. > > This is similar to the arp_accept configuration for IPv4. > > A new sysctl endpoint is created to turn on this behaviour: > > /proc/sys/net/ipv6/conf/interface/accept_unsolicited_na. > > > > Hi, > > Building the documentation (htmldocs) with this patch, I got: > > /home/bagas/repo/linux-stable/Documentation/networking/ip-sysctl.rst:2475: > WARNING: Unexpected indentation. > /home/bagas/repo/linux-stable/Documentation/networking/ip-sysctl.rst:2477: > WARNING: Unexpected indentation. > /home/bagas/repo/linux-stable/Documentation/networking/ip-sysctl.rst:2481: > WARNING: Unexpected indentation. > /home/bagas/repo/linux-stable/Documentation/networking/ip-sysctl.rst:2482: > WARNING: Block quote ends without a blank line; unexpected unindent. > > I have applied following fixup. > > ---- 8> ---- > From 304846b43a9f962f53f3841afabfd597b3b80951 Mon Sep 17 00:00:00 2001 > From: Bagas Sanjaya > Date: Thu, 14 Apr 2022 12:59:46 +0700 > Subject: [PATCH] fixup for "net/ipv6: Introduce accept_unsolicited_na knob to > implement router-side changes for RFC9131" > > Fix the simple table syntax. > > Signed-off-by: Bagas Sanjaya > --- > Documentation/networking/ip-sysctl.rst | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst > index 9e17efe343a..433f2e4a5fe 100644 > --- a/Documentation/networking/ip-sysctl.rst > +++ b/Documentation/networking/ip-sysctl.rst > @@ -2472,13 +2472,17 @@ accept_unsolicited_na - BOOLEAN > unsolicited neighbour advertisement with target link-layer address option > specified. This is as per router-side behavior documented in RFC9131. > This has lower precedence than drop_unsolicited_na. > + > + ==== ====== ====== ============================================== > drop accept fwding behaviour > ---- ------ ------ ---------------------------------------------- > 1 X X Drop NA packet and don't pass up the stack > 0 0 X Pass NA packet up the stack, don't update NC > 0 1 0 Pass NA packet up the stack, don't update NC > 0 1 1 Pass NA packet up the stack, and add a STALE > - NC entry > + NC entry > + ==== ====== ====== ============================================== > + > This will optimize the return path for the initial off-link communication > that is initiated by a directly connected host, by ensuring that > the first-hop router which turns on this setting doesn't have to > > base-commit: 38e01f46e0e7f88b92ca0b3f52ac6b9909ed413b > -- > An old man doll... just what I always wanted! - Clara > > Thanks. > > -- > An old man doll... just what I always wanted! - Clara