From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 824B4C4727F for ; Mon, 28 Sep 2020 09:20:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4626521D95 for ; Mon, 28 Sep 2020 09:20:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="h0nsKxQ1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726682AbgI1JUH (ORCPT ); Mon, 28 Sep 2020 05:20:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726629AbgI1JUC (ORCPT ); Mon, 28 Sep 2020 05:20:02 -0400 Received: from mail-vk1-xa33.google.com (mail-vk1-xa33.google.com [IPv6:2607:f8b0:4864:20::a33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E0D0C0613D3 for ; Mon, 28 Sep 2020 02:20:02 -0700 (PDT) Received: by mail-vk1-xa33.google.com with SMTP id k78so1381967vka.10 for ; Mon, 28 Sep 2020 02:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QQu91B+AW3IRpHZjKS2p4lMu3W034IPbEyQrKhHugtA=; b=h0nsKxQ1792AaIhUo13P82vgGVMXclf9CkIZ3KapAzb2X/3tNBKYsSGecwrBlaGlfj Tfj/C9Zv83pHcreLOpATprEGXKgXE7GflMxTk85DdzpRec/t1LnE+wiAfP6b5BIHasHY Ignqf7gF7vwjnL8HCCY3lSkGXTjCE+cuCHlYoEe1V1ud1mcWehNemRROw+dC/JdC1/0c 0PedcFoH2tLhd3HHLNfHHJrCV/CVoz/bfJ60yVp2iKXm17ESSv95/LpX2Y/Dg/8GDOjv 2ofiMkyoa80M4iYbgDGr8oelbtFwixNkB383I0V8notORYCLMV89a0h5ooLViuYHEZeT ZUiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QQu91B+AW3IRpHZjKS2p4lMu3W034IPbEyQrKhHugtA=; b=pyBXM/ji6sfpU3tUkxF6tM7Sr/h0eQYuReRuNgjZRd7aOUjMDDV680FojMXfy9stYm OnFCqlrI3yA+z9KzSUAX2FEduOyb70l29/pvl1arVnPM1sUycmliw0iO6A3FabWS5VrB SO9LYmjLJynZVvSyrFuZ4CqS6GAr0akpUvEFz5YshqO6Btkf84hs/ZBZV3CtnNjq/rBa RJmrJjpnZMUjl3A48rF944wDZyeIyAz1jQ6Bt+r2N9IcBeolh5rqtBxZupaAHLN89TK/ PxPfYAWhlBd7P7X5usf6FpeQAOAFuUHLqChEyeB4Ewjb/nc60Houoaq4mH7PgoRdxVof XVZA== X-Gm-Message-State: AOAM5324CHjhU3wlfGNhoQiDth6vtvxoeMnDSsx0zTev7dSxxnxusmLN QvNCz6ON0BRW7QPhp87P+U9MZCwK4suf2e+KPbaXFQ== X-Google-Smtp-Source: ABdhPJyIPAnJj5fPmVsL4k9MF4OtxiE77/7ix/Qafm1hzLnqts1eYR1koTMhcOn/iv3ljy6H8r2txH0J3D7/fATe+GY= X-Received: by 2002:ac5:c748:: with SMTP id b8mr4530997vkn.6.1601284801206; Mon, 28 Sep 2020 02:20:01 -0700 (PDT) MIME-Version: 1.0 References: <20200927194846.045411263@linutronix.de> <20200927194922.245750969@linutronix.de> In-Reply-To: From: Ulf Hansson Date: Mon, 28 Sep 2020 11:19:25 +0200 Message-ID: Subject: Re: [patch 24/35] net: brcmfmac: Replace in_interrupt() To: Arend Van Spriel Cc: Thomas Gleixner , LKML , Peter Zijlstra , Linus Torvalds , Paul McKenney , Matthew Wilcox , Sebastian Andrzej Siewior , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo , "David S. Miller" , Jakub Kicinski , linux-wireless , brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list , netdev , Christian Benvenuti , Govindarajulu Varadarajan <_govind@gmx.com>, Jonathan Corbet , Mauro Carvalho Chehab , Linux Documentation , Luc Van Oostenryck , Jay Cliburn , Chris Snook , Vishal Kulkarni , Jeff Kirsher , intel-wired-lan@lists.osuosl.org, Shannon Nelson , Pensando Drivers , Andrew Lunn , Heiner Kallweit , Russell King , Thomas Bogendoerfer , Solarflare linux maintainers , Edward Cree , Martin Habets , Jon Mason , Daniel Drake , Ulrich Kunitz , Linux USB List , Greg Kroah-Hartman , Stanislav Yakovlev , Stanislaw Gruszka , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , Jouni Malinen , Amitkumar Karwar , Ganapathi Bhat , Xinming Hu , libertas-dev@lists.infradead.org, Pascal Terjan , Ping-Ke Shih Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, 28 Sep 2020 at 09:35, Arend Van Spriel wrote: > > + Uffe > > On 9/27/2020 9:49 PM, Thomas Gleixner wrote: > > @@ -85,7 +85,7 @@ static void brcmf_sdiod_ib_irqhandler(st > > > > brcmf_dbg(INTR, "IB intr triggered\n"); > > > > - brcmf_sdio_isr(sdiodev->bus); > > + brcmf_sdio_isr(sdiodev->bus, false); > > } > > Hi Uffe, > > I assume the above code is okay, but want to confirm. Is the SDIO > interrupt guaranteed to be on a worker thread? Correct. As a matter of fact, the sdio irqs can be delivered through a couple of different paths. The legacy (scheduled for removal), is from a dedicated kthread. The more "modern" way is either from the context of a threaded IRQ handler or via a workqueue. However, there are also so-called out of band SDIO irqs, typically routed via a separate GPIO line. This isn't managed by the MMC/SDIO subsystem, but the SDIO functional driver itself. Kind regards Uffe