From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6972C43219 for ; Tue, 19 Apr 2022 18:22:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357101AbiDSSZ2 (ORCPT ); Tue, 19 Apr 2022 14:25:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357123AbiDSSWq (ORCPT ); Tue, 19 Apr 2022 14:22:46 -0400 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23A58419AE for ; Tue, 19 Apr 2022 11:15:16 -0700 (PDT) Received: by mail-pg1-x52e.google.com with SMTP id t13so24866267pgn.8 for ; Tue, 19 Apr 2022 11:15:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zpBv9Q1tNkPDBxpwPbLdjbsmA3r5cT/nw1H2p8//7VQ=; b=nZvZCFCBv0zvPnol4PONdYJwznuBCN/AxhcMZT3PpAg7N/VnQFuPRmc59dVJmZhUZX ECMv/hjCGO+Yo9hPm0IPGeKJ0B6ktiAJyHTxXvVuF2aVbAVF8CuAQHgIJP1LNJMXn9tW pewlp4W+kHkNI1zg56QFlr1V7Y7IC03EodUwq8bmU0cnToRJRtLyABVPCFbP3syCDchx LDjvNXMhS7Xh2ngpvwPQ2GqpF+opYdpOjCsLq6UgJBnYaZhcq7SIJ1v5a7aSd1NogVh6 VSjMR54pFEhQe1/PiG/gXQU8g8fXg+WNaoH+BrDQzIaYm/mRG5gcSrOvz7wSwTEhHzhn RLUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zpBv9Q1tNkPDBxpwPbLdjbsmA3r5cT/nw1H2p8//7VQ=; b=ho/CDTPZt2g8xCBE1O1l3elOIixaxbsSxiNypr4v4gBMsqvxLU80DmxiFy76pDWvaL vt6VxjXIDZ33Vl58ePre0sEl4D2M79YIqVgYClKAB0McDnzwOIWeZtoWQqVgQSZ52phP KSKbXn6XBpiE27jqxLP1jGKXTZoVE+rhDhiOMqkNivVbrKLafIKufQ9numzshEpW6W99 bjKh+5Xv76T0G2+nWR6HufzWBhfgQ/k4xms8zvTlFlvO9fbtCcNM7ngbdCPIMcOpCesy 626cOXntwQJp7K5a11R+EXihcuTtacF+5l0uB4jC47kE6NJ7nQwLfyqKmbbHdZHP/2S1 Rv+A== X-Gm-Message-State: AOAM531OmLk3WUr40WCpmvOZh+upN/KmLQCl30cy+J7tHDiBhFrAzPT9 eKmTN8KhRDE8obZRkxPkxTS/vQDP48R4/sDDjuS1Qw== X-Google-Smtp-Source: ABdhPJw4oSURnCuFS/ZVGc9BlKI9iSwFoHzN3zK1GLk085q5yQt4OdaNxeK86wgd3BiiLXrJ0hkQRIeqzlpHZRTTfTo= X-Received: by 2002:a65:6e0e:0:b0:399:26d7:a224 with SMTP id bd14-20020a656e0e000000b0039926d7a224mr15704175pgb.437.1650392116287; Tue, 19 Apr 2022 11:15:16 -0700 (PDT) MIME-Version: 1.0 References: <20220407191347.9681-1-jithu.joseph@intel.com> <20220419163859.2228874-1-tony.luck@intel.com> <20220419163859.2228874-10-tony.luck@intel.com> In-Reply-To: From: Dan Williams Date: Tue, 19 Apr 2022 11:15:05 -0700 Message-ID: Subject: Re: [PATCH v3 09/11] platform/x86/intel/ifs: Add IFS sysfs interface To: Greg KH Cc: "Luck, Tony" , Hans de Goede , markgross@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , X86 ML , "H. Peter Anvin" , Jonathan Corbet , Andy Shevchenko , "Joseph, Jithu" , "Raj, Ashok" , Steven Rostedt , Linux Kernel Mailing List , Linux Doc Mailing List , platform-driver-x86@vger.kernel.org, patches@lists.linux.dev, Ravi V Shankar Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, Apr 19, 2022 at 11:01 AM Greg KH wrote: > > On Tue, Apr 19, 2022 at 10:35:17AM -0700, Luck, Tony wrote: > > On Tue, Apr 19, 2022 at 07:20:54PM +0200, Greg KH wrote: > > > > +/* > > > > + * Note there is no need for a ->remove() call back. There isn't an > > > > + * "unload" operation to remove the scan binary from the BIOS reserved > > > > + * area. Also ".dev_groups" removal order will guarantee that any in > > > > + * flight tests have completed. > > > > + */ > > > > > > So you are ok with the warning the kernel gives you when you unload the > > > driver? That feels wrong :( > > > > What warning? > > > > # dmesg | tail -5 > > [ 38.084165] virbr0: port 1(virbr0-nic) entered listening state > > [ 38.149621] virbr0: port 1(virbr0-nic) entered disabled state > > [ 38.582054] broken atomic modeset userspace detected, disabling atomic > > [ 43.703321] igc 0000:01:00.0 enp1s0: NIC Link is Up 2500 Mbps Full Duplex, Flow Control: RX > > [ 43.703470] IPv6: ADDRCONF(NETDEV_CHANGE): enp1s0: link becomes ready > > # modprobe intel_ifs > > # ls /sys/devices/platform/intel_ifs.0/ > > details driver_override modalias reload status uevent > > driver image_version power run_test subsystem > > # rmmod intel_ifs > > # dmesg | tail -5 > > [ 38.084165] virbr0: port 1(virbr0-nic) entered listening state > > [ 38.149621] virbr0: port 1(virbr0-nic) entered disabled state > > [ 38.582054] broken atomic modeset userspace detected, disabling atomic > > [ 43.703321] igc 0000:01:00.0 enp1s0: NIC Link is Up 2500 Mbps Full Duplex, Flow Control: RX > > [ 43.703470] IPv6: ADDRCONF(NETDEV_CHANGE): enp1s0: link becomes ready > > # > > If there's no warning when the device goes away, why the crazy comment > trying to justify the lack of a remove callback? The comment clarifies the nuance that driver.dev_groups coordinates flushing access sysfs ops users before ->remove() is called. It can certainly be dropped.