From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A40BDC433EF for ; Tue, 19 Apr 2022 19:45:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356148AbiDSTsJ (ORCPT ); Tue, 19 Apr 2022 15:48:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356160AbiDSTr7 (ORCPT ); Tue, 19 Apr 2022 15:47:59 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E6B011C0F for ; Tue, 19 Apr 2022 12:45:15 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id r10so5474131pfh.13 for ; Tue, 19 Apr 2022 12:45:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=umMtnsauqQeI0NgI+fx6Tr/G9J3sdAyMJ/d4Ny9Ul3U=; b=AehAOKeaXjujrUFwMA6ZK71ZoKV0rmjP8U3MvAUztOhHEsG2J0rD+dQWbhsFYAdEE8 8ZY2LlALZ0XmQuLeQQIaeRRT7u4E27eDJVA3QdfUxT2ojlOLwlmK+E53c+s0iG550u43 w47YYKXccyOCiXIHqIR11MF0pt/HMYPDSKQMfZ+9ER4v1UeLJepZsl3Ct44G9yBoqNwW OlxE05TxKK2ddmy6ZeAiNYfoZdWS+VPyuj00LpztKb3B25ifcUzamp+2qoF2pp4+HXPe FaG1usXXb6XTT85qgtfuhQ0sjo21nJqJsdtL4uZLvUtZctI1LfuN3Nglx/7qtGxLqkW+ YF3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=umMtnsauqQeI0NgI+fx6Tr/G9J3sdAyMJ/d4Ny9Ul3U=; b=sBnuxpIyNgFUOh28vDr08EWXKjexAMhOH4BgeBYBiEpSxoHYQc6mP74YgusqSBQMDU ZdBe1ytsj3Gb1QXluqW29zVLw7GXtShzrt7hxxqixF6yTcX+kYV7lNG4juQbTt1GT6KY 4OldjkUWNwEqAEzqRKs9VyOpqZzW/iw11ctEw+moNhgAUPteiD8EEAnzVS2dEXE9jQy3 DsYEYY0mFQXJkrGz+e3iTbVbkRMHcmG6YijZoimIZ9yUOuJQ5WKGqVIXRzqnm3Uu+Vk9 CSXSAGT5guRgLPsUpT0nre15PeIJCM1Xo79IAHqNKo+bdsOXV5NFqXY/GPSDtumtCDn0 EPCw== X-Gm-Message-State: AOAM530HL1PTQgK3DMcUlFxDPJUwUlLN0PRaqHEF8wsaDfwE+rutQoiw iC1mFYGXsjyR6T7KIRd0WNpk0OI5WrFQbbx1/IzDLWAb1zUz4A== X-Google-Smtp-Source: ABdhPJwDrg6IREZgfK3FKe60lOcv304qCnNwmMnOuGJueDEDbEPxsP5SKNWyJSrQ/HkYnrQ/DokGtHbNTylYlCtGH3o= X-Received: by 2002:a05:6a00:e14:b0:4fe:3cdb:23f with SMTP id bq20-20020a056a000e1400b004fe3cdb023fmr19497787pfb.86.1650397514500; Tue, 19 Apr 2022 12:45:14 -0700 (PDT) MIME-Version: 1.0 References: <20220407191347.9681-1-jithu.joseph@intel.com> <20220419163859.2228874-1-tony.luck@intel.com> <20220419163859.2228874-3-tony.luck@intel.com> In-Reply-To: From: Dan Williams Date: Tue, 19 Apr 2022 12:45:03 -0700 Message-ID: Subject: Re: [PATCH v3 02/11] Documentation: In-Field Scan To: Greg KH Cc: Tony Luck , Hans de Goede , markgross@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , X86 ML , "H. Peter Anvin" , Jonathan Corbet , Andy Shevchenko , "Joseph, Jithu" , "Raj, Ashok" , Steven Rostedt , Linux Kernel Mailing List , Linux Doc Mailing List , platform-driver-x86@vger.kernel.org, patches@lists.linux.dev, Ravi V Shankar Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, Apr 19, 2022 at 9:48 AM Greg KH wrote: > > On Tue, Apr 19, 2022 at 09:38:50AM -0700, Tony Luck wrote: > > Add documentation for In-Field Scan (IFS). This documentation > > describes the basics of IFS, the loading IFS image, chunk > > authentication, running scan and how to check result via sysfs > > as well as tunable parameters. > > > > The CORE_CAPABILITIES MSR enumerates whether IFS is supported. > > > > The full github location for distributing the IFS images is > > still being decided. So just a placeholder included for now > > in the documentation. > > > > Future CPUs will support more than one type of test. Plan for > > that now by using a ".0" suffix on the ABI directory names. > > Additional test types will use ".1", etc. > > > > Reviewed-by: Dan Williams > > Signed-off-by: Tony Luck > > --- > > Documentation/x86/ifs.rst | 101 ++++++++++++++++++++++++++++++++++++ > > Documentation/x86/index.rst | 1 + > > 2 files changed, 102 insertions(+) > > create mode 100644 Documentation/x86/ifs.rst > > > > diff --git a/Documentation/x86/ifs.rst b/Documentation/x86/ifs.rst > > new file mode 100644 > > index 000000000000..62f3c07d433a > > --- /dev/null > > +++ b/Documentation/x86/ifs.rst > > @@ -0,0 +1,101 @@ > > +.. SPDX-License-Identifier: GPL-2.0 > > + > > +============= > > +In-Field Scan > > +============= > > + > > +Introduction > > +------------ > > + > > +In Field Scan (IFS) is a hardware feature to run circuit level tests on > > +a CPU core to detect problems that are not caught by parity or ECC checks. > > +Future CPUs will support more than one type of test which will show up > > +with a new platform-device instance-id, for now only .0 is exposed. > > + > > + > > +IFS Image > > +--------- > > + > > +Intel provides a firmware file containing the scan tests via > > +github [#f1]_. Similar to microcode there is a separate file for each > > +family-model-stepping. > > + > > +IFS Image Loading > > +----------------- > > + > > +The driver loads the tests into memory reserved BIOS local to each CPU > > +socket in a two step process using writes to MSRs to first load the > > +SHA hashes for the test. Then the tests themselves. Status MSRs provide > > +feedback on the success/failure of these steps. When a new test file > > +is installed it can be loaded by writing to the driver reload file:: > > + > > + # echo 1 > /sys/bus/platform/drivers/intel_ifs.0/reload > > + > > +Similar to microcode, the current version of the scan tests is stored > > +in a fixed location: /lib/firmware/intel/ifs.0/family-model-stepping.scan > > + > > +Running tests > > +------------- > > + > > +Tests are run by the driver synchronizing execution of all threads on a > > +core and then writing to the ACTIVATE_SCAN MSR on all threads. Instruction > > +execution continues when: > > + > > +1) All tests have completed. > > +2) Execution was interrupted. > > +3) A test detected a problem. > > + > > +In all cases reading the SCAN_STATUS MSR provides details on what > > +happened. The driver makes the value of this MSR visible to applications > > +via the "details" file (see below). Interrupted tests may be restarted. > > + > > +The IFS driver provides sysfs interfaces via /sys/devices/platform/intel_ifs.0/ > > +to control execution: > > + > > +Test a specific core:: > > + > > + # echo > /sys/devices/platform/intel_ifs.0/run_test > > + > > +when HT is enabled any of the sibling cpu# can be specified to test its > > +corresponding physical core. Since the tests are per physical core, the > > +result of testing any thread is same. It is only necessary to test one > > +thread. > > + > > +For e.g. to test core corresponding to cpu5 > > + > > + # echo 5 > /sys/devices/platform/intel_ifs.0/run_test > > + > > +Results of the last test is provided in /sys:: > > + > > + $ cat /sys/devices/platform/intel_ifs.0/status > > + pass > > sysfs documentation belongs in Documentation/ABI/ > > And why not just include this whole thing in the driver itself and suck > the documentation out of that? No need to have a separate file. At a minimum a separate file is needed to house the --- .. kernel-doc:: $source_file :doc: $header --- ...statements, but ok, I'll recommend that going forward to de-emphasize shipping content directly from Documentation/ when it can be ingested from "DOC:" source. I had been assuming DOC: blocks in the code were more for augmenting kernel-doc on driver internal ABIs and not longer theory of operation documentation that is an awkward fit for Documentation/ABI/.