From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 459B4204594 for ; Thu, 10 Apr 2025 08:49:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744274977; cv=none; b=aeIaoC1j5rtDHvXt7zGKYbsINMaW9U2PLQSahsVGy4K0q5kEq+pD40w2hl8iBa+rpfPh8AbwdkODjGYM2W07IFe8SE3uB9Y6yGxTks+h62oaJmSGaNa3eACHY7k6oRjjKaNrLyf+XNZuz+StxLe7B5nw/Z/IaBBPcWqHeq5cbdA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744274977; c=relaxed/simple; bh=+btaMpKeeBdGRBlfpT1TSOPhvtORg43su9uQOsAX5Es=; h=Mime-Version:Content-Type:Date:Message-Id:To:From:Subject:Cc: References:In-Reply-To; b=hJJTeQn6JwDqnil83QrWWUVL23oH+YY+ztvrDfkrPkYepHDaIoDdZkUqlVtkpN4SSqAr6SSaE4//QIK1S5JlRzPYrI0q2ejvICLSEJwUG1USUOM3r/Txi3LRMvYB6DlYhUNO/bv8N+v6lZ0uLL6buBZ6RtoXN15/PYfHwtJqDkU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=ArZVnl9J; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="ArZVnl9J" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-43e9ccaa1ebso593675e9.1 for ; Thu, 10 Apr 2025 01:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1744274973; x=1744879773; darn=vger.kernel.org; h=in-reply-to:references:cc:subject:from:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IEwPf3cBEf9ZFD3zZhCOLbWBp0B51DbgggktH5J+y1E=; b=ArZVnl9J30sx8+yQyFZEjZBH01meAzlOv5Gr9qxWKtevq/gXBjej+DpnfllAfQvwM2 bVXGaNyAmrgsp18pRPd2LiR+Y4UaZYIbphPpVT19PftYwQYsg6JAlA/uGP/3vmGIbqfB FJVw+q+esOAmA225EUTqTT7vKI4hqNULUnjoxnUc/XDdU6tGlTkvCv9jdzLqVMa0sEPE M3iTHC0DpI5Hfqwo38fdg5QTR2Fll25bgvcj+wq3hP/OH/EwmNsVFmo9Mmr313/ZoZSZ HdDjcS1w//G29nTd7FYXG3tsCrTU5WcQmkyvwj3milGagQLDf6F7u31LWoj2T8Ftj1++ j5dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744274973; x=1744879773; h=in-reply-to:references:cc:subject:from:to:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IEwPf3cBEf9ZFD3zZhCOLbWBp0B51DbgggktH5J+y1E=; b=uRH3yr9zLAz7scv1qxviFXMuwZPXOe7DqRn/zSG6efq2P0FAPPtudik+hlbGdl714p lAPgVKHUxapZQs3z8Z/iVijp9TLur3s4yJQCgSAodOx+ShMmfkLm6PAuwSQO2ZOFlj9W BMj0g2OQHKGGCUQ5+2S+2fFLOhvHtw1eCtsbOULBduA32zHlio0N0fEum9jXTR1Mhz/5 leaka/dd5IUoC8RXuqLOGkyQ5r8RLT4dL/ExgR3Jxd+JjhRD+D83D5dqxKPqLoQCko9O HuT/QrtUKwPDLOSjnVEryk7A+Nrd/M7Xt3CYZl8/8Y0xZ1oKjxr1kvfjuKy4qy3fE9/0 0RNA== X-Forwarded-Encrypted: i=1; AJvYcCWr8Q0vS5+0TMPeLtlFyt0ipF/VupnRr77fnnGIW4ASCgwY9NOmPLNSJrbm/2D9eeugA0PLNQNxalA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2yZqzKFi9ywiQSwq9x7IgajwS8LMYHrzGlSRH70uccFEJmPrp QXHSLwmAczhveqvjO33fR/wPt/b4ConzK9p1C+ocilZvuKEaWnrzoaFkB8RTn10= X-Gm-Gg: ASbGncs8vPK5VD7m0qQ43EBkjT98gzUdsBpURmtyWxmyf6Y5nBh4Vt7L4CaVwf/iFuI lk+4A1EdxxBuyRcfHl+FCF8El2bvI4OAFLDlFrNUWBsGZu0fy50EVUJ03tVuvycDMyFxkRSzrpB ETsbVxle5TtJr0vvY88GY0IZtGhVVdPslMLzo4TsMtwtBeYeRYqg+6CocQVeLLMM2JoI8mD+83k ydojpPdJw1GkQ7gE+OpYj5Ubr3fAcig17EbCgrP+VDfRsK3QQT220kwH9eIh3r+occI4wgxIUpy BYQL6dyVfF14vWpLs7FfZ0ZmCxSUTr5OKHm8CVb7dFUCHnQBkuH3qSTxBl0= X-Google-Smtp-Source: AGHT+IGXp6uVqxTmSQMdMVt3uEBGD0ZfsrbyUn6XrfTKoToYQ6belt1Wh1Dck02/rxvTlH6EUyAxZw== X-Received: by 2002:a05:600c:c87:b0:439:94f8:fc7b with SMTP id 5b1f17b1804b1-43f1eae40f4mr19787055e9.0.1744274973504; Thu, 10 Apr 2025 01:49:33 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200:7d22:13bb:e539:15ee]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f2066d069sm47866185e9.17.2025.04.10.01.49.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 01:49:33 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 10 Apr 2025 10:49:32 +0200 Message-Id: To: "Deepak Gupta" , "Thomas Gleixner" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , , "H. Peter Anvin" , "Andrew Morton" , "Liam R. Howlett" , "Vlastimil Babka" , "Lorenzo Stoakes" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Conor Dooley" , "Rob Herring" , "Krzysztof Kozlowski" , "Arnd Bergmann" , "Christian Brauner" , "Peter Zijlstra" , "Oleg Nesterov" , "Eric Biederman" , "Kees Cook" , "Jonathan Corbet" , "Shuah Khan" , "Jann Horn" , "Conor Dooley" From: =?utf-8?q?Radim_Kr=C4=8Dm=C3=A1=C5=99?= Subject: Re: [PATCH v12 17/28] riscv/signal: save and restore of shadow stack for signal Cc: , , , , , , , , , , , , , , , , , , , , , "linux-riscv" References: <20250314-v5_user_cfi_series-v12-0-e51202b53138@rivosinc.com> <20250314-v5_user_cfi_series-v12-17-e51202b53138@rivosinc.com> In-Reply-To: <20250314-v5_user_cfi_series-v12-17-e51202b53138@rivosinc.com> 2025-03-14T14:39:36-07:00, Deepak Gupta : > diff --git a/arch/riscv/kernel/signal.c b/arch/riscv/kernel/signal.c > @@ -140,6 +142,62 @@ static long __restore_v_state(struct pt_regs *regs, = void __user *sc_vec) > return copy_from_user(current->thread.vstate.datap, datap, riscv_v_vsiz= e); > } > =20 > +static long save_cfiss_state(struct pt_regs *regs, void __user *sc_cfi) > +{ > + struct __sc_riscv_cfi_state __user *state =3D sc_cfi; > + unsigned long ss_ptr =3D 0; > + long err =3D 0; > + > + if (!IS_ENABLED(CONFIG_RISCV_USER_CFI) || !is_shstk_enabled(current)) !is_shstk_enabled() should be enough here. [The rest looks fine, but I'll need more time to think about it. I'll return to this patch in v13.]