From: "Javier Carrasco" <javier.carrasco.cruz@gmail.com>
To: "Peter Zijlstra" <peterz@infradead.org>,
"Jonathan Corbet" <corbet@lwn.net>
Cc: <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Andrei Vagin" <avagin@google.com>
Subject: Re: [PATCH v2] docs: scheduler: completion: Document complete_on_current_cpu()
Date: Sun, 31 Aug 2025 18:04:32 +0800 [thread overview]
Message-ID: <DCGJ0S0C9ZZH.1IFDOEWH6YF2K@gmail.com> (raw)
In-Reply-To: <20250830190718.GS3289052@noisy.programming.kicks-ass.net>
On Sun Aug 31, 2025 at 3:07 AM CST, Peter Zijlstra wrote:
> On Fri, Aug 29, 2025 at 04:44:28PM -0600, Jonathan Corbet wrote:
>> Javier Carrasco <javier.carrasco.cruz@gmail.com> writes:
>>
>> > Commit 6f63904c8f3e ("sched: add a few helpers to wake up tasks on the
>> > current cpu") introduced this new function to the completion API that
>> > has not been documented yet.
>>
>> For a change like this, it is a really good idea to copy the author of
>> the original patch and others who were involved in it; I have added them
>> now.
>
> This really is a rather specialized thing -- not sure it makes sense to
> have in the document.
>
Hello Peter, thank you for your reply.
I agree that it is a rather specialized function, but in my opinion that
should not be a reason to exclude it from the documentation. Where do
you draw the line then? It is an exposed function from the API that can
be called like any other function from the API if the user requires that.
This one is by the way the only undocumented function from the completion
API.
Best regards,
Javier Carrasco
next prev parent reply other threads:[~2025-08-31 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-24 13:38 [PATCH v2] docs: scheduler: completion: Document complete_on_current_cpu() Javier Carrasco
2025-08-29 22:44 ` Jonathan Corbet
2025-08-30 19:07 ` Peter Zijlstra
2025-08-31 10:04 ` Javier Carrasco [this message]
2025-09-03 21:54 ` Andrei Vagin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DCGJ0S0C9ZZH.1IFDOEWH6YF2K@gmail.com \
--to=javier.carrasco.cruz@gmail.com \
--cc=avagin@google.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).