From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E31BB3446DA; Fri, 19 Dec 2025 18:56:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766170581; cv=none; b=rygjepJTgaw0EwLlFZIM9Sa/fBS7VbBG37NjcuQoWdOBNSRYMxiKKOmmRUzKK6RLOMpEvAOSetru0RBs/hJEck7mWrvDAPXfMcXqfuj1iXIYt/QwI+74r/O/Un+W6DDeJ3Sxn0sBwPQjY6xHAfyomECBf8spVwoFgCsXtLLz8+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766170581; c=relaxed/simple; bh=H5vBEz/fGW7h/aZhURbePRBeN0pwWNZ2soTjhqLboDU=; h=Mime-Version:Content-Type:Date:Message-Id:From:Subject:Cc:To: References:In-Reply-To; b=gXn/MmAO/S4zkxVFMpHoIriRHPsQUegqbSyW36Izt4zSJdNeDpv4uk3Zxmv9z5kW4FgsU/c6CceDfSj5U16pajDZ4F+tl8+44VLIXb1QZ8cG+MlpmBzS3Hzh3BEbMqaEJ57eJHITR3TLcIxe5uSSsmeBos169IRYfLnsmq0neEQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=BwdqPx0V; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="BwdqPx0V" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 515ADC1B20F; Fri, 19 Dec 2025 18:55:52 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 11BB76071D; Fri, 19 Dec 2025 18:56:17 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id E2D9B102F0BC0; Fri, 19 Dec 2025 19:56:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1766170574; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=xVLiT30rrzI+caALdQHc2M3O0nXczZJjjL/MlbRBpF4=; b=BwdqPx0VcpiDNIHSkTfo0mJ2lVV57ChAmcm97fpxB9S7YaKEaeX0eei/u9TpUUwjNwpT4a QdZuLk1hny96Sjk+jmb4fz/rl8spH5NG6C3uI5sNMQmpOP4jUfaeXTvubgWFKYAKZgv5T4 VJ4NvNaXZBWqtHdgYpzr02eTGSoxbI3WiD50hk8gCKIAlRwiI4KJ4auvLf2orvs3I+xfRR zUisWXnI63jPgBWsrS2lXbXGNufTrkTL3Z5guF/PFXvu3PgntL5XAOEkVQK101T3DFV+78 5rmFTXmAwZj/s+q8P2KrygdmacoQY8mYxrN6LZyDayyitDlOQg/ezjWzldXN6g== Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 19 Dec 2025 19:56:12 +0100 Message-Id: From: "Luca Ceresoli" Subject: Re: [PATCH RESEND v2 26/32] drm/vkms: Introduce config for connector EDID Cc: , , , , , To: "Louis Chauvet" , "Haneen Mohammed" , "Simona Vetter" , "Melissa Wen" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , , "Jonathan Corbet" X-Mailer: aerc 0.20.1 References: <20251029-vkms-all-config-v2-0-a49a2d4cba26@bootlin.com> <20251029-vkms-all-config-v2-26-a49a2d4cba26@bootlin.com> In-Reply-To: <20251029-vkms-all-config-v2-26-a49a2d4cba26@bootlin.com> X-Last-TLS-Session-Version: TLSv1.3 On Wed Oct 29, 2025 at 3:37 PM CET, Louis Chauvet wrote: > Allows configuration of EDID for each connector. > > Signed-off-by: Louis Chauvet > --- a/drivers/gpu/drm/vkms/vkms_config.h > +++ b/drivers/gpu/drm/vkms/vkms_config.h > +/** > + * vkms_config_connector_set_edid() - Set the EDID data for a connector > + * @connector_cfg: Connector configuration to modify > + * @edid: Pointer to the EDID data buffer > + * @len: Length of the EDID data > + * > + * If @len is 0, the EDID data will be cleared. If memory allocation fai= ls, ^ Adding "and @edid ignored" would be useful. > static int vkms_conn_get_modes(struct drm_connector *connector) > { > - int count; > + struct vkms_connector *vkms_connector =3D drm_connector_to_vkms_connect= or(connector); > + const struct drm_edid *drm_edid =3D NULL; > + int count =3D 0; > + struct vkms_config_connector *context =3D NULL; > + struct drm_device *dev =3D connector->dev; > + struct vkms_device *vkmsdev =3D drm_device_to_vkms_device(dev); > + struct vkms_config_connector *connector_cfg; > > - /* Use the default modes list from DRM */ > - count =3D drm_add_modes_noedid(connector, XRES_MAX, YRES_MAX); > - drm_set_preferred_mode(connector, XRES_DEF, YRES_DEF); > + vkms_config_for_each_connector(vkmsdev->config, connector_cfg) { > + if (connector_cfg->connector =3D=3D vkms_connector) > + context =3D connector_cfg; You can add a break statement here to avoid keeping on looping after the connector has been found. With the above two changes: Reviewed-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com