From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB2C32DC781; Fri, 19 Dec 2025 20:47:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766177273; cv=none; b=X8FKwmThNve3JgdVxOrYiVg9xwGd5peVPu2bZyJSd84hgV8JBstCRhJJ/IljdRChJfBybYeQX4eUf+HhkjOpUMLwh+hEP0ACTmM4PDKUaHgbIQHWkOAajmxUM+TbufeMx+ekgcxsUB4n8xvsNeVH3zLh4mGVxkVxHYrdaJ9C1OI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766177273; c=relaxed/simple; bh=3ibPb03/L+VTQdGfz0DVLh1JBNccwUeD2J8ekZodq3I=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=tX0mkwnuVbTS8ks6cQH5WVwCOJsqIRG+ppbbXCG765ioehjS4pEwp8XxghCfRaxi9SxP9wGCB6pqkb2aQC1Pg5ycAsAWGd1u9c9stdPl3T0zl1BBu0u1fnSJoac2dGM7kOsj2H4fcrhdgAF+CGlU4VS93K3SbVarGhkG53o41Vg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=OYGJsedu; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="OYGJsedu" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 70ACE1A22FA; Fri, 19 Dec 2025 20:47:49 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 4779A6071D; Fri, 19 Dec 2025 20:47:49 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id CE1F710AA98BF; Fri, 19 Dec 2025 21:47:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1766177264; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=9gXg0kbUoCzWmdPvs9+PPLPaMkPQe5hr/VAOAnA+F0s=; b=OYGJseduHQ8jtvy/DjtZHNn701lAfDiSE6OZKcVWe4UeL1q59fhq6w9j3Q9IV+lEQkcYx8 DZhIzQ8ZWDoFGm5ywfKjQna+9AQw3yNM/4U2YVLObQDXmuxX+tEXMQZGXHl5wV8g4vytdG McqpLNvjxAaE3WRewyV5s6qhM8RH1nJH0ucCrTFtEkVABwt4XlkqYVRYsM1idzZPuNqR7u tZ3Uw4cxKf6ZQ5Qbe5GbgrjKTkySOzONmS8R+RC4V3duh8m3EFKbTiTkEeBx7pbRc4QO0t yubsArcIyXn6GghzcPv9jmo2dyDdStwflEmntpX7NizGVUkPbRVs3bfgJfRjcA== Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 19 Dec 2025 21:47:42 +0100 Message-Id: Subject: Re: [PATCH RESEND v2 31/32] drm/vkms: Allow to hot-add connectors Cc: , , , , , To: "Louis Chauvet" , "Haneen Mohammed" , "Simona Vetter" , "Melissa Wen" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , , "Jonathan Corbet" From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20251029-vkms-all-config-v2-0-a49a2d4cba26@bootlin.com> <20251029-vkms-all-config-v2-31-a49a2d4cba26@bootlin.com> In-Reply-To: <20251029-vkms-all-config-v2-31-a49a2d4cba26@bootlin.com> X-Last-TLS-Session-Version: TLSv1.3 On Wed Oct 29, 2025 at 3:37 PM CET, Louis Chauvet wrote: > In order to allow creating dynamic connector, add the required > infrastructure in vkms_connector. > > Co-developed-by: Jos=C3=A9 Exp=C3=B3sito > Signed-off-by: Jos=C3=A9 Exp=C3=B3sito > [Louis Chauvet: use drm_atomic_helper_connector_reset instead of > drm_mode_config_reset because connector is not yet registered] > Signed-off-by: Louis Chauvet > --- a/drivers/gpu/drm/vkms/vkms_connector.h > +++ b/drivers/gpu/drm/vkms/vkms_connector.h > @@ -34,4 +34,36 @@ struct vkms_connector *vkms_connector_init_static(stru= ct vkms_device *vkmsdev, > */ > void vkms_trigger_connector_hotplug(struct vkms_device *vkmsdev); > > +/** > + * vkms_connector_hot_add() - Create a connector after the device is cre= ated > + * @vkmsdev: Device to hot-add the connector to > + * @connector_cfg: Connector's configuration > + * > + * Returns: > + * The connector or an error on failure. "A pointer to the newly created connector or a PTR_ERR on failure." > + */ > +struct vkms_connector *vkms_connector_hot_add(struct vkms_device *vkmsde= v, > + struct vkms_config_connector *connector_cfg); > + > +/** > + * vkms_connector_hot_remove() - Remove a connector after a device is cr= eated Missing kdoc for @vkmsdev: @vkmsdev: Device to containing the connector to be removed > + * @connector: The connector to hot-remove > + */ > +void vkms_connector_hot_remove(struct vkms_device *vkmsdev, > + struct vkms_connector *connector); With these changes: Reviewed-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com