From: "Kaustabh Chakraborty" <kauschluss@disroot.org>
To: "Krzysztof Kozlowski" <krzk@kernel.org>,
"Kaustabh Chakraborty" <kauschluss@disroot.org>
Cc: "Lee Jones" <lee@kernel.org>, "Pavel Machek" <pavel@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"MyungJoo Ham" <myungjoo.ham@samsung.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Sebastian Reichel" <sre@kernel.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Nam Tran" <trannamatk@gmail.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 04/13] dt-bindings: power: supply: document Samsung S2M series PMIC charger device
Date: Fri, 27 Feb 2026 19:56:58 +0530 [thread overview]
Message-ID: <DGPTBRX09EU5.1D1ZSR7EUV7AT@disroot.org> (raw)
In-Reply-To: <20260225-secret-amusing-cuttlefish-d3bee5@quoll>
On 2026-02-25 11:44 +01:00, Krzysztof Kozlowski wrote:
> On Wed, Feb 25, 2026 at 12:45:06AM +0530, Kaustabh Chakraborty wrote:
>> +
>> + This is a part of device tree bindings for S2M and S5M family of Power
>> + Management IC (PMIC).
>> +
>> + See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml for
>> + additional information and example.
>> +
>> +allOf:
>> + - $ref: power-supply.yaml#
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - samsung,s2mu005-charger
>
> Review from v1 still applies. I think you ignored several reviews, so I
> will mark entire patchset as changes requested.
Somehow I missed this one... anyways I address them here:
Why do you need a dedicated child node for this? It's got one property,
other than the compatible, that you're using. It could easily just go
in the parent without a dedicated node etc.
The dt node also references a simple-battery node, that's why it's
required.
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2026-02-27 14:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 19:15 [PATCH v3 00/13] Support for Samsung S2MU005 PMIC and its sub-devices Kaustabh Chakraborty
2026-02-24 19:15 ` [PATCH v3 01/13] dt-bindings: leds: document Samsung S2M series PMIC flash LED device Kaustabh Chakraborty
2026-02-24 19:15 ` [PATCH v3 02/13] dt-bindings: leds: document Samsung S2M series PMIC RGB " Kaustabh Chakraborty
2026-02-24 19:15 ` [PATCH v3 03/13] dt-bindings: extcon: document Samsung S2M series PMIC extcon device Kaustabh Chakraborty
2026-02-27 15:11 ` Kaustabh Chakraborty
2026-02-24 19:15 ` [PATCH v3 04/13] dt-bindings: power: supply: document Samsung S2M series PMIC charger device Kaustabh Chakraborty
2026-02-25 10:44 ` Krzysztof Kozlowski
2026-02-27 14:26 ` Kaustabh Chakraborty [this message]
2026-03-06 0:50 ` Rob Herring
2026-03-08 12:13 ` Kaustabh Chakraborty
2026-02-24 19:15 ` [PATCH v3 05/13] dt-bindings: mfd: s2mps11: add documentation for S2MU005 PMIC Kaustabh Chakraborty
2026-02-24 19:15 ` [PATCH v3 06/13] mfd: sec: add support " Kaustabh Chakraborty
2026-02-24 19:15 ` [PATCH v3 07/13] mfd: sec: set DMA coherent mask Kaustabh Chakraborty
2026-03-06 7:03 ` André Draszik
2026-02-24 19:15 ` [PATCH v3 08/13] mfd: sec: resolve PMIC revision in S2MU005 Kaustabh Chakraborty
2026-02-24 19:15 ` [PATCH v3 09/13] leds: flash: add support for Samsung S2M series PMIC flash LED device Kaustabh Chakraborty
2026-03-10 11:38 ` Lee Jones
2026-03-13 20:33 ` Kaustabh Chakraborty
2026-03-25 14:58 ` Lee Jones
2026-02-24 19:15 ` [PATCH v3 10/13] leds: rgb: add support for Samsung S2M series PMIC RGB " Kaustabh Chakraborty
2026-03-10 11:48 ` Lee Jones
2026-02-24 19:15 ` [PATCH v3 11/13] Documentation: leds: document pattern behavior of Samsung S2M series PMIC RGB LEDs Kaustabh Chakraborty
2026-02-24 19:15 ` [PATCH v3 12/13] extcon: add support for Samsung S2M series PMIC extcon devices Kaustabh Chakraborty
2026-02-24 19:15 ` [PATCH v3 13/13] power: supply: add support for Samsung S2M series PMIC charger device Kaustabh Chakraborty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGPTBRX09EU5.1D1ZSR7EUV7AT@disroot.org \
--to=kauschluss@disroot.org \
--cc=alexandre.belloni@bootlin.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=sre@kernel.org \
--cc=trannamatk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox