From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0AD8186E58; Sun, 8 Mar 2026 12:13:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772972041; cv=none; b=DueR3ubEq0LlLcQQnRfBF886q/hcnuD4FKGC+DB32GLdsZDAJcUop7R6NmK/5VvaNkLFN2YpEx7L74YwJTPrRyaPjJI3yVucJJIieVQvMe751pMf53a2GCFFE6iM/UjRHidVxl02XyZt+5FYqyJmOSmFLm1igT5SBQ47TSPdXd0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772972041; c=relaxed/simple; bh=KlM4hl1KhneCR8S8wwL3AsgMH81tqTiQtLEzLpcTFB8=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=SBsPfs4FrCayHhapXCVBQUEDjxEmog6qY4Wwwq/F9gdQCiA/Ga5aaO5K9se67+cr2Wn4tpxnZ6PIduqC0SmUXXpjgqRHcGcgAkCeOPzJdb1/VzqLdr8zadmfUXCkM7icEulraJ50qj+XPYs7Lo4w5t3K6j7sgGvGPVXr4LlhiMA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=KyjIBFlh; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="KyjIBFlh" Received: from [127.0.0.1] (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id DDFE326EFE; Sun, 8 Mar 2026 13:13:49 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 0qODxsH7oPNB; Sun, 8 Mar 2026 13:13:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1772972029; bh=KlM4hl1KhneCR8S8wwL3AsgMH81tqTiQtLEzLpcTFB8=; h=Date:Cc:Subject:From:To:References:In-Reply-To; b=KyjIBFlhaggFLByg0qYTM3R9UKdLN4gTJoVWxYMGCTO1AiAcHGG3puAma8c7K7iBm P9ZyoJYeYwgWy6noq0JJD18uvLOh1I1iPAvkF2IpxFmh2brEhVsF3antyOKShJKK8J UynPrM1MMQsLSkCEdxnvBxfyvZZhaMkW/FFMd/Zlvm3vkvzURROeTGX9bkw41grD8d xzFD2lu6n52eR3qGpUMPs8Xh0CKIVtObiwABALQnVhItYrEb3+6lL4ZTEXP4mt7ZNI m0G0IFI8jwnlkexuJbdlCb50yBqBShATich6U79uyfer27E0ydBBFrHKr+KXUVf+F9 39sDGFV1tNhcA== Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 08 Mar 2026 17:43:34 +0530 Message-Id: Cc: "Krzysztof Kozlowski" , "Lee Jones" , "Pavel Machek" , "Krzysztof Kozlowski" , "Conor Dooley" , "MyungJoo Ham" , "Chanwoo Choi" , "Sebastian Reichel" , =?utf-8?q?Andr=C3=A9_Draszik?= , "Alexandre Belloni" , "Jonathan Corbet" , "Shuah Khan" , "Nam Tran" , , , , , , , Subject: Re: [PATCH v3 04/13] dt-bindings: power: supply: document Samsung S2M series PMIC charger device From: "Kaustabh Chakraborty" To: "Rob Herring" , "Kaustabh Chakraborty" References: <20260225-s2mu005-pmic-v3-0-b4afee947603@disroot.org> <20260225-s2mu005-pmic-v3-4-b4afee947603@disroot.org> <20260225-secret-amusing-cuttlefish-d3bee5@quoll> <20260306005057.GA877725-robh@kernel.org> In-Reply-To: <20260306005057.GA877725-robh@kernel.org> On 2026-03-05 18:50 -06:00, Rob Herring wrote: > On Fri, Feb 27, 2026 at 07:56:58PM +0530, Kaustabh Chakraborty wrote: >> On 2026-02-25 11:44 +01:00, Krzysztof Kozlowski wrote: >> > On Wed, Feb 25, 2026 at 12:45:06AM +0530, Kaustabh Chakraborty wrote: >> >> + >> >> + This is a part of device tree bindings for S2M and S5M family of P= ower >> >> + Management IC (PMIC). >> >> + >> >> + See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yam= l for >> >> + additional information and example. >> >> + >> >> +allOf: >> >> + - $ref: power-supply.yaml# >> >> + >> >> +properties: >> >> + compatible: >> >> + enum: >> >> + - samsung,s2mu005-charger >> > >> > Review from v1 still applies. I think you ignored several reviews, so = I >> > will mark entire patchset as changes requested. >>=20 >> Somehow I missed this one... anyways I address them here: >>=20 >> Why do you need a dedicated child node for this? It's got one property= , >> other than the compatible, that you're using. It could easily just go >> in the parent without a dedicated node etc. >>=20 >> The dt node also references a simple-battery node, that's why it's >> required. > > That can go in the parent. So the parent MFD has the following? allOf: - $ref: power-supply.yaml# I'm kind of not sold on this one. Moreover, I was planning to introduce a port to/from the MUIC in the next revision so that would've been included here too. > > Rob