From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84B29274B5F; Sun, 17 May 2026 13:10:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779023405; cv=none; b=AL3hYA7EPWqNmMm2sk64GSy1NhnZe3LustAGKqUu8u2g1zzVOMz6ROlWa7ntk8ABNyHMKjDCiCmLrA74lMON5K7J0QQ6NcWMOijOumYCQJbK48jttD2xWjukVj/Lu/z9rqH+7noLs08WLo12DSC33dcFlwWxaADvxyFgvY3B2Zs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779023405; c=relaxed/simple; bh=VmZO8wUns6Rzp7QhfWBpX9OW3ArS21uLigpWw23RVe0=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=rqgnPmNUVunzPPD6m/WtJ4hmJwa4Qf1akVyMd6N/IQgRLPLnZC+imuSeSqhCwvKO2yG3+LrGSpXJM3OFvChkH3ZfFW+sT3JFTLKQDPal1rZtuevrLZdSiRkFQd4HW+f4XVF+WAehgkjGnVDW6gao6t18YlPIcOB7csX+pwSWDO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=S38s4N/3; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="S38s4N/3" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id AF548270F3; Sun, 17 May 2026 15:09:52 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id iz7bdltAi84y; Sun, 17 May 2026 15:09:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1779023391; bh=VmZO8wUns6Rzp7QhfWBpX9OW3ArS21uLigpWw23RVe0=; h=Date:To:Cc:Subject:From:References:In-Reply-To; b=S38s4N/3j/FiziIop4tsq8NahUewcH98fRM7YKQifUrAWbDncqY8LWkCTRCMS9UkI rpGjuV6ZjZ+5DJWl++KMcRG114tis08jxDUBOVxqqZIdy2IKEDddBiaxZM0uCadrE7 HPVpyotSRXNTvouCqX51foNX17f8gXA65NemsiKM5MWGWMwfdX/5r6KGZI9kk1MTK1 VR7w6C9N28B6bCaOnhSuCguWzs2BP+cJLTDNuiidp99hi4+UZpWzFj18L/O+cF+AkJ fWeCm2tIA9IFEEe8y7mK14ZjZsvR7kPTwr2vREd/jjvesnMF66Tt2ICMHbcLOFr9sw iLIx2voOesDAw== Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 17 May 2026 18:39:37 +0530 Message-Id: To: "Conor Dooley" , "Kaustabh Chakraborty" Cc: "Lee Jones" , "Pavel Machek" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "MyungJoo Ham" , "Chanwoo Choi" , "Sebastian Reichel" , "Krzysztof Kozlowski" , =?utf-8?q?Andr=C3=A9_Draszik?= , "Alexandre Belloni" , "Jonathan Corbet" , "Shuah Khan" , "Nam Tran" , =?utf-8?q?=C5=81ukasz_Lebiedzi=C5=84ski?= , , , , , , , Subject: Re: [PATCH v6 03/11] dt-bindings: mfd: add documentation for S2MU005 PMIC From: "Kaustabh Chakraborty" References: <20260515-s2mu005-pmic-v6-0-1979106992d4@disroot.org> <20260515-s2mu005-pmic-v6-3-1979106992d4@disroot.org> <20260515-justly-recite-6028f4bfb24a@spud> <20260516-esquire-chitchat-0fffa597e2f3@spud> In-Reply-To: <20260516-esquire-chitchat-0fffa597e2f3@spud> On 2026-05-16 23:25 +01:00, Conor Dooley wrote: > On Sat, May 16, 2026 at 02:41:29AM +0530, Kaustabh Chakraborty wrote: >> On 2026-05-15 18:14 +01:00, Conor Dooley wrote: >> > On Fri, May 15, 2026 at 04:08:59PM +0530, Kaustabh Chakraborty wrote: >> >> Samsung's S2MU005 PMIC includes subdevices for a charger, an MUIC (Mi= cro >> >> USB Interface Controller), and flash and RGB LED controllers. >> >>=20 >> >> Add the compatible and documentation for the S2MU005 PMIC. Also, add = an >> >> example for nodes for supported sub-devices, i.e. MUIC, flash LEDs, a= nd >> >> RGB LEDs. Charger sub-device uses the node of the parent. >> >>=20 >> >> Signed-off-by: Kaustabh Chakraborty >> >> --- >> >> .../bindings/mfd/samsung,s2mu005-pmic.yaml | 120 +++++++++++= ++++++++++ >> >> 1 file changed, 120 insertions(+) >> >>=20 >> >> diff --git a/Documentation/devicetree/bindings/mfd/samsung,s2mu005-pm= ic.yaml b/Documentation/devicetree/bindings/mfd/samsung,s2mu005-pmic.yaml >> >> new file mode 100644 >> >> index 0000000000000..0e6afb7d2017b >> >> --- /dev/null >> >> +++ b/Documentation/devicetree/bindings/mfd/samsung,s2mu005-pmic.yaml >> >> @@ -0,0 +1,120 @@ >> >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> >> +%YAML 1.2 >> >> +--- >> >> +$id: http://devicetree.org/schemas/mfd/samsung,s2mu005-pmic.yaml# >> >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> >> + >> >> +title: Samsung S2MU005 Power Management IC >> >> + >> >> +maintainers: >> >> + - Kaustabh Chakraborty >> >> + >> >> +description: | >> >> + The S2MU005 is a companion power management IC which includes subd= evices for >> >> + a charger controller, an MUIC (Micro USB Interface Controller), an= d flash and >> >> + RGB LED controllers. >> >> + >> >> +allOf: >> >> + - $ref: /schemas/power/supply/power-supply.yaml# >> >> + >> >> +properties: >> >> + compatible: >> >> + const: samsung,s2mu005-pmic >> >> + >> >> + flash: >> >> + $ref: /schemas/leds/samsung,s2mu005-flash.yaml >> >> + description: >> >> + Child node describing flash LEDs. >> >> + >> >> + interrupts: >> >> + maxItems: 1 >> >> + >> >> + muic: >> >> + $ref: /schemas/extcon/samsung,s2mu005-muic.yaml# >> >> + description: >> >> + Child node describing MUIC device. >> >> + >> >> + multi-led: >> >> + type: object >> >> + >> >> + allOf: >> >> + - $ref: /schemas/leds/leds-class-multicolor.yaml# >> > >> > Does this need to be an allOf when the other refs are not? >>=20 >> It has it's own properties, that's the reason. This used to be it's own >> thing in dt-bindings/leds, but I was asked to move it here in prior >> reviews. > > What do you mean by "its own properties"? I mean, the other schemas (muic, flash) are in their own file, with compatible, and other properties too. This one, inherits properties from leds-class-multicolor, AND has a "compatible" property with it, which is not defined in leds-class-multicolor. Now if you ask why does the compatible exist, that's something Krzysztof suggested in previous revisions. And, Krzysztof had also reviewed this patch, and (similar to the prev patch) I've missed the trailers, which have been addressed in v7 now. >>=20 >> >> + >> >> + properties: >> >> + compatible: >> >> + const: samsung,s2mu005-rgb >> >> + >> >> + required: >> >> + - compatible >> >> + >> >> + unevaluatedProperties: false >> >> + >> >> + reg: >> >> + maxItems: 1 >> > >> > Move this above the child nodes please. >>=20 >> But properties are sorted in lex order? > > Typically the binding is sorted in the same order as properties go in > nodes. Common stuff like reg/clocks/interrupts therefore send up above > child nodes. So, do I change this? For one, I don't see the same being followed in other schemas of samsung in the same dir (not that I'm trying to pose it as an argument against your suggestion), and this was reviewed by Krzysztof and is adderssed in v7.