Linux Documentation
 help / color / mirror / Atom feed
From: "Troy Mitchell" <troy.mitchell@linux.dev>
To: "Troy Mitchell" <troy.mitchell@linux.dev>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Paul Walmsley" <pjw@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>, "Yixun Lan" <dlan@kernel.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Shuah Khan" <skhan@linuxfoundation.org>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-hwmon@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
	<spacemit@lists.linux.dev>, <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v2 5/6] riscv: dts: spacemit: Add K3 I2C6 pinctrl state
Date: Tue, 21 Jul 2026 04:52:34 -0700	[thread overview]
Message-ID: <DK488087JL3G.2007ORR9MUHGW@linux.dev> (raw)
In-Reply-To: <20260721100039.0E6A41F00A3A@smtp.kernel.org>

On Tue, Jul 21, 2026 at 10:00:38AM +0000, sashiko-bot@kernel.org wrote:
> [Severity: Low]
> Is this drive-strength value supported by the binding? The value 18
> doesn't appear to be valid according to the SpacemiT K3 pinctrl binding
> schema (spacemit,k1-pinctrl.yaml), which triggers a dtbs_check validation
> failure.
>
> Since the driver's spacemit_get_ds_value() will silently fall back to the
> next highest valid value (like 21mA or 25mA depending on voltage), could
> this cause an unexpected mismatch between the requested devicetree state
> and the actual hardware configuration?

Good catch. This pin group uses the 3.3 V power domain, for which 18 mA is
not a valid K3 drive-strength value. The driver rounds that request up to
25 mA, so I will use 25 mA in the devicetree to describe the configuration
that is actually programmed and to satisfy the binding.

                                            - Troy

  parent reply	other threads:[~2026-07-21 11:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21  9:48 [PATCH v2 0/6] hwmon: (lm63) Add Sensylink CTF2301 support Troy Mitchell
2026-07-21  9:48 ` [PATCH v2 1/6] dt-bindings: vendor-prefixes: Add Sensylink Troy Mitchell
2026-07-21 15:49   ` Conor Dooley
2026-07-21 17:56     ` Guenter Roeck
2026-07-21  9:48 ` [PATCH v2 2/6] dt-bindings: hwmon: Move LM63 family to a dedicated binding Troy Mitchell
     [not found]   ` <20260721095822.1E9631F000E9@smtp.kernel.org>
2026-07-21 11:38     ` Troy Mitchell
2026-07-21  9:48 ` [PATCH v2 3/6] dt-bindings: hwmon: Add Sensylink CTF2301 Troy Mitchell
2026-07-21 15:46   ` Conor Dooley
2026-07-21  9:48 ` [PATCH v2 4/6] hwmon: (lm63) Add Sensylink CTF2301 support Troy Mitchell
     [not found]   ` <20260721100004.D93AC1F000E9@smtp.kernel.org>
2026-07-21 11:52     ` Troy Mitchell
2026-07-21  9:48 ` [PATCH v2 5/6] riscv: dts: spacemit: Add K3 I2C6 pinctrl state Troy Mitchell
     [not found]   ` <20260721100039.0E6A41F00A3A@smtp.kernel.org>
2026-07-21 11:52     ` Troy Mitchell [this message]
2026-07-21  9:48 ` [PATCH v2 6/6] riscv: dts: spacemit: Add CTF2301 on K3 CoM260 Troy Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DK488087JL3G.2007ORR9MUHGW@linux.dev \
    --to=troy.mitchell@linux.dev \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux@roeck-us.net \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox