From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy2-f12.google.com (mail-dy2-f12.google.com [74.125.229.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA7345326B9 for ; Tue, 22 Sep 2026 22:57:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.229.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790117844; cv=none; b=gFJyuFHjQLDut9N9qqWz0Wt1g3Ezk00CBb5SMlmuuATh87auZ6tUlUK573nHeUARbkLt6EBnKs3zFkwi3+bLK75duyAHSAe9sDxrKWeEeMtlfUn19mLh/uUrgmUTngkH6l5llJ/Ep0c/sFmozZyIuwBVOgwg6kDgahPGQ/T28qw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790117844; c=relaxed/simple; bh=MlvWhc27/Wnf3UCEBSDCmF0Yz4ceH7CgS4IWEcLi5ps=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=thZAB0oV2A1Qmw92G3BgoPruWL/IT0oDJgnJ/MYnCnpjil3dfcaujufi80ya+bYH6NC3z5WDx1/IFkVUtg+FEPvhf9g5Gs57Mk/4gIn3w8jvAG0oXMh6GcU7aRWirQukZLUQcXACiq/Xm0MaW6n+AtqHecTyWn6I4zKL6kjSkjg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=begyv8G6; arc=none smtp.client-ip=74.125.229.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="begyv8G6" Received: by mail-dy2-f12.google.com with SMTP id 5a478bee46e88-328664dbdd2so107554eec.1 for ; Tue, 22 Sep 2026 15:57:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790117836; x=1790722636; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=aTPRvJvF/abYMEvNmlO3pHSl3zMEUYZicwYugH3SZJ0=; b=begyv8G6XJ/FzFdJuULE8br5tO1zsKNxSKio2GXNGp3dIV9hb9stcfr4ywXNyFJX/s YF+QXM3bXQltqABrbQoYNW96qG1i1b0kGQkP+kCLIebmoqibk2s3eic4FrBRgvHFRH0n 1oc3l/uVcduHcR/cmTih1GhuhAjWQi+ej8VCCmndmWZO1aLrSxqegbLM4icqJZEZ4sIX XpbfONxu+hg85oHYIHhd0KALNi2rC5QPlAEeo/embF2vXIlBRRMLTym5D0lH/POVQ1op 2TPcoVn4bVZLkuZp/8MK+vQkkdd59ANOnT3PGRK2dfPoAF9LRQYkzpt/Dyz7OgYjVp4H czCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790117836; x=1790722636; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aTPRvJvF/abYMEvNmlO3pHSl3zMEUYZicwYugH3SZJ0=; b=OZ5S0VXqyKwPQdrsIecV6HEWL8RJTTzu0IEvUCLlTo3i9sHZ2RMZUYLHfJA+PCTfGf oEbtcUQKPV7kFcDYgcy2PK/0JCGDlOdAWttHTQmf0W0bipRNQEEhp4D8PaJh3tXu3R/f TP7D95I3KwqmaGA6St6m9CKhKYGzJ5+SQrtBzI4h2pPf6HNsRKK3pY6rimQKVK6vSZYo FR8e74fIi9cu/VMCgSzbxa6Wtoup7oAS7k6X3zu6UEdOXQgg6tF6N5K1pK3Q3cr0OQ7q q0VrQxapAjebxqYVhcINZ7I2e62BiJWtKuCFmB3VRYKKAb/wnF0X6W67mx8uJeTdGzpy dvgQ== X-Forwarded-Encrypted: i=1; AKwUvByBIwX1/ra7UXN6cGjeNrzypDZIbvQKUCIpZ93eFDQeQDgZ240zSWs3DvwjNBKUjuawGm+HN892P/c=@vger.kernel.org X-Gm-Message-State: AFuF++mxdcHcuSccPlI3Jc9mwwFa84l5Ryy+gSqgWKysIyXOaqaNbkTO 2RSd13dijGHP5NlWb9bBkSbTo9mkh+huSt518VEwlLtxLOkecs7kUOJa X-Gm-Gg: AYBFou0+Kzzu4g3/X8rHvmCN+EMO6TgZLJAd2txNybnPVEqo0qB7gYOwIjDgJEwvFmz n0sebX2Nr2JM7wHlJzazUv6GkWvVQ7rJtl6zbO43Hh1elQOfa+kzQtoEJmSytpUrdp14W55r3UM ZV56bEaQ25abVYw8c/C/06pWxCvwAHgNBsPuASuZRuqwj9N/XuHeyj8RSj8TLoyWpa9M7coqLeT lAVyuVX+wJKbCH7jM7bzwBIYy6upDsl+8Mtp1yGb6s9zp2n/uwNxBK/Nyk59cXLI1TzYPDG6Gyn IOROOIeCDDMpkNkSesMoeKbpIdpx7GbtLQa26PRhcbiS2p5Z2eWnA+T9fIHEmFKGn32Ir0pswEN Hyn8Js4+gLf4qjFH9LC/VmSiCYmqsngojpyub1O80hlFFWnjKf8ExnjwId2TgrQrXl9uMYmUwQ3 1zR0r3c0KrC/EOx9ycuLdzE1QDSVGpA9eV5A5/XaRdALp4toHPmd1MM5P/w36Kh4gbij8jr7p/z IVJH8kgazuHCLwZ5jLAinKhrA== X-Received: by 2002:a05:7300:b0d:b0:33b:f3ea:db21 with SMTP id 5a478bee46e88-33e7a2d8a2emr903397eec.4.1790117836248; Tue, 22 Sep 2026 15:57:16 -0700 (PDT) Received: from localhost ([13.93.150.60]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33e96d497e1sm1241801eec.25.2026.09.22.15.57.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Sep 2026 15:57:15 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 22 Sep 2026 22:57:14 +0000 Message-Id: Cc: , , , , , , , , , , , , , , , , , Subject: Re: [PATCH net-next v3 1/2] ipv6: update NUD_FAILED neighbors from NA messages From: "Lawrence Lee" To: X-Mailer: aerc 0.17.0 References: <179011667864.2160803.5487538537038042784@kernel.org> In-Reply-To: <179011667864.2160803.5487538537038042784@kernel.org> On Tue Sep 22, 2026 at 10:37 PM UTC, wrote: > [Severity: Low] > This isn't a bug, but a note on test coverage for the new FAILED branch i= n > ndisc_recv_na(). > > At the time this patch is applied on its own, the in-tree selftests only > walk the "absent entry" rows of the matrix: the matrix comment in > tools/testing/selftests/net/ndisc_unsolicited_na_test.sh and verify_ndisc= () > start from an empty neighbor cache, and arp_ndisc_untracked_subnets.sh do= es > the same for the accept=3D2 subnet rule. That leaves the new > > if (!neigh || (READ_ONCE(neigh->nud_state) & NUD_FAILED)) { > > path, and the FAILED rows now documented for accept_untracked_na, without= a > test. > > This is addressed later in the same series by "selftests: net: test > untracked NA recovery of FAILED neighbors", which extends the matrix > comment in ndisc_unsolicited_na_test.sh with the six "failed" rows, adds > initial_state/same_subnet parameters to verify_ndisc() and > test_unsolicited_na_common() that seed the entry with > > ip neigh replace ${HOST_ADDR} dev ${ROUTER_INTF} nud failed extern_learn > > and then adds cases for accept=3D1, accept=3D0, forwarding=3D0, drop=3D1 = and both > in-prefix and out-of-prefix accept=3D2, checking that the lladdr is learn= ed > for the STALE rows and absent for the rows that must stay FAILED. So the > gap exists only for this commit in isolation, not for the final state of > the series. > > Would it be worth mentioning the follow-up selftest patch in this commit > message so the coverage relationship is visible when this commit is read > alone? The cover letter already mentions that tests are added in a separate=20 patch in this series. I'm not aware of any precedent or convention to=20 mention follow-up selftest patches in commit messages for earlier=20 patches in the series.=20