From: "Kani, Toshi" <toshi.kani@hpe.com>
To: Justin He <Justin.He@arm.com>, Borislav Petkov <bp@alien8.de>
Cc: Len Brown <lenb@kernel.org>, James Morse <James.Morse@arm.com>,
Tony Luck <tony.luck@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
"Robert Richter" <rric@kernel.org>,
Robert Moore <robert.moore@intel.com>,
Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
Yazen Ghannam <yazen.ghannam@amd.com>,
"Jonathan Corbet" <corbet@lwn.net>,
Jan Luebbe <jlu@pengutronix.de>,
Khuong Dinh <khuong@os.amperecomputing.com>,
Ard Biesheuvel <ardb@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"devel@acpica.org" <devel@acpica.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Shuai Xue <xueshuai@linux.alibaba.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
nd <nd@arm.com>, "Paul E. McKenney" <paulmck@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Neeraj Upadhyay <quic_neeraju@quicinc.com>,
Randy Dunlap <rdunlap@infradead.org>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Muchun Song <songmuchun@bytedance.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"stable@kernel.org" <stable@kernel.org>
Subject: RE: [RESEND PATCH v3 3/9] EDAC/ghes: Make ghes_edac a proper module to remove the dependency on ghes
Date: Fri, 26 Aug 2022 19:30:19 +0000 [thread overview]
Message-ID: <DM4PR84MB185308834381DD3316D506A782759@DM4PR84MB1853.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <DBBPR08MB45384B8C447B9B4B29D07011F7729@DBBPR08MB4538.eurprd08.prod.outlook.com>
On Thursday, August 25, 2022 6:21 AM, Justin He wrote:
> > > @@ -566,3 +549,35 @@ void ghes_edac_unregister(struct ghes *ghes)
> > > unlock:
> > > mutex_unlock(&ghes_reg_mutex);
> > > }
> > > +
> > > +static int __init ghes_edac_init(void) {
> > > + struct ghes *g, *g_tmp;
> > > +
> > > + if (!IS_ENABLED(CONFIG_X86))
> > > + force_load = true;
> >
> > No, this is not how this works.
> >
> > > + ghes_devs = ghes_get_devices(force_load);
> > > + if (!ghes_devs)
> > > + return -ENODEV;
> >
> > You simply need to check force_load here.
> >
>
> Okay, hence should I export the *ghes_devs* in ghes?
It does not matter. This series then moves the force_load check
to ghes_edac_preferred(). It is confusing for reviewers...
Please divide patches based on the final design.
Toshi
next prev parent reply other threads:[~2022-08-26 19:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 15:40 [RESEND PATCH v3 0/9] Make ghes_edac a proper module Jia He
2022-08-22 15:40 ` [RESEND PATCH v3 1/9] efi/cper: export several helpers for ghes_edac to use Jia He
2022-08-22 15:40 ` [RESEND PATCH v3 2/9] EDAC/ghes: Add a notifier for reporting memory errors Jia He
2022-08-22 15:40 ` [RESEND PATCH v3 3/9] EDAC/ghes: Make ghes_edac a proper module to remove the dependency on ghes Jia He
2022-08-24 15:37 ` Borislav Petkov
2022-08-25 12:21 ` Justin He
2022-08-26 19:30 ` Kani, Toshi [this message]
2022-08-26 22:42 ` Elliott, Robert (Servers)
2022-08-27 5:22 ` Borislav Petkov
2022-08-29 15:59 ` Yazen Ghannam
2022-08-29 20:39 ` Borislav Petkov
2022-08-29 21:37 ` Kani, Toshi
2022-08-22 15:40 ` [RESEND PATCH v3 4/9] EDAC/ghes: Move ghes_edac.force_load to setup parameter Jia He
2022-08-24 15:52 ` Borislav Petkov
2022-08-25 9:42 ` Justin He
2022-08-30 1:21 ` Justin He
2022-08-22 15:40 ` [RESEND PATCH v3 5/9] EDAC: Don't load chipset-specific edac drivers when ghes_edac is preferred Jia He
2022-08-24 23:04 ` Kani, Toshi
2022-08-25 9:45 ` Justin He
2022-08-25 23:38 ` Kani, Toshi
2022-08-22 15:40 ` [RESEND PATCH v3 6/9] ghes: Introduce a flag ghes_present Jia He
2022-08-22 15:40 ` [RESEND PATCH v3 7/9] apei/ghes: Use unrcu_pointer for cmpxchg Jia He
2022-08-22 15:40 ` [RESEND PATCH v3 8/9] EDAC/igen6: Keep returned errno consistent when edac mc has been enabled Jia He
2022-08-22 15:40 ` [RESEND PATCH v3 9/9] edac: Don't load Arm specific edac drivers when ghes_edac is preferred Jia He
2022-08-23 1:49 ` [RESEND PATCH v3 0/9] Make ghes_edac a proper module Justin He
2022-08-23 17:19 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR84MB185308834381DD3316D506A782759@DM4PR84MB1853.NAMPRD84.PROD.OUTLOOK.COM \
--to=toshi.kani@hpe.com \
--cc=James.Morse@arm.com \
--cc=Justin.He@arm.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=damien.lemoal@opensource.wdc.com \
--cc=devel@acpica.org \
--cc=jarkko@kernel.org \
--cc=jlu@pengutronix.de \
--cc=khuong@os.amperecomputing.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nd@arm.com \
--cc=paulmck@kernel.org \
--cc=qiuxu.zhuo@intel.com \
--cc=quic_neeraju@quicinc.com \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=robert.moore@intel.com \
--cc=rric@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=stable@kernel.org \
--cc=tony.luck@intel.com \
--cc=xueshuai@linux.alibaba.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox