From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: "Sasha Levin" <sashal@kernel.org>
Cc: <workflows@vger.kernel.org>, <ksummit@lists.linux.dev>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Mark Brown" <broonie@kernel.org>,
"Theodore Ts'o" <tytso@mit.edu>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Leon Romanovsky" <leon@kernel.org>,
"Konstantin Ryabitsev" <konstantin@linuxfoundation.org>,
"Thorsten Leemhuis" <linux@leemhuis.info>,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v2 4/5] agents: add a skill to find other instances of a fixed bug
Date: Fri, 16 Oct 2026 18:24:13 +0000 [thread overview]
Message-ID: <DM6H19P1797J.2QYZAQAOI9FTN@gmail.com> (raw)
In-Reply-To: <atJnq_ssIAGK-OSZ@laps>
On Fri, Oct 16, 2026 at 02:06 PM Sasha Levin <sashal@kernel.org> wrote:
> What I had in mind was the kind of bug our scripts/coccinelle/ rules look for.
For kfree_mismatch.cocci kind, yes. Each site is its own bug.
But the other example in the guide is "a missing put when leaving a loop".
That's iterators/for_each_child.cocci. It was fixed one driver at a time
for years until for_each_child_of_node_scoped() made the put automatic.
> I agree that fixing the interface is better, but do we want to push all these
> agents there?
To report it, yes. The skill is read-only anyway.
Whether to change the interface is for the human to decide.
> So I think it should be a balance. When the skill finds the same defect
> in several places, it should also ask whether the interface invites the
> mistake, and if so report that the fix belongs there instead of handing
> back a list for N maintainers
Makes sense to me.
next prev parent reply other threads:[~2026-10-16 18:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 21:34 [PATCH v2 0/5] agents: add skills for Fixes tags, stable tags, similar bugs, and commit messages Sasha Levin
2026-10-12 21:34 ` [PATCH v2 1/5] agents: add infrastructure for agent resources Sasha Levin
2026-10-12 21:34 ` [PATCH v2 2/5] agents: add a skill to determine Fixes tags Sasha Levin
2026-10-13 3:55 ` Kees Cook
2026-10-13 4:42 ` Michael S. Tsirkin
2026-10-15 8:03 ` Dan Carpenter
2026-10-12 21:34 ` [PATCH v2 3/5] agents: add a skill to determine stable tags Sasha Levin
2026-10-13 3:59 ` Kees Cook
2026-10-13 11:30 ` Sasha Levin
2026-10-12 21:34 ` [PATCH v2 4/5] agents: add a skill to find other instances of a fixed bug Sasha Levin
2026-10-13 4:02 ` Kees Cook
2026-10-13 11:14 ` Sasha Levin
2026-10-16 15:58 ` Alexei Starovoitov
2026-10-16 18:06 ` Sasha Levin
2026-10-16 18:24 ` Alexei Starovoitov [this message]
2026-10-12 21:34 ` [PATCH v2 5/5] agents: add a skill to write commit messages Sasha Levin
2026-10-12 22:47 ` [PATCH v2 0/5] agents: add skills for Fixes tags, stable tags, similar bugs, and " Jonathan Corbet
2026-10-13 3:48 ` Kees Cook
2026-10-13 11:22 ` Sasha Levin
2026-10-14 13:51 ` Geert Uytterhoeven
2026-10-15 4:50 ` Kees Cook
2026-10-15 13:37 ` Theodore Tso
2026-10-15 14:35 ` Thorsten Leemhuis
2026-10-15 15:34 ` Kees Cook
2026-10-16 14:49 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6H19P1797J.2QYZAQAOI9FTN@gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=konstantin@linuxfoundation.org \
--cc=ksummit@lists.linux.dev \
--cc=laurent.pinchart@ideasonboard.com \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=mst@redhat.com \
--cc=rdunlap@infradead.org \
--cc=sashal@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tytso@mit.edu \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox