From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B01EC64E7B for ; Wed, 2 Dec 2020 14:17:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB5BB221EB for ; Wed, 2 Dec 2020 14:17:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730241AbgLBORd (ORCPT ); Wed, 2 Dec 2020 09:17:33 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:32809 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727060AbgLBORd (ORCPT ); Wed, 2 Dec 2020 09:17:33 -0500 X-Originating-IP: 93.29.109.196 Received: from aptenodytes (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 0F5322001D; Wed, 2 Dec 2020 14:16:44 +0000 (UTC) Date: Wed, 2 Dec 2020 15:16:44 +0100 From: Paul Kocialkowski To: Maxime Ripard Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devel@driverdev.osuosl.org, linux-sunxi@googlegroups.com, Yong Deng , Mauro Carvalho Chehab , Rob Herring , Chen-Yu Tsai , Jernej Skrabec , Jonathan Corbet , Kishon Vijay Abraham I , Vinod Koul , Helen Koike , Dafna Hirschfeld , Greg Kroah-Hartman , Philipp Zabel , Sakari Ailus , Hans Verkuil , Thomas Petazzoni , kevin.lhopital@hotmail.com Subject: Re: [PATCH v2 06/19] dt-bindings: media: sun6i-a31-csi: Add MIPI CSI-2 input port Message-ID: References: <20201128142839.517949-1-paul.kocialkowski@bootlin.com> <20201128142839.517949-7-paul.kocialkowski@bootlin.com> <20201201104321.rl3ujt5pjre6xlmm@gilmour> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bQSyNp+lgLUEvy9B" Content-Disposition: inline In-Reply-To: <20201201104321.rl3ujt5pjre6xlmm@gilmour> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org --bQSyNp+lgLUEvy9B Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue 01 Dec 20, 11:43, Maxime Ripard wrote: > On Sat, Nov 28, 2020 at 03:28:26PM +0100, Paul Kocialkowski wrote: > > The A31 CSI controller supports two distinct input interfaces: > > parallel and an external MIPI CSI-2 bridge. The parallel interface > > is often connected to a set of hardware pins while the MIPI CSI-2 > > bridge is an internal FIFO-ish link. As a result, these two inputs > > are distinguished as two different ports. > >=20 > > Note that only one of the two may be present on a controller instance. > > For example, the V3s has one controller dedicated to MIPI-CSI2 and one > > dedicated to parallel. > >=20 > > Update the binding with an explicit ports node that holds two distinct > > port nodes: one for parallel input and one for MIPI CSI-2. > >=20 > > This is backward-compatible with the single-port approach that was > > previously taken for representing the parallel interface port, which > > stays enumerated as fwnode port 0. However, it is now marked as > > deprecated and the multi-port approach should be preferred. > >=20 > > Note that additional ports may be added in the future, especially to > > support feeding the CSI controller's output to the ISP. > >=20 > > Signed-off-by: Paul Kocialkowski > > --- > > .../media/allwinner,sun6i-a31-csi.yaml | 86 ++++++++++++++++--- > > 1 file changed, 73 insertions(+), 13 deletions(-) > >=20 > > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun6i-a3= 1-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-cs= i.yaml > > index 1fd9b5532a21..3bcee2d44f3c 100644 > > --- a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.y= aml > > +++ b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.y= aml > > @@ -43,6 +43,7 @@ properties: > > # See ./video-interfaces.txt for details > > port: > > type: object > > + deprecated: true >=20 > I'm not sure we want to deprecate it. There's some SoCs with the same > controller but without the MIPI-CSI block where this would be completely > valid I think we'll need to deprecate it when adding support for the ISP anyway, so I figured we might as well do it now. But I'm okay to postpone this for = now. > > properties: > > endpoint: > > @@ -67,6 +68,59 @@ properties: > > =20 > > additionalProperties: false > > =20 > > + ports: > > + type: object > > + > > + properties: > > + port@0: > > + type: object > > + description: Parallel input port, connect to a parallel sensor > > + > > + properties: > > + reg: > > + const: 0 > > + > > + endpoint: > > + type: object > > + > > + properties: > > + remote-endpoint: true > > + > > + bus-width: > > + enum: [ 8, 10, 12, 16 ] > > + > > + pclk-sample: true > > + hsync-active: true > > + vsync-active: true > > + > > + required: > > + - bus-width > > + - remote-endpoint > > + > > + required: > > + - endpoint > > + > > + additionalProperties: false > > + > > + port@1: > > + type: object > > + description: MIPI CSI-2 bridge input port > > + > > + properties: > > + reg: > > + const: 1 > > + > > + endpoint: > > + type: object > > + > > + properties: > > + remote-endpoint: true > > + > > + required: > > + - remote-endpoint > > + > > + additionalProperties: false >=20 > There's a schema for the OF-graph now, you'll want to use it. I didn't know that, thanks for the tip! Will look into it. Cheers, Paul --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --bQSyNp+lgLUEvy9B Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAl/HocwACgkQ3cLmz3+f v9GG9Af9H1paVLqMvziqXTI0WNg+VMR5O6DYyo7mI+qYy2k13gShP+emMEuZsLhm vSOVR/gIRIotX+0dO2+BOj9ik0+7WiwtAfXdIsUo6kGhHxay1go4E8Xuy5YimqO2 zMcpf200AlTfTE+1dFfP0Cbujt5wWH0WSYwFL/pbckNDb1TLC6KFJfBIgtN4T9q2 31Ci4ZtaU1NmOrclYkJTT3eDtzYd4bqgbTScXJ+8gnnrIjRQi8jxEqOJGYj5sx5g biJTcl8+INexfPsV6O9c3Jl0QnwjGMp8avD8cjnHVf4SsshhrIklOjAtVxjpAElZ zmr7Z4hAcpREkZpZQy5bNeJjzm9gCg== =O/vb -----END PGP SIGNATURE----- --bQSyNp+lgLUEvy9B--