From: Sasha Levin <sashal@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Brian Haley <haleyb.dev@gmail.com>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
corbet@lwn.net, den@openvz.org, razor@blackwall.org,
ulf.hansson@linaro.org, Jason@zx2c4.com, wangyuweihx@gmail.com,
daniel@iogearbox.net, thomas.zeitlhofer+lkml@ze-it.at,
alexander@mihalicyn.com, ja@ssi.bg, netdev@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 6.2 31/53] neighbor: fix proxy_delay usage when it is zero
Date: Wed, 1 Mar 2023 09:13:31 -0500 [thread overview]
Message-ID: <Y/9dizGq97wpbZpn@sashalap> (raw)
In-Reply-To: <20230227101504.45ef890c@kernel.org>
On Mon, Feb 27, 2023 at 10:15:04AM -0800, Jakub Kicinski wrote:
>On Sun, 26 Feb 2023 09:44:23 -0500 Sasha Levin wrote:
>> From: Brian Haley <haleyb.dev@gmail.com>
>>
>> [ Upstream commit 62e395f82d04510b0f86e5e603e29412be88596f ]
>>
>> When set to zero, the neighbor sysctl proxy_delay value
>> does not cause an immediate reply for ARP/ND requests
>> as expected, it instead causes a random delay between
>> [0, U32_MAX). Looking at this comment from
>> __get_random_u32_below() explains the reason:
>
>Potential behavior change, can we wait 4 weeks, until it's been
>in a couple of -rcs?
Ack, will revisit this later. Thanks!
--
Thanks,
Sasha
prev parent reply other threads:[~2023-03-01 14:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230226144446.824580-1-sashal@kernel.org>
2023-02-26 14:44 ` [PATCH AUTOSEL 6.2 22/53] bpf, docs: Fix modulo zero, division by zero, overflow, and underflow Sasha Levin
2023-02-26 14:44 ` [PATCH AUTOSEL 6.2 31/53] neighbor: fix proxy_delay usage when it is zero Sasha Levin
2023-02-27 18:15 ` Jakub Kicinski
2023-03-01 14:13 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/9dizGq97wpbZpn@sashalap \
--to=sashal@kernel.org \
--cc=Jason@zx2c4.com \
--cc=alexander@mihalicyn.com \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=den@openvz.org \
--cc=edumazet@google.com \
--cc=haleyb.dev@gmail.com \
--cc=ja@ssi.bg \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=stable@vger.kernel.org \
--cc=thomas.zeitlhofer+lkml@ze-it.at \
--cc=ulf.hansson@linaro.org \
--cc=wangyuweihx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox