From: Nathan Chancellor <nathan@kernel.org>
To: Sangmoon Kim <sangmoon.kim@samsung.com>
Cc: bagasdotme@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
masahiroy@kernel.org, ndesaulniers@google.com, nicolas@fjasle.eu
Subject: Re: [PATCH v2] docs: kbuild: remove description of KBUILD_LDS_MODULE
Date: Wed, 22 Feb 2023 09:21:02 -0700 [thread overview]
Message-ID: <Y/ZA7kqeWtWAcVZu@dev-arch.thelio-3990X> (raw)
In-Reply-To: <20230222104719.16374-1-sangmoon.kim@samsung.com>
On Wed, Feb 22, 2023 at 07:47:19PM +0900, Sangmoon Kim wrote:
> Commit 596b0474d3d9 ("kbuild: preprocess module linker script")
> removes KBUILD_LDS_MODULE, yet the variable is still mentioned in
> kbuild documentation. Remove the reference to the now-nonexistent
> variable.
>
> Signed-off-by: Sangmoon Kim <sangmoon.kim@samsung.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> Thank you for your review.
>
> Changes in v2:
> - Update the commit message.
>
> Documentation/kbuild/makefiles.rst | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/Documentation/kbuild/makefiles.rst b/Documentation/kbuild/makefiles.rst
> index 38bc74eaa547..468e7830c1c3 100644
> --- a/Documentation/kbuild/makefiles.rst
> +++ b/Documentation/kbuild/makefiles.rst
> @@ -1250,11 +1250,6 @@ When kbuild executes, the following steps are followed (roughly):
>
> The linker script with full path. Assigned by the top-level Makefile.
>
> - KBUILD_LDS_MODULE
> -
> - The module linker script with full path. Assigned by the top-level
> - Makefile and additionally by the arch Makefile.
> -
> KBUILD_VMLINUX_OBJS
>
> All object files for vmlinux. They are linked to vmlinux in the same
> --
> 2.17.1
>
next prev parent reply other threads:[~2023-02-22 16:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230222004609epcas1p2eb7e213b2b3503d018fcd6d58b9497b2@epcas1p2.samsung.com>
2023-02-22 0:45 ` [PATCH] docs: kbuild: remove description of KBUILD_LDS_MODULE Sangmoon Kim
2023-02-22 7:33 ` Bagas Sanjaya
2023-02-22 10:47 ` [PATCH v2] " Sangmoon Kim
2023-02-22 16:21 ` Nathan Chancellor [this message]
2023-02-25 8:41 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/ZA7kqeWtWAcVZu@dev-arch.thelio-3990X \
--to=nathan@kernel.org \
--cc=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=sangmoon.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox