From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9249AC433FE for ; Tue, 11 Oct 2022 18:47:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229872AbiJKSr6 (ORCPT ); Tue, 11 Oct 2022 14:47:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229802AbiJKSr5 (ORCPT ); Tue, 11 Oct 2022 14:47:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8375784E43; Tue, 11 Oct 2022 11:47:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1CB6F61277; Tue, 11 Oct 2022 18:47:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07C6DC4314C; Tue, 11 Oct 2022 18:47:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665514069; bh=d5RRKxQbKRz2TycMKkEiQane8TWoQjQVycIG9gWcv6c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zuE3UyQu22I/ykCVQKxDAlyPkucwHD77jc3RLRZKQUEf1GrkYa7W1w45bi2jwZ2FH hmEoKx/IAIwylgeOUAlAcDiBqQbw90YreVNrudvc/vpqvKzP/YzSisNvb2uRwxTuir YdT4/XvzLuZPkxIK4hDGXSUSV2dGPyxFttixWZtY= Date: Tue, 11 Oct 2022 20:48:33 +0200 From: Greg Kroah-Hartman To: Elliot Berman Cc: Bjorn Andersson , Arnd Bergmann , Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Prakruthi Deepak Heragu , Andy Gross , Dmitry Baryshkov , Jassi Brar , linux-arm-kernel@lists.infradead.org, Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Will Deacon , Catalin Marinas , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 03/13] gunyah: Common types and error codes for Gunyah hypercalls Message-ID: References: <20221011000840.289033-1-quic_eberman@quicinc.com> <20221011000840.289033-4-quic_eberman@quicinc.com> <52b07662-666a-2fc7-cb18-a9d294f7ae9b@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52b07662-666a-2fc7-cb18-a9d294f7ae9b@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, Oct 11, 2022 at 11:21:36AM -0700, Elliot Berman wrote: > > > On 10/11/2022 12:21 AM, Greg Kroah-Hartman wrote: > > On Mon, Oct 10, 2022 at 05:08:30PM -0700, Elliot Berman wrote: > > > Add architecture-independent standard error codes, types, and macros for > > > Gunyah hypercalls. > > > > > > Signed-off-by: Elliot Berman > > > --- > > > MAINTAINERS | 1 + > > > include/asm-generic/gunyah.h | 74 ++++++++++++++++++++++++++++++++++++ > > > 2 files changed, 75 insertions(+) > > > create mode 100644 include/asm-generic/gunyah.h > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index ef6de7599d98..4fe8cec61551 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -8886,6 +8886,7 @@ L: linux-arm-msm@vger.kernel.org > > > S: Supported > > > F: Documentation/devicetree/bindings/firmware/gunyah-hypervisor.yaml > > > F: Documentation/virt/gunyah/ > > > +F: include/asm-generic/gunyah.h > > > HABANALABS PCI DRIVER > > > M: Oded Gabbay > > > diff --git a/include/asm-generic/gunyah.h b/include/asm-generic/gunyah.h > > > new file mode 100644 > > > index 000000000000..64a02dd3b5ad > > > --- /dev/null > > > +++ b/include/asm-generic/gunyah.h > > > > Why not include/linux/gunyah.h? Why asm-generic? This is not an > > architecture. > > > > My idea here is to differentiate between code that interacts with hypercalls > and code that uses the abstractions provided on top of those hypercalls. > include/asm-generic/gunyah.h contains architecture-independent definitions > for hypercalls. Hypercalls are architecture-specific. > > For instance, I wanted to avoid a header file that mixes the definitions for > the message-queue mailbox with the hypercall definitions that the > message-queue mailbox driver itself uses. > > I can put it all in include/linux/gunyah.h and delineate with some clear > comments, but I initially felt it would be better to have separate header > file. Please put it all in one place, this is just one tiny driver and should not abuse the asm-generic location at all, no one is only going to want just this one file, they are going to need the whole thing or nothing. thanks, greg k-h