From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Maciej Kwapulinski <maciej.kwapulinski@linux.intel.com>
Cc: Daniel Vetter <daniel@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Arnd Bergmann <arnd@arndb.de>, Jonathan Corbet <corbet@lwn.net>,
Derek Kiernan <derek.kiernan@xilinx.com>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Olof Johansson <olof@lixom.net>,
dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org,
Tomasz Jankowski <tomasz1.jankowski@intel.com>,
Mikolaj Grzybowski <mikolajx.grzybowski@intel.com>,
Jianxun Zhang <jianxun.zhang@linux.intel.com>
Subject: Re: [PATCH v5 05/10] gna: add GNA_GET_PARAMETER ioctl
Date: Fri, 21 Oct 2022 06:23:14 +0200 [thread overview]
Message-ID: <Y1Iesvp3H3Ow4ZaE@kroah.com> (raw)
In-Reply-To: <20221020175334.1820519-6-maciej.kwapulinski@linux.intel.com>
On Thu, Oct 20, 2022 at 07:53:29PM +0200, Maciej Kwapulinski wrote:
> From: Tomasz Jankowski <tomasz1.jankowski@intel.com>
>
> As this is first ioctl in the series, the patch also adds common bits for
> remaining ioctls
Again, please read the documentation for what to do here, this is not
helpful at all.
> +int gna_getparam_ioctl(struct drm_device *dev, void *data,
> + struct drm_file *file)
> +{
> + struct gna_device *gna_priv = to_gna_device(dev);
> + union gna_parameter *param = data;
> +
> + return gna_getparam(gna_priv, param);
Wrong error value returned if you have an invalid ioctl :(
greg k-h
next prev parent reply other threads:[~2022-10-21 4:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 17:53 [PATCH v5 00/10] Driver of Intel(R) Gaussian & Neural Accelerator Maciej Kwapulinski
2022-10-20 17:53 ` [PATCH v5 01/10] gna: add PCI driver module Maciej Kwapulinski
2022-10-20 18:49 ` Andy Shevchenko
2022-10-21 4:02 ` Bagas Sanjaya
2022-10-21 4:20 ` Greg Kroah-Hartman
2022-10-21 8:10 ` Bagas Sanjaya
2022-10-21 8:27 ` Greg Kroah-Hartman
2022-10-24 13:40 ` Maciej Kwapulinski
2022-10-20 17:53 ` [PATCH v5 02/10] gna: add GNA DRM device Maciej Kwapulinski
2022-10-20 18:52 ` Andy Shevchenko
2022-10-21 4:25 ` Greg Kroah-Hartman
2022-10-20 17:53 ` [PATCH v5 03/10] gna: read hardware info Maciej Kwapulinski
2022-10-21 4:21 ` Greg Kroah-Hartman
2022-10-21 9:19 ` Linus Walleij
2022-10-20 17:53 ` [PATCH v5 04/10] gna: initialize MMU Maciej Kwapulinski
2022-10-20 19:00 ` Andy Shevchenko
2022-10-20 19:01 ` Andy Shevchenko
2022-10-20 17:53 ` [PATCH v5 05/10] gna: add GNA_GET_PARAMETER ioctl Maciej Kwapulinski
2022-10-21 4:23 ` Greg Kroah-Hartman [this message]
2022-10-20 17:53 ` [PATCH v5 06/10] gna: add GNA_GEM_NEW and GNA_GEM_FREE ioctls Maciej Kwapulinski
2022-10-20 19:06 ` Andy Shevchenko
2022-10-20 17:53 ` [PATCH v5 07/10] gna: add GNA_COMPUTE ioctl Maciej Kwapulinski
2022-10-21 9:30 ` Linus Walleij
2022-10-21 11:52 ` Maciej Kwapulinski
2022-10-21 11:57 ` Maciej Kwapulinski
2022-10-20 17:53 ` [PATCH v5 08/10] gna: add GNA_WAIT ioctl Maciej Kwapulinski
2022-10-21 4:25 ` Greg Kroah-Hartman
2022-10-20 17:53 ` [PATCH v5 09/10] gna: add power management Maciej Kwapulinski
2022-10-21 9:37 ` Linus Walleij
2022-10-20 17:53 ` [PATCH v5 10/10] gna: add open and close operations on GNA device Maciej Kwapulinski
2022-10-21 4:27 ` Greg Kroah-Hartman
2022-10-21 9:23 ` Daniel Vetter
2022-10-20 19:08 ` [PATCH v5 00/10] Driver of Intel(R) Gaussian & Neural Accelerator Andy Shevchenko
2022-10-21 4:17 ` Greg Kroah-Hartman
2022-10-24 13:21 ` Maciej Kwapulinski
2022-10-24 11:29 ` Thomas Zimmermann
2023-01-24 8:25 ` Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1Iesvp3H3Ow4ZaE@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=daniel@ffwll.ch \
--cc=derek.kiernan@xilinx.com \
--cc=dragan.cvetic@xilinx.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jianxun.zhang@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maciej.kwapulinski@linux.intel.com \
--cc=mikolajx.grzybowski@intel.com \
--cc=mripard@kernel.org \
--cc=olof@lixom.net \
--cc=tomasz1.jankowski@intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).