From: Andrew Lunn <andrew@lunn.ch>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, Florian Fainelli <f.fainelli@gmail.com>,
corbet@lwn.net, michael.chan@broadcom.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, huangguangbin2@huawei.com,
chenhao288@hisilicon.com, moshet@nvidia.com,
linux@rempel-privat.de, linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next v3] ethtool: linkstate: add a statistic for PHY down events
Date: Wed, 2 Nov 2022 00:48:26 +0100 [thread overview]
Message-ID: <Y2GwSq0EkFvgVWLb@lunn.ch> (raw)
In-Reply-To: <20221101052601.162708-1-kuba@kernel.org>
> +struct ethtool_link_ext_stats {
> + /* Custom Linux statistic for PHY level link down events.
> + * In a simpler world it should be equal to netdev->carrier_down_count
> + * unfortunately netdev also counts local reconfigurations which don't
> + * actually take the physical link down, not to mention NC-SI which,
> + * if present, keeps the link up regardless of host state.
> + * This statistic counts when PHY _actually_ went down, or lost link.
> + */
> + u64 link_down_events;
Might be worth a comment why this is a u64 even when the uAPI has a
u32.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
prev parent reply other threads:[~2022-11-01 23:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 5:26 [PATCH net-next v3] ethtool: linkstate: add a statistic for PHY down events Jakub Kicinski
2022-11-01 6:08 ` Michael Chan
2022-11-01 23:48 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2GwSq0EkFvgVWLb@lunn.ch \
--to=andrew@lunn.ch \
--cc=chenhao288@hisilicon.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=huangguangbin2@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rempel-privat.de \
--cc=michael.chan@broadcom.com \
--cc=moshet@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox