From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41515C43219 for ; Mon, 7 Nov 2022 14:41:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231527AbiKGOlR (ORCPT ); Mon, 7 Nov 2022 09:41:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232157AbiKGOlQ (ORCPT ); Mon, 7 Nov 2022 09:41:16 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9C281A05D; Mon, 7 Nov 2022 06:41:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667832075; x=1699368075; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=u3e6+JJ5A3zX1Hk0G74jg5cr+39BSLGe2g515DJqP0M=; b=ZnyKKamfg9C/tojgiRre23ItnUFX4z1pEe+e6ah2bLO+q8tMQYjFIu9p Crhi7NzOKW8OGazR0/6g/OsQrtJbesipBWL7uhQYioGRM4qkAG6Tx8cvT Fc/Hy6mMdmMJRDFmynbp9yhr63DzfuhoCsqbfRKQGN8gYpNl+OVKA1ku0 5b8dNbeTpsmaBmkelZ0XqwElvxjjd9qA0jw3dLShWBlqteIuRbWgLvsIA 6DRxMxLE+Vwnhj3ZfoQi0d2UDA9C7w8uof/mOrf+CDVcOVWr/IsCG5Zgt rm9MAstwqBOBcCNP5QVbaJHLsOJwA6y3xlSYIFGmi40w3emmJKL/wMQy5 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="374674887" X-IronPort-AV: E=Sophos;i="5.96,145,1665471600"; d="scan'208";a="374674887" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Nov 2022 06:41:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="704894936" X-IronPort-AV: E=Sophos;i="5.96,145,1665471600"; d="scan'208";a="704894936" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 07 Nov 2022 06:41:09 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1os3JB-008hYc-2r; Mon, 07 Nov 2022 16:41:05 +0200 Date: Mon, 7 Nov 2022 16:41:05 +0200 From: Andy Shevchenko To: Petr Mladek Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Vlastimil Babka , Naoya Horiguchi , Miaohe Lin , Matthew Wilcox , Minchan Kim , Mel Gorman , Andrea Arcangeli , Dan Williams , Hugh Dickins , Muchun Song , David Hildenbrand , Steven Rostedt , Sergey Senozhatsky , Rasmus Villemoes , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v2 3/3] mm, printk: introduce new format %pGt for page_type Message-ID: References: <20221106140355.294845-1-42.hyeyoo@gmail.com> <20221106140355.294845-4-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, Nov 07, 2022 at 03:20:34PM +0100, Petr Mladek wrote: > On Mon 2022-11-07 13:18:52, Andy Shevchenko wrote: > > On Sun, Nov 06, 2022 at 11:03:55PM +0900, Hyeonggon Yoo wrote: > > > dump_page() uses %pGp format to print 'flags' field of struct page. ... > > > [ 1.816443] page_type: 0xffffffff() > > > > Why do we have empty parentheses? I would expect either something there, or no > > parentheses at all. > > This looks fine. format_page_flags() does the same for %pGp. ... > > > + %pGt 0xffefffff(slab) > > > > No space before ( ? > > Also looks fine. %pGp does the same. Maybe we can modify them before or after this change? -- With Best Regards, Andy Shevchenko