From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1171C433FE for ; Wed, 9 Nov 2022 08:13:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229526AbiKIINT (ORCPT ); Wed, 9 Nov 2022 03:13:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229516AbiKIINS (ORCPT ); Wed, 9 Nov 2022 03:13:18 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F7EE1902F; Wed, 9 Nov 2022 00:13:17 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id A64331F8C4; Wed, 9 Nov 2022 08:13:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667981595; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iZ41zAxuFab1VbpZbOqMuhHV5p0NUYaSK2sGuoKt9j4=; b=A39M7ugjky4HJHQHpgupgCpSL4sIzdbSNnEklOL1SK2k8fgTBZ0UquiKGpX2rsgBpG5RKd fiWl+ZiIHC1FiY5c5gjE2ZFIKCevpdQ/RaPk3QCEmR1nQV6KTg/HAY0deZ95bnD5JxnHpP 9qW8VmwXRjZZy3Ymanng8AOAF0PFh8o= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id B9CAB2C141; Wed, 9 Nov 2022 08:13:13 +0000 (UTC) Date: Wed, 9 Nov 2022 09:13:11 +0100 From: Petr Mladek To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Joe Perches , linux-mm@kvack.org, Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Vlastimil Babka , Naoya Horiguchi , Miaohe Lin , Matthew Wilcox , Minchan Kim , Mel Gorman , Andrea Arcangeli , Dan Williams , Hugh Dickins , Muchun Song , David Hildenbrand , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v2 3/3] mm, printk: introduce new format %pGt for page_type Message-ID: References: <20221106140355.294845-1-42.hyeyoo@gmail.com> <20221106140355.294845-4-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Wed 2022-11-09 15:14:05, Hyeonggon Yoo wrote: > On Sun, Nov 06, 2022 at 10:04:25AM -0800, Joe Perches wrote: > > On Sun, 2022-11-06 at 23:03 +0900, Hyeonggon Yoo wrote: > > > dump_page() uses %pGp format to print 'flags' field of struct page. > > > As some page flags (e.g. PG_buddy, see page-flags.h for more details) > > > are set in page_type field, introduce %pGt format which provides > > > human readable output of page_type. And use it in dump_page(). > > [] > > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c > > [] > > > @@ -2056,6 +2056,28 @@ char *format_page_flags(char *buf, char *end, unsigned long flags) > > > return buf; > > > } > > > > > > +static > > Thanks for looking at this. > > > > > noinline_for_stack ? Honestly, I do not like much adding this without numbers. It has been added to some functions in vsprintf.c long time ago because it reduced the stack usage. But I think that it is a compiler and an architecture specific. And it is not clear if it would really help in this particular case. Feel free to omit it. Best Regards, Petr