From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D072CC352A1 for ; Tue, 6 Dec 2022 08:58:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234422AbiLFI65 (ORCPT ); Tue, 6 Dec 2022 03:58:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234428AbiLFI64 (ORCPT ); Tue, 6 Dec 2022 03:58:56 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D64131C436; Tue, 6 Dec 2022 00:58:54 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8CDB0B818CB; Tue, 6 Dec 2022 08:58:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66E59C433D6; Tue, 6 Dec 2022 08:58:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670317132; bh=6hC6q62YWRveam3AL7WSGJpsWyeG22u37HMG9JMaXxI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JxAx8/GRcTVX4o2aj8TMqSfS3DniSNQTXtVyyWTHnu04UZrE8lIRIkEs2zgajhb+Y /d1npkJhZpmQGMB8fzBR2pfIfmr2BRqIOc5wEFItejAUjdzxQEl8M4IE6jA+jWn6fF 6NjOZ50sauClyO96Npps56VDmWqJ1BjEpu1W0nMoPmjXxPvQSyTNqbyr0YUDeszwK1 csYOB3+dcqukLq67Tq2clIN2l+ji2Xy0FqjpOJBJhvsbUhv48B1klyrJZqSHjKeFO6 gBo7ztvCebJZrlewCuMtZ8H3PBpc13UpKAro9bg4Hl1SFT5HnaE/CjPVkx4P+CSxPC 3NoK9YbbNf7SA== Date: Tue, 6 Dec 2022 10:58:47 +0200 From: Leon Romanovsky To: Jakub Kicinski Cc: Veerasenareddy Burru , "David S. Miller" , Eric Dumazet , Paolo Abeni , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Liron Himi , Abhijit Ayarekar , Sathesh B Edara , Satananda Burla , "linux-doc@vger.kernel.org" Subject: Re: [EXT] Re: [PATCH net-next v2 2/9] octeon_ep: poll for control messages Message-ID: References: <20221129130933.25231-1-vburru@marvell.com> <20221129130933.25231-3-vburru@marvell.com> <20221205161626.088e383f@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221205161626.088e383f@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, Dec 05, 2022 at 04:16:26PM -0800, Jakub Kicinski wrote: > On Mon, 5 Dec 2022 10:10:34 +0200 Leon Romanovsky wrote: > > > These messages include periodic keep alive (heartbeat) messages > > > from FW and control messages from VFs. Every PF will be listening > > > for its own control messages. > > > > @netdev, as I said, I don't know if it is valid behaviour in netdev. > > Can you please comment? > > Polling for control messages every 100ms? Sure. > > You say "valid in netdev" so perhaps you can educate us where/why it > would not be? It doesn't seem right to me that idle device burns CPU cycles, while it supports interrupts. If it needs "listen to FW", it will be much nicer to install interrupts immediately and don't wait for netdev. Thanks